Re: [Gen-art] review of draft-ietf-ccamp-mw-yang-09.txt
Jonas Ahlberg <jonas.ahlberg@ericsson.com> Wed, 03 October 2018 11:22 UTC
Return-Path: <jonas.ahlberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FE5E130EDB for <gen-art@ietfa.amsl.com>; Wed, 3 Oct 2018 04:22:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.756
X-Spam-Level:
X-Spam-Status: No, score=-4.756 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=YyOBPp8V; dkim=pass (1024-bit key) header.d=ericsson.com header.b=MeJCZx7f
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z_R4fQ4cPQmM for <gen-art@ietfa.amsl.com>; Wed, 3 Oct 2018 04:22:30 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A41C13122C for <gen-art@ietf.org>; Wed, 3 Oct 2018 04:22:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1538565743; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=di8a+a8tAexWl7GuNa9IxllBqfKiEkD8w6TwU8f75ao=; b=YyOBPp8VGrhonq7x1bE24XYTYMOcCEFB/egASePg07Awgkj+4tXPkaJB6tZqZ16V btQQ/2wWjEY3+Cizs4kS0RvI4cJiWgn/oi9mauHB5+iw5WfQ8IFvVvSagYOtV9jO uL1eUDarEScHiB+kNGKu+UGNy81e82hGy7K/IldOz/U=;
X-AuditID: c1b4fb3a-395ff70000003197-b9-5bb4a66f39a9
Received: from ESESSMB505.ericsson.se (Unknown_Domain [153.88.183.123]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 12.23.12695.F66A4BB5; Wed, 3 Oct 2018 13:22:23 +0200 (CEST)
Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 3 Oct 2018 13:22:22 +0200
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 3 Oct 2018 13:22:22 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PVYqB/AU3MHrn63RTEFUK1bVUA7MV71tnNN7ydb54I=; b=MeJCZx7fHtBZeYAxDGZvDt5LicV40JIH4bePeQlwRFcYSSNGrxltp61BWT3Ush8F+k24OqMX0f820VZN4BJZ3DZMMGOZK8e5PguUX5Zm+BXWVoJdJHDikimMJtOq7vDPwvnQIkDTiR9quQZLzfID/MTg58qkQ8X+GpczdH/LMpA=
Received: from DB6SPR01MB06.eurprd07.prod.outlook.com (10.175.241.140) by AM6SPR01MB01.eurprd07.prod.outlook.com (52.133.25.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.16; Wed, 3 Oct 2018 11:22:22 +0000
Received: from DB6SPR01MB06.eurprd07.prod.outlook.com ([fe80::a5f5:f4fc:f069:4f0d]) by DB6SPR01MB06.eurprd07.prod.outlook.com ([fe80::a5f5:f4fc:f069:4f0d%5]) with mapi id 15.20.1207.021; Wed, 3 Oct 2018 11:22:21 +0000
From: Jonas Ahlberg <jonas.ahlberg@ericsson.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-ccamp-mw-yang.all@ietf.org" <draft-ietf-ccamp-mw-yang.all@ietf.org>, "ccamp-chairs@ietf.org" <ccamp-chairs@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, "db3546@att.com" <db3546@att.com>, "Yemin (Amy)" <amy.yemin@huawei.com>, "'Xi Li <Xi.Li@neclab.eu> (Xi.Li@neclab.eu)'" <Xi.Li@neclab.eu>, "daniela.spreafico@nokia.com" <daniela.spreafico@nokia.com>, "marko.vaupotic@aviatnet.com" <marko.vaupotic@aviatnet.com>
Thread-Topic: review of draft-ietf-ccamp-mw-yang-09.txt
Thread-Index: AQHUWpREypX1lF7p70SVIwM5bA/F6KUNWRSA
Date: Wed, 03 Oct 2018 11:22:21 +0000
Message-ID: <DB6SPR01MB0658D11F89FEEE34CA388389E90@DB6SPR01MB06.eurprd07.prod.outlook.com>
References: <201810022034.w92KYepv005399@givry.fdupont.fr>
In-Reply-To: <201810022034.w92KYepv005399@givry.fdupont.fr>
Accept-Language: sv-SE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=jonas.ahlberg@ericsson.com;
x-originating-ip: [192.176.1.93]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM6SPR01MB01; 6:2Eb2ijO3joN6W1USkNLgNgSwcVcbMk0DqMRhs0M+QQWCKeyr7PvsdMxNHbaWDNafBTj8i3YXyyFhnfavd6dktuAhOWnDmjisA8zD1RaBDeykxPV85jH3iQ0M3aoFRk3cl1mxgDggxP1q9GHvDnbYOmmBZ8cyVBO6t5T4Onw2+Sw0jB1Em0lzBirv5rZHGbWPL2ZL2E0XJqHz1+/3KCRrOqoKzstazAyVE25A+GEFa/93R2uKxPYVd7+XfCbfyPvsVriyf0mG+Sy8KYhww9m4DWdfd6M4UXpl5M2vB11xqmCLdEHsagWGBcwJA8+xIZqijw3z+VrCm3CvWIBUZjYBEEOuGSsIXWBKJLseCYhAlXs0DoQbp9R02KyDE6l/pNGi6U71qQNCOBdaue3JEr5YZ7Qm5JVcd9a/g8d83rDvHqu3Jvjj/MEJ3urZO0i/VzdZ8A6Y+YNPP1/5zr5s2gzsZQ==; 5:5uZW+6VxFYmFFlw4SPTqxmI+UVm1c6CwvGOZuuM3GSiejvvyIHegYyV5YGUtnnI2qYVe3E3GkaeWuTepMQWn+xsTS9EBHY4zbFPHJ041oy0JWK+VyG/NrGaRpKSGMNtMAHAHZBSRuoauzuoAkH3R+FLZJBv1IvcJPcbdMcN53no=; 7:/4Jgd5i8qoNly4I81n83lo8X/2WqSrGSsu1R7Vf6sqMm6TnxWApyU/pJFfvRJ5oJK8FNprQ/ks60O5ZqbXx5jB7fGmgszV6z25zrWwth0mLU79WSYKm5hhN2zntAyV1LzpbAa7BYRUefs8eXhoukR/R8hHbKEpx2woLctrK8JRKLExa+uoqGcvL8L1EbbbMVuLH51lH9UEODwx2cvy8pXLX+8IJ03LvrVIk/VyK+uqN3N5N+F6yQnu+IjJm0nrxj
x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR;
x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(366004)(136003)(346002)(376002)(39860400002)(199004)(189003)(13464003)(4326008)(25786009)(9686003)(53936002)(186003)(6246003)(66066001)(71190400001)(71200400001)(966005)(102836004)(3846002)(6116002)(81156014)(2906002)(6506007)(53546011)(14454004)(81166006)(86362001)(26005)(8936002)(6436002)(68736007)(229853002)(478600001)(6306002)(55016002)(110136005)(7696005)(33656002)(76176011)(54906003)(97736004)(2501003)(74316002)(99286004)(5250100002)(7736002)(305945005)(256004)(105586002)(106356001)(316002)(2900100001)(446003)(11346002)(5660300001)(476003)(486006)(44832011)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6SPR01MB01; H:DB6SPR01MB06.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
x-ms-office365-filtering-correlation-id: 679e6968-f0d5-42ab-2c27-08d629227c89
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:AM6SPR01MB01;
x-ms-traffictypediagnostic: AM6SPR01MB01:
x-microsoft-antispam-prvs: <AM6SPR01MB01950FE2C24EB98028030989E90@AM6SPR01MB01.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(120809045254105);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051); SRVR:AM6SPR01MB01; BCL:0; PCL:0; RULEID:; SRVR:AM6SPR01MB01;
x-forefront-prvs: 0814A2C7A3
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: e+0YvCPqHgeQA082tkjMVqSfL7naW3ivR5uBolX+lAdG4x2QjqORGWg/3w2v06l87wZalbUGi3XET5L2J5AVUW9Jn4nrdsiXemLD95H8K8S9qDjSamxOX61cUkhhueYTs/DrJPHeqADVEwkovymnA7cvV12i+rizXNb6xbSqJuhP5p+a1oLqkZe+vpBfG0lHXxUSm8IJeJiBc1VGpU5BLSYW4aGojJFleJiaENTNGHST6svud8TBTMp8qxVbRjOVA8Dn2YLe6307v0aroH9+cRTp+oxoMn5yzl5KrPc8SldkCmEVsd+++RpERGWoRDZ9GpSMsaWWoI25kTNmoF9XngcFox637Sa6VgORJi+RGNk=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 679e6968-f0d5-42ab-2c27-08d629227c89
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2018 11:22:21.3574 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6SPR01MB01
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec852zmay7el+KRINvJDaaWjy0GjzA+1PohBUDbLHHq8kDd2 zLIg7ILoNF2ppaapzFtaGiqoWZialiYLXGWWF/BCXqaUZiYTy+0o9O338v8//+fCy5DSNpEj ExkTz6ljVFEysTWVF9B4fU9seUOgR0+GE1uf8lzMljXVEeySoYJiDZo0mtUb6gl29EGziP00 vUCxuZXZNDs030P4WCmmMguQoiP1KVLM5ayIFHfezIoUpaXLhCK3a4pWDH3tI07RSuvDoVxU ZAKn3nck2DpC//kuHde57arufQOVhFrsNMiKAbwfGieHaA2yZqS4E8Hg4Nz6YxFBRXMWZXZJ sY6A9HaRWaCwloQft4ykBjFrgpYAfaJQMIKgNa0amQvE2AOM04/FZrbDZ8HU30GaTSTuJUF7 z2BJ3YoPwm/dKiGYDoHxRSYtsBx6kyssTOGdUKXJsQRJsBKmnw3TwkReUPBQZ6m1wt5Q+uum pTHCzjCyNGzJJ7EDfB0vIoQ9MZS+/EAKbA9TY6siwX8BZienKfMygF1gZEApWJyhrygNmWcG /IqG5IwJShA84e2TVlIQ7othuDlbLAh+kPI3ZV3oQvCzeKPzLlgszqMFjoRBo2k9yRve6QYo LfLM/29Ygd2huGVeLLAblJfMkPmWA2yB7rxxqhhRVcie53g+Olwu38upI0N4PjZmbwwXX4fW PlZbg8mrCbV9P9aOMINkNpLgkoZAqUiVwCdGtyNgSJmdJENVHyiVhKoSr3Hq2Ivqy1Ec346c GErmIPENY5VSHK6K5y5xXByn3lAJxsoxCRU0d1XfPhO0dDyk6bU09vQ5ecs3tkXps/DRrVAv 9zuZcYMvHKP0BpsS1xMl/Tbba8Psu1Nfr2CvWfVg3fiM+5eJA1GVrgU1MsWVR5vcB2yVtkep 4KRMQ/l5E1MTGmSc8M3P2rHflxfRKZsl6do/JpfR3jJ/vWf4SG2cv3QxYFlG8REqz92kmlf9 A88qbllUAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/VOUCBWabbErz3ZrAmO8RtdGdEWQ>
Subject: Re: [Gen-art] review of draft-ietf-ccamp-mw-yang-09.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 11:22:32 -0000
Hi Francis, Thanks for your review. We have now submitted a new version of the draft with the following changes that we hope address your feedback : - The date of the models have been updated to the same date as the draft - There is now a single space before all "{" in the draft - the comments have been removed from the JSON examples. The description leaf is enough to explain what the entry refers to. - I've tried to correct the usage of commas in the JSON examples. Please let me know if it's still not fully correct. - "(ESP)" is removed - " Maintained by IANA?: N" has been added for all modules in the IANA considerations, according to earlier feedback from IANA Regards JonasA ------------------------------ A new version of I-D, draft-ietf-ccamp-mw-yang-10.txt has been successfully submitted by Jonas Ahlberg and posted to the IETF repository. Name: draft-ietf-ccamp-mw-yang Revision: 10 Title: A YANG Data Model for Microwave Radio Link Document date: 2018-10-03 Group: ccamp Pages: 51 URL: https://www.ietf.org/internet-drafts/draft-ietf-ccamp-mw-yang-10.txt Status: https://datatracker.ietf.org/doc/draft-ietf-ccamp-mw-yang/ Htmlized: https://tools.ietf.org/html/draft-ietf-ccamp-mw-yang-10 Htmlized: https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-mw-yang Diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-ccamp-mw-yang-10 ---------------------------------- -----Original Message----- From: Francis Dupont <Francis.Dupont@fdupont.fr> Sent: den 2 oktober 2018 22:35 To: gen-art@ietf.org Cc: draft-ietf-ccamp-mw-yang.all@ietf.org Subject: review of draft-ietf-ccamp-mw-yang-09.txt I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-ccamp-mw-yang-09.txt Reviewer: Francis Dupont Review Date: 20180926 IETF LC End Date: 20181002 IESG Telechat date: unknown Summary: Ready Major issues: None Minor issues: None Nits/editorial comments: The yang model mixes config, state and actions, not like the others I know. But if the Yang experts have no concern I have none too... - 4 page 7: I notices the date of the model is 2018-06-30 when it was modified the 2018-08-31. I don't know the rule, perhaps the date is updated just before publication? Not an issue by itself. - action manual-switch-working page 30 and many others: please add a space before '{'. - A.1 page 46: the JSON is not valid (even it is readable) and I am afraid it is really JSON and not something JSON like. In detail: // does not begin comments in JSON (there are no comments in fact in JSON so IMHO it is not a real problem :-) extra commas (more an issue) - A.1 page 46: please add a space in "single":{ - same comments about A.2 pages 47 and 48, and A.3 pages 48-50 (with BTW two "single":{) - B page 50: Spain (ESP) -> Spain Regards Francis.Dupont@fdupont.fr
- [Gen-art] review of draft-ietf-ccamp-mw-yang-09.t… Francis Dupont
- Re: [Gen-art] review of draft-ietf-ccamp-mw-yang-… Jonas Ahlberg