Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
Vijay Gurbani <vijay.gurbani@gmail.com> Sat, 20 August 2022 17:53 UTC
Return-Path: <vijay.gurbani@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 113A3C14CE45; Sat, 20 Aug 2022 10:53:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jaCXGDs0TkGd; Sat, 20 Aug 2022 10:53:09 -0700 (PDT)
Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2308DC14CE34; Sat, 20 Aug 2022 10:53:09 -0700 (PDT)
Received: by mail-pl1-x62f.google.com with SMTP id u22so6595484plq.12; Sat, 20 Aug 2022 10:53:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=yRXR06aeTFlO1kWjdlp8FBuM/8cJDXE2KtZ7JdZmrfo=; b=CghOysTqr/9bu/e+hpgQU+qwzbps01kmk4Rz/osNgHkTZWABAEAvk70JmXdjB6xqT7 sNcD9hIjMiFABEsWfLT/W6wvpDatvd58YO3KZ9RsjJqIOETI/fmV+HG5j7r6a1JLkW+1 inuJeEw+4z9t5ExpCoy79xPjtUCLzrhsczpKEh1AAusozHGuo3fO14ovGCRLbezE3ywB AQrmxgc3tCaeo823Qo063JxMJ7jN+WAWdnl/rW4TGi/SEmgDLnTIU8FA4cTT1vTXn6BQ RJKLgsbuzkX4pjwoO7UaNjQExj9CSyjQSS/2iNtbp3KeKFRFflbx1YaHQV/5dx/4K57K 1SEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=yRXR06aeTFlO1kWjdlp8FBuM/8cJDXE2KtZ7JdZmrfo=; b=7YFoDBpNSvSxk6oKcC8q5U8Kzhai9RNbr57ZvBg6u9vk1j0LunM17PMltL6fQ+EcBy I+ua/WATbQZ3ycwmTGwtfLQA3e+T6rYbY0L38ZcTxc4bp0n3+dNctwpjZIuGO0D4rV3M B51cSNb7uEQyls9qfuu6YYqKk/k5miunzDZnqcaIxZvFAdK8q6aPSCVsqdOB3y3ZIgpc MoWy3HlIRMfwbKb+QrjvgN+ehnXTjcvn5Twybu1F385rNv1tLTrp4BJUR0jp0R1b/uC6 bvffJzAggJsH0TiMFbU/o74ykYrRaBjXpm22YcgW9Q83MCva6HdiABFz326L5dA5gM1r VLZQ==
X-Gm-Message-State: ACgBeo0MhjWkyF2G0MF3dTHqh50OhPY9D60O3tAmgAS3s6KnCQiYUnf7 7tCom9+LcXHiK4os4KzuZxVOh9bYvPv/hHHtle/I9Fye
X-Google-Smtp-Source: AA6agR6Ihk3UiTsYJPZ2xBOmMPmnnndf3r2QSURTHCRZthstUcXrB47dpLze7I696GcRa1O2g/iF0lQm+pLWvszSO/4=
X-Received: by 2002:a17:902:d2c8:b0:16e:ea4e:36e0 with SMTP id n8-20020a170902d2c800b0016eea4e36e0mr12969079plc.37.1661017988164; Sat, 20 Aug 2022 10:53:08 -0700 (PDT)
MIME-Version: 1.0
References: <166033385333.7724.14555622442470360665@ietfa.amsl.com> <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com> <CAMMTW_KKuY2DphishuXNpnW=yKr0_N4tTRVE3X=Hf5WfvFNANA@mail.gmail.com> <CAH6gdPxMBe6oXxWMdn=H-SmajE-G_grh+USV-iAFhtUUtodS9w@mail.gmail.com>
In-Reply-To: <CAH6gdPxMBe6oXxWMdn=H-SmajE-G_grh+USV-iAFhtUUtodS9w@mail.gmail.com>
From: Vijay Gurbani <vijay.gurbani@gmail.com>
Date: Sat, 20 Aug 2022 12:52:55 -0500
Message-ID: <CAMMTW_+br9_c4=qeCcVW7TRPdcpU6ivfvjzhu3HddZPohUBzqg@mail.gmail.com>
To: Ketan Talaulikar <ketant.ietf@gmail.com>
Cc: "gen-art >> General area reviewing team" <gen-art@ietf.org>, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="00000000000026731d05e6afe357"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/V_nWOunb-Wl0hl_XeU4QTkJEkAQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Aug 2022 17:53:13 -0000
Dear Ketan: Looks good. Thank you for attending to my comments. On Thu, Aug 18, 2022, 8:46 PM Ketan Talaulikar <ketant.ietf@gmail.com> wrote: > Hi Vijay, > > The recent update below includes changes to address your comments. > > https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-ls-flex-algo-10 > > Thanks, > Ketan > > > On Sun, Aug 14, 2022 at 7:00 AM Vijay Gurbani <vijay.gurbani@gmail.com> > wrote: > >> Dear Ketan: Sounds good. Thank you for your time attending to my >> comments. >> >> - vijay >> >> On Sat, Aug 13, 2022 at 12:26 AM Ketan Talaulikar <ketant.ietf@gmail.com> >> wrote: >> >>> Hi Vijay, >>> >>> Thanks for your review and please check inline below for responses. >>> >>> The changes discussed below would reflect in the next update of the >>> document. >>> >>> On Sat, Aug 13, 2022 at 1:20 AM Vijay Gurbani via Datatracker < >>> noreply@ietf.org> wrote: >>> >>>> Reviewer: Vijay Gurbani >>>> Review result: Ready with Nits >>>> >>>> I am the assigned Gen-ART reviewer for this draft. The General Area >>>> Review Team (Gen-ART) reviews all IETF documents being processed >>>> by the IESG for the IETF Chair. Please treat these comments just >>>> like any other last call comments. >>>> >>>> For more information, please see the FAQ at >>>> >>>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >>>> >>>> Document: draft-ietf-idr-bgp-ls-flex-algo-?? >>>> Reviewer: Vijay K. Gurbani >>>> Review Date: 2022-08-12 >>>> IETF LC End Date: 2022-08-17 >>>> IESG Telechat date: Not scheduled for a telechat >>>> >>>> Summary: Draft is ready with nits for a Proposed Standard. >>>> >>>> Major issues: 0 >>>> >>>> Minor issues: 1 (please see below) >>>> >>>> Nits/editorial comments: 4 (please see below) >>>> >>>> Minor: >>>> - Sec. 3.6: Note that Type is "TBD" here. Should this be 1046, as >>>> shown in >>>> Table 1? (Or is the use of 1046 still under discussion?) >>>> >>> >>> KT> This allocation is currently under "Expert Review" - at this point, >>> it is a suggested code point. This will hopefully be completed soon and we >>> will update the document once done. >>> >>> >>>> >>>> Nits: >>>> - I note that certain acronyms --- IGP, NLRI, ASLA --- are not >>>> defined. I >>>> suspect that these are well-known in the community, hence need no >>>> definition. >>>> Just in case they are not, you may consider expanding the rare ones on >>>> first >>>> use. >>> >>> >>> KT> Ack. Fixed some of these acronyms that are not well-known on their >>> first use. >>> >>> >>>> - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so >>>> called because/ >>> >>> >>> KT> Fixed >>> >>> >>>> - Sec. 2: s/Definition(s) (FAD) advertised by a node >>>> is/Definition(s) (FAD) advertised by a node is (are)/ >>>> Reason: symmetry in the sentence construction >>>> >>> >>> KT> Fixed >>> >>> >>>> - Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes? >>>> >>> >>> KT> Fixed. >>> >>> Thanks, >>> Ketan >>> >>> >>>> >>>> Thanks. >>>> >>>> >>>> >>>>
- [Gen-art] Genart last call review of draft-ietf-i… Vijay Gurbani via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] [Last-Call] Genart last call review… Lars Eggert