[Gen-art] Genart last call review of draft-ietf-spring-sr-replication-segment-14

Thomas Fossati via Datatracker <noreply@ietf.org> Fri, 09 June 2023 16:01 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CA2D5C1526E9; Fri, 9 Jun 2023 09:01:48 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Thomas Fossati via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-spring-sr-replication-segment.all@ietf.org, last-call@ietf.org, spring@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.0.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168632650880.62569.14866459241619472156@ietfa.amsl.com>
Reply-To: Thomas Fossati <thomas.fossati@arm.com>
Date: Fri, 09 Jun 2023 09:01:48 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/WF6_i6kgEP9J8_frlekZtnm_6sQ>
Subject: [Gen-art] Genart last call review of draft-ietf-spring-sr-replication-segment-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2023 16:01:48 -0000

Reviewer: Thomas Fossati
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-spring-sr-replication-segment-14
Reviewer: Thomas Fossati
Review Date: 2023-06-09
IETF LC End Date: 2023-06-19
IESG Telechat date: Not scheduled for a telechat

Summary:

The premise is I am not a routing expert and I only had a high level
understanding of segment routing before reading this document.  That
said, I have very much enjoyed the clarity and precision of the material
presented and I think the authors have done a really good job, thank
you!  (BTW, I have found the terminology section especially useful to
navigate the rest of the draft.)

The instructions to IANA are concise and clear.

>From a Gen-ART perspective I reckon the document is ready.

Major issues: None

Minor issues: None

Nits/editorial comments:

* §1.1, 3rd bullet: s/period/period./
* §2.1, 4th para: s/may be leaf node/may be the leaf node/
* §2.2, 3rd para: s/Again note/Again, note/
* §2.2, 4th para: s/this document/this document./
* §2.2, 5th para: s/may be leaf node/may be the leaf node/
* §2.2.1, 2nd para: s/contains following/contains the following/
* §2.2.1, Replication State info model: s/maybe be empty/may be empty/
* §2.2.1: s/in a SRH. As per psuedo-code/in an SRH. As per pseudo-code/
* §2.2.2: s/apriori/a priori/
* §2.2.3: s/this same restrictions/this same restriction/
* §4: s/catalog/catalogue/