Re: [Gen-art] Genart last call review of draft-ietf-isis-segment-routing-extensions-23

Alissa Cooper <alissa@cooperw.in> Mon, 13 May 2019 18:30 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7B4C1201BB; Mon, 13 May 2019 11:30:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 2.299
X-Spam-Level: **
X-Spam-Status: No, score=2.299 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=h39cICtm; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=pRUM+QeD
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SykoxpQd1WoZ; Mon, 13 May 2019 11:30:10 -0700 (PDT)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 946FD1200F6; Mon, 13 May 2019 11:30:10 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 4F51855C; Mon, 13 May 2019 14:30:09 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 13 May 2019 14:30:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=C wK+SpatJOrWORZsA/btKJsU6cvafglLseKoTAUHRN8=; b=h39cICtm4N3UOKRmh CHHG0gq5lUGm9tRYg2hhcxXantaPpRDl07x4rQba72v8apVCg7dk2yLOvapYIsFL pLRAAakjA9VS//FYOZ/Qn+4ii5rvnqaako3NZlpCaHXdMHJytUhylT2n1DkexZvx M1C7TFViDUDC/IxQv7rzlZgvbFVF6TPrxzEYUMCNQEJRySlUOUrP7GV2HgfETrkQ 5sVFtubdkSC0mIgP4aCQBmpZH9rBVypym1eq18kqEt8D4rb8cUkC/duG34LvlBmK acSiJUNwPt0NlceyC40X/2IpxP8Z6F/39LqWcSGgtwfd5Lkfx2Cpixj1Z3FHVWel h9/KA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CwK+SpatJOrWORZsA/btKJsU6cvafglLseKoTAUHR N8=; b=pRUM+QeDlQxfNUe55t+0jYsPmKK9gN8YEDScAiSjgw+NlnZPGED6DrQ8B iCXV3Nwm+4o81MLGuyc5jB5cn+aJerQn6q40KGFLa11MckWaWhWtY5jAT5Fwx/4T 7ym8JBke9ftyjoOqgt3L8Esp8BUye572j5PvJZdg6gLr0jZM/svKo/s1ry1cvH+B +LMxIHnahlFWJuXF5+nERi38OEq/iR7SbFedwpdouOMN6xRl4r2NegrdaOjozISR /VyCaQ+XPXF0Z8NyIB4EXRvBA1rsvZ35UPfqlEH6qECEAZn2kB2BWBAQ11Msl7vZ LqQmqEvwKHgopBVwlbfbBcgW9Aocg==
X-ME-Sender: <xms:sLfZXJ5WIEJPbwfnqlnRIMVisDsHSZFhh3aAMTbWlZezB23nZ269NA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtvdenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrkeejnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsth gvrhfuihiivgeptd
X-ME-Proxy: <xmx:sLfZXOoXEe65ghVjfK0ASPb_DWcPX0rTtU6n6R2f9mgNplmVM_qQ4Q> <xmx:sLfZXFfajgfpg8xhH6bfCDS818g-M1CzsfXISVPePZZjd6ZLuQMLbg> <xmx:sLfZXKLbBUwG9n6VoDzdVoyqB57yWEVZGsJJ1vRyJow39UOVSg3uyQ> <xmx:sLfZXDlp5tZc8ll90C5TSh9CdOHfTY3PGju4-i6T_TbAmIXog-uWTw>
Received: from rtp-alcoop-nitro5.cisco.com (unknown [173.38.117.87]) by mail.messagingengine.com (Postfix) with ESMTPA id D8F468005A; Mon, 13 May 2019 14:30:07 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <BYAPR11MB36389502EAFF03793EC45635C1260@BYAPR11MB3638.namprd11.prod.outlook.com>
Date: Mon, 13 May 2019 14:30:06 -0400
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-isis-segment-routing-extensions.all@ietf.org" <draft-ietf-isis-segment-routing-extensions.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2AC61736-3BD7-46C7-B2A5-F6AD0D277ECE@cooperw.in>
References: <155555401259.21196.3824352311000750590@ietfa.amsl.com> <BYAPR11MB36389502EAFF03793EC45635C1260@BYAPR11MB3638.namprd11.prod.outlook.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, Erik Kline <ek@google.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/WU9J_kjuJH0Q8tiVa0VPgDCn-dc>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-isis-segment-routing-extensions-23
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 May 2019 18:30:13 -0000

Erik, thanks for your review. Les, thanks for the updates. I entered a No Objection ballot.

Alissa

> On Apr 18, 2019, at 12:26 AM, Les Ginsberg (ginsberg) <ginsberg@cisco.com>; wrote:
> 
> Erik -
> 
> Thanx for the detailed review.
> I have published V24 of the draft which addresses all of your comments (and a few pending AD review comments from Alvaro).
> Some exceptions noted below.
> 
>> -----Original Message-----
>> From: Erik Kline via Datatracker <noreply@ietf.org>;
>> Sent: Wednesday, April 17, 2019 7:20 PM
>> To: gen-art@ietf.org
>> Cc: lsr@ietf.org; ietf@ietf.org; draft-ietf-isis-segment-routing-
>> extensions.all@ietf.org
>> Subject: Genart last call review of draft-ietf-isis-segment-routing-extensions-
>> 23
>> 
>> Reviewer: Erik Kline
>> Review result: Ready with Nits
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
>> 
>> Document: draft-ietf-isis-segment-routing-extensions-??
>> Reviewer: Erik Kline
>> Review Date: 2019-04-17
>> IETF LC End Date: 2019-04-17
>> IESG Telechat date: Not scheduled for a telechat
>> 
>> Summary:
>> 
>> For what little I know of IS-IS and segment routing, this all seems to make
>> general sense.  I simply had some language/style nits (below).
>> 
>> Major issues:
>> 
>> Minor issues:
>> 
>> Nits/editorial comments:
>> 
>> # Section 1
>> 
>> * "SR's control-plane can be applied ..., and do not require...".  It looks
>> like the subject of the sentence is "control-plane" and so perhaps "do not"
>> should be "does not".
>> 
>> * s/draft/document/g
>> 
>> # Section 2.1
>> 
>> * "Algorithms identifiers" -> "Algorithm identifiers"
>> 
>> # Section 2.2.2
>> 
>> * Length: variable
>> 
>> Should this say "11-12" (1 + 1 + 6 + 3-4)?
>> 
> [Les:] No. System ID may be a value from 1-8 octets in length (though in practice only the value 6 is used). I have clarified the text to mention that this field is of "ID Length" (as per ISO 10589).
> 
>> * "set of Adj-SID each router" -> "set of Adj-SIDs each router", perhaps.
>> 
>> # Section 2.3
>> 
>> s/valu eis/value is/
>> 
>> # Section 2.4
>> 
>> Silly, naive question: does the length include the sum of the octets
>> representing the sub-TLVs?
>> 
> [Les:] Yes. TLV length includes all of the data contained in the TLV - including sub-TLVs.
> 
>    Les
> 
>> # Section 2.4.6
>> 
>> In example 3, I would recommend s/0xD/0x0D/ & s/0x0/0x00/ & s/0x1/0x01/
>> ,
>> but perhaps that's just a personal readability thing.
>> 
>> # Section 3.3
>> 
>> * "by other components than" -> "by components other than", perhaps.
>> 
>> * "to know what are the local SIDs" -> "to know what the local SIDs are",
>>  perhaps.
>> 
>> * "The SRLB sub-TLV is used for this purpose...", (instead of "that purpose")
>> maybe.
>> 
>> * "which mechanisms are outside" -> "which are outside", maybe.
>> 
>> * "the SRLB TLV" -> "the SRLB sub-TLV", I think.
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art