Re: [Gen-art] Genart telechat review of draft-ietf-netmod-yang-data-ext-04

Alissa Cooper <alissa@cooperw.in> Wed, 04 December 2019 16:41 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 33A90120043; Wed, 4 Dec 2019 08:41:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.772
X-Spam-Level:
X-Spam-Status: No, score=-2.772 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.073, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=Gy+XimDb; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=wanknSzs
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eX5uX4GYNQNO; Wed, 4 Dec 2019 08:41:56 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7FA6712080B; Wed, 4 Dec 2019 08:41:56 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8DDA522629; Wed, 4 Dec 2019 11:41:55 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 04 Dec 2019 11:41:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm1; bh=M7HvX9/JwB6+SGc41Ue6zol 8UdsbRRVSkRNjD5Ic2pQ=; b=Gy+XimDbMCgzWC+RV9yHR3SAtgzv9wk2d08Rrom vADZKYzSz2fRt3x7kpqvmTMNzYvNYu115Ve/tOvDKPVvE5y50gSbMIiqwKMpYGLN MD1+Kk1Z9aSi4TnIq7yrJjzJNQA4qit8tCilYimLLwhRAkCuMza2aniIMLQjwNKj 1/b1qNT0skCjBJoDyOxusztp7Wqa60zjgGW+c+yFlsixDckfh3JCd15vRWonBlMb BUW1zctCzx9ne2Xr13+RmRutq0MijwkyOxL7ys8DDi/VX37zgQZ9jUorSkTRQX4F 2NNxHhesXEc+ZJ2CB4aMflpKMErnp458aDgji/KIoxQWItA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=M7HvX9 /JwB6+SGc41Ue6zol8UdsbRRVSkRNjD5Ic2pQ=; b=wanknSzsFBMtopMIyMBhkZ vB8FzbBGNu15r/gwhpQhuf4wKtShZCCu9/1S/Xr2ZaZlyKxUeowlbZSpOgIA6nZZ +dq/PbGYrLJrALuZdJCOO27lIJLaYnNsxKsmllecXXNq8jfhZgIHHMZKoE7rZ/R6 ofbXSdXFfVXu4M53P/171QCIc6YcDY8nRzh8rMdFryrBu1GtIdGC/vo8Wt6U9YL8 oW2gDnQ78sjlOIvpgC8qcijyr8p7b8g+w8nX/CcdMIy5SBPnGApKnr68Kn+s3aFN uCrLruSNpXeJ7KcVzfVRG2wqJUxTVS20F0EgJxujf0MwMscNxR1drlC6W0VLDUWg ==
X-ME-Sender: <xms:0-HnXWP0nDaVyzPVcPnho2be_B7GujfHAGHSUTRRZBKv_VuJBLkRxw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudejledgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtddvnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomhgrih hnpehivghtfhdrohhrghenucfkphepuddtkedrhedurddutddurdelkeenucfrrghrrghm pehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhushhtvg hrufhiiigvpedt
X-ME-Proxy: <xmx:0-HnXZP1zQqAvbILJiuVObO2zjhUVDkndU9ZCIGhUzwSJpPJs35tWg> <xmx:0-HnXYSOgkPR0VrpDznQXosQvjM4PVnj11ZqvCKk8W8b-hGfsf6Kpg> <xmx:0-HnXbBPUPPR-TzK9UVp-bSI3WB8BNad22e_KM9DMsJbRhTm09Fd-Q> <xmx:0-HnXSfrU6NjAKrmVMFbqRtT69XeWf8BUh9GXDOKyztVFZ28BxYz4Q>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id CCF1B30600EA; Wed, 4 Dec 2019 11:41:54 -0500 (EST)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <CF463C26-9EE2-41FA-A8A1-DAF861EB2A9A@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_DAA91EEB-DF40-4B0A-BF9C-9A5B30ED101C"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 4 Dec 2019 11:41:53 -0500
In-Reply-To: <20191021.093756.152320320751835478.mbj@tail-f.com>
Cc: Peter Yee via Datatracker <noreply@ietf.org>, General Area Review Team <gen-art@ietf.org>, draft-ietf-netmod-yang-data-ext.all@ietf.org, NetMod WG <netmod@ietf.org>
To: Martin Bjorklund <mbj@tail-f.com>, Brian E Carpenter <brian.e.carpenter@gmail.com>
References: <157152508672.5327.14252287111930747824@ietfa.amsl.com> <20191021.093756.152320320751835478.mbj@tail-f.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/WbkxFIwO8RMO5pu9-nruJZ2QdsU>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-netmod-yang-data-ext-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2019 16:41:58 -0000

Brian, thanks for your review. Martin, thanks for your response. I entered a No Objection ballot.

Alissa

> On Oct 21, 2019, at 3:37 AM, Martin Bjorklund <mbj@tail-f.com>; wrote:
> 
> Hi,
> 
> Brian Carpenter via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
>> Reviewer: Brian Carpenter
>> Review result: Ready with Nits
>> 
>> Gen-ART Last Call & telechat review of draft-ietf-netmod-yang-data-ext-04
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair. Please wait for direction from your
>> document shepherd or AD before posting a new version of the draft.
>> 
>> For more information, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>;.
>> 
>> Document: draft-ietf-netmod-yang-data-ext-04.txt
>> Reviewer: Brian Carpenter
>> Review Date: 2019-10-20
>> IETF LC End Date: TBD
>> IESG Telechat date: 2019-10-31
>> 
>> Summary: Ready with nits
>> --------
>> 
>> Comments: 
>> ---------
>> 
>> This was accidentally put on the IESG agenda without an IETF Last Call,
>> so this review serves both purposes.
>> 
>> The draft seems very clear and I have no technical comments.
>> 
>> Nits:
>> -----
>> 
>>> Updates: 8340 (if approved)
>>> Intended status: Standards Track
>> 
>> RFC 8340 is a BCP, so can this really be Standards Track?
>> Shouldn't it also be BCP, extending BCP 215? It's tricky,
>> because it also effectively extends RFC 8040, which is
>> Standards Track rather than BCP. Sadly it doesn't seem that
>> a document can be both BCP and Standards Track.
> 
> Hmm, the main contribution in this document (the "structure"
> extension), is not suitable as a BCP.  It is really just section 3
> that updates 8340.  I don't know to to resolve this, and will look at
> the document shepard for guidance!
> 
>> Also, this draft says:
>> 
>>>  The "yang-data" extension from [RFC8040] has been copied here,
>>>  renamed to "structure", and updated to be more flexible.
>> 
>> That reads as if RFC 8040 is also updated, and it leaves the
>> status of "yang-data" unclear. Is it now deprecated? Perhaps the
>> sentence would be clearer like this:
>> 
>>  This document defines a new YANG extension statement called
>>  "structure", which is similar to but more flexible than the
>>  "yang-data" extension from [RFC8040].
> 
> 
> Thank you, this is better!
> 
> 
> /martin
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>