Re: [Gen-art] Pre-telechat review of draft-ietf-manet-tlv-naming-02

Jari Arkko <jari.arkko@piuha.net> Wed, 13 May 2015 22:15 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CD491B2DA0; Wed, 13 May 2015 15:15:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vSOw-wDQXXfd; Wed, 13 May 2015 15:15:43 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 737C21B3163; Wed, 13 May 2015 15:15:42 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id C31782CC6F; Thu, 14 May 2015 01:15:41 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wc9jrtHNnWLZ; Thu, 14 May 2015 01:15:40 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 3C4062CC5A; Thu, 14 May 2015 01:15:40 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Content-Type: multipart/signed; boundary="Apple-Mail=_D1805120-C334-455A-9694-08675521C6F9"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <B31EEDDDB8ED7E4A93FDF12A4EECD30D40EEA98F@GLKXM0002V.GREENLNK.net>
Date: Thu, 14 May 2015 00:15:40 +0200
Message-Id: <DC80BD35-77B2-4920-AD17-9141C16A8DD7@piuha.net>
References: <554FDD8D.9090508@gmail.com> <B31EEDDDB8ED7E4A93FDF12A4EECD30D40EEA98F@GLKXM0002V.GREENLNK.net>
To: "Dearlove, Christopher (UK)" <chris.dearlove@baesystems.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/Wg39WRVxNbWeh2ass0ed-mhuXgA>
Cc: "T. Clausen" <T.Clausen@computer.org>, "manet-chairs@ietf.org" <manet-chairs@ietf.org>, Gen Art <gen-art@ietf.org>, Alvaro Retana <aretana@cisco.com>, Justin Dean <jdean@itd.nrl.navy.mil>
Subject: Re: [Gen-art] Pre-telechat review of draft-ietf-manet-tlv-naming-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 22:15:46 -0000

Thanks for your review, Tom. New version looks ok to me, do you agree Tom? And thank you Christopher for the changes!

Jari

On 13 May 2015, at 17:51, Dearlove, Christopher (UK) <chris.dearlove@baesystems.com> wrote:

> Tom
> 
> Thanks for those detailed and useful comments. The soon to be submitted next draft will address all of them.
> 
> Christopher
> 
> -- 
> Christopher Dearlove
> Senior Principal Engineer
> BAE Systems Applied Intelligence
> __________________________________________________________________________
> 
> T:  +44 (0)1245 242194  |  E: chris.dearlove@baesystems.com
> 
> BAE Systems Applied Intelligence, Chelmsford Technology Park, Great Baddow, Chelmsford, Essex CM2 8HN.
> www.baesystems.com/ai
> BAE Systems Applied Intelligence Limited
> Registered in England & Wales No: 01337451
> Registered Office: Surrey Research Park, Guildford, Surrey, GU2 7YP
> 
> 
> 
> -----Original Message-----
> From: Tom Taylor [mailto:tom.taylor.stds@gmail.com] 
> Sent: 10 May 2015 23:37
> To: Gen Art; Dearlove, Christopher (UK); T. Clausen; Justin Dean; Alvaro Retana; manet-chairs@ietf.org
> Subject: Pre-telechat review of draft-ietf-manet-tlv-naming-02
> 
> ----------------------! WARNING ! ---------------------- This message originates from outside our organisation, either from an external partner or from the internet.
> Consider carefully whether you should click on any links, open any attachments or reply.
> Follow the 'Report Suspicious Emails' link on IT matters for instructions on reporting suspicious email messages.
> --------------------------------------------------------
> 
> This was supposed to be done by May 1, but got buried in my Inbox. My apologies.
> 
> I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please resolve these comments along with any other Last Call comments you may receive.
> 
> Document: draft-ietf-manet-tlv-naming-02
> Reviewer: Tom Taylor
> Review Date:        10 May 2015
> IETF LC End Date:    1 May 2015
> IESG Telechat date: 14 May 2015
> 
> Summary: This document has minor issues that need to be resolved, along with a few nits.
> 
> Major issues:
> 
> Minor issues:
> 
> 1. If the requested TLV Type does not immediately define all the corresponding type extensions for versions of that type, the Expert Reviewer or IANA will be faced with the task of choosing an appropriate Type value within which to place the extension. No guidance has been provided for this purpose. What is the intention?
> 
> 2. No IANA Considerations have been provided for the following registries:
>     TC Message-Type-specific Message TLV Types
>     TC Message-Type-specific Address Block TLV Types
>     HELLO Message-Type-specific Message TLV Types
>     HELLO Message-Type-specific Address Block TLV Types
>     SMF_TYPE Message TLV Type Extensions
>     SMF_NBR_TYPE Address Block TLV Type Extensions
> 
> 
> 
> Nits/editorial comments:
> 
> Sec. 1, third from last paragraph: s/consisteng/consistent/
> 
> Sec. 3.1, s/reguested/requested/ (both outer bullets, first line of each)
> 
> IANA Considerations, following Table 11: the current registry name is "ICV[TIMESTAMP] Address TLV Type Extensions" (missing the word "Block"). 
> This is inconsistent with the other address block TLV types. I suggest, in place of the current text for these two extension registries, text to resolve the inconsistency, as follows:
> 
> OLD
> 
>    The IANA Registry "ICV[TIMESTAMP] Address Block TLV Type Extensions"
>    is unchanged.
> 
> NEW
> 
>    The IANA Registry "ICV[TIMESTAMP] Address TLV Type Extensions" is
>    unchanged except to add the word "Block" after "Address" in the
>    registry name.
> 
> IANA Considerations, Table 13 and preceding text: the current registry name is "NBR_ADDR_TYPE ....". This document refers to it as "NBR_ADDR_TYPES ...." (i.e., plural). The inconsistency needs to be resolved.
> ********************************************************************
> This email and any attachments are confidential to the intended
> recipient and may also be privileged. If you are not the intended
> recipient please delete it from your system and notify the sender.
> You should not copy it or use it for any purpose nor disclose or
> distribute its contents to any other person.
> ********************************************************************
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art