[Gen-art] Genart last call review of draft-ietf-dots-data-channel-27

Datatracker on behalf of Roni Even <noreply@ietf.org> Thu, 07 March 2019 10:21 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C71741313B1; Thu, 7 Mar 2019 02:21:03 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Datatracker on behalf of Roni Even <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-dots-data-channel.all@ietf.org, ietf@ietf.org, dots@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.93.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <155195406376.15866.11400149967812730230@ietfa.amsl.com>
Date: Thu, 07 Mar 2019 02:21:03 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/WlQ1GvO8r_Z3AZj-rCRlrvqRs9E>
Subject: [Gen-art] Genart last call review of draft-ietf-dots-data-channel-27
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 10:21:04 -0000

Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-dots-data-channel-??
Reviewer: Roni Even
Review Date: 2019-03-07
IETF LC End Date: 2019-03-13
IESG Telechat date: Not scheduled for a telechat

Summary:
The document is ready with nits and one minor issue for publication as a
standard track RFC

Major issues:

Minor issues:

1. In section 2 there is a discussion about conflicting filtering requests. I
think that this can be considered as an attack and should be mentioned in the
security section. I also think that such a conflict must be reported to the
administrator even if rejected.

Nits/editorial comments:

1. In figure 2 missing HTTP layer?
2. In section 6.1 "If the request is missing a mandatory attribute or its
contains " should be "it" instead of "its" 3. In section 7.3 "A DOTS client
periodically queries  ...".  I did not see any text about why this is done is
this a common behavior? how often? 4. After figure 29 "bound to a given ACL as
shown in Figure 28 " I think it should be 27? 5. In figure 31
""pending-lifetime": 8000 ," why 8000 and not 9080 as in figure 28?