Re: [Gen-art] Gen-ART Telechat Call review of draft-ietf-bier-isis-extensions-06

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Tue, 13 February 2018 05:00 UTC

From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Meral Shirazipour <meral.shirazipour@ericsson.com>, "draft-ietf-bier-isis-extensions.all@ietf.org" <draft-ietf-bier-isis-extensions.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART Telechat Call review of draft-ietf-bier-isis-extensions-06
Thread-Index: AdOkfwzmFwzqGpsEReuTjp0Q9xz9cAABy1rQ
Date: Tue, 13 Feb 2018 05:00:39 +0000
Message-ID: <1803b641aa594dad8cd94faeb6d84eac@XCH-ALN-001.cisco.com>
References: <ABCAA4EF18F17B4FB619EA93DEF7939A4F69DB65@eusaamb107.ericsson.se>
In-Reply-To: <ABCAA4EF18F17B4FB619EA93DEF7939A4F69DB65@eusaamb107.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative; boundary="_000_1803b641aa594dad8cd94faeb6d84eacXCHALN001ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/X8ZF3RsQoIUPSdXUpDHqVptpbQk>
Subject: Re: [Gen-art] Gen-ART Telechat Call review of draft-ietf-bier-isis-extensions-06
Precedence: list

Meral -

Thanx for the review.
Some of your comments have already been addressed in the latest version (07) published a few days ago.

Responses inline.

From: Meral Shirazipour [mailto:meral.shirazipour@ericsson.com]
Sent: Monday, February 12, 2018 8:02 PM
To: draft-ietf-bier-isis-extensions.all@ietf.org; gen-art@ietf.org
Subject: Gen-ART Telechat Call review of draft-ietf-bier-isis-extensions-06

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-bier-isis-extensions-06
Reviewer: Meral Shirazipour
Review Date: 2018-02-12
IETF LC End Date: 2018-02-22 ?
IESG Telechat date: 2018-02-22

Summary: This draft is ready to be published as Standards Track RFC but I have some comments.

Major issues:
Minor issues:
Nits/editorial comments:
-please updated references to latest draft version/RFC number

[Les:] Done in V 07

-Section 2 would be clearer is the definitions introduced only in this document are identified as such

[Les:]  I don't think there are any introduced by this document. All of the definitions mentioned in Section 2 come from RFC 8279.

-Please spell out  multi topology, sub-domain at  first use for MT SD
[Les:] In Section 4.1 where we introduce the use of <MT,SD> here is what the text says (emphasis added):

"Within such a domain, the extensions defined in this document
   advertise BIER information for one or more BIER sub-domains.  Each
   sub-domain is uniquely identified by a subdomain-id.  Each subdomain
   is associated with a single ISIS topology [RFC5120], which may be any
   of the topologies supported by ISIS.  Local configuration controls
   which <MT,SD> pairs are supported by a router."

Do you think further clarification as to the meaning of <MT,SD> is still needed??

-[Page 6], "advertisments."--->"advertisements"

[Les:] Corrected in V 07.

-[Page 8], "occurences"--->"occurrences"

[Les:] The section which contains this misspelling was removed in V 07.

   Les

Best Regards,
Meral
---
Meral Shirazipour
Ericsson Research
www.ericsson.com<http://www.ericsson.com>

[Gen-art] Gen-ART Telechat Call review of draft-i… Meral Shirazipour
Re: [Gen-art] Gen-ART Telechat Call review of dra… Les Ginsberg (ginsberg)
Re: [Gen-art] Gen-ART Telechat Call review of dra… Meral Shirazipour
Re: [Gen-art] Gen-ART Telechat Call review of dra… Alissa Cooper