[Gen-art] Gen-ART Last Call review of draft-ietf-dnsop-edns-tcp-keepalive-04

Brian E Carpenter <brian.e.carpenter@gmail.com> Mon, 23 November 2015 01:58 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6FAD31B2D24; Sun, 22 Nov 2015 17:58:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35_5n84t3eBL; Sun, 22 Nov 2015 17:58:16 -0800 (PST)
Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F3EA81B2D1D; Sun, 22 Nov 2015 17:58:12 -0800 (PST)
Received: by pacej9 with SMTP id ej9so175019308pac.2; Sun, 22 Nov 2015 17:58:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=nZQpZCmyid9rZIxz8DegQxwiLz3Gk/laC6YaaFmOOJo=; b=Hl+D0Bm3Y7CLS0yae7myGUSxuDg+s25D+5ZSNirxmxiuQdvMkfC7dDYMbTnRsihQYh 6RMAFVdtRJYVyEXc96MucrkRpZodUAj6RRApHInvkZ5cCnzoOyJiknsdA8mhkqmR1Wei iNxT9tl2bXE4bnRD9q5XWMNN7hXZaPu0PsXH/FzXdt5/LuzZea/dag0srm/qNVFMUC22 +wITw760L15VQe7stFw9aaL6kEdUlQceMWsziAsaWmKhUTNrZD8/m77uuthnuUfTj0Ol hA0NLe37PImJAEYDPWK61alsd3zvTLujN6yw19rj1AIn5nAcXtZFDLfHn1nD/iDCNKPp 5Lnw==
X-Received: by 10.66.122.67 with SMTP id lq3mr33030452pab.21.1448243892662; Sun, 22 Nov 2015 17:58:12 -0800 (PST)
Received: from [192.168.178.25] (100.226.69.111.dynamic.snap.net.nz. [111.69.226.100]) by smtp.gmail.com with ESMTPSA id ws6sm7993139pbc.33.2015.11.22.17.58.09 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 22 Nov 2015 17:58:11 -0800 (PST)
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
To: draft-ietf-dnsop-edns-tcp-keepalive.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Organization: University of Auckland
Message-ID: <565272B0.8080905@gmail.com>
Date: Mon, 23 Nov 2015 14:58:08 +1300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/XchCd5FoPWXQe44AeDpffaq1qNU>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-dnsop-edns-tcp-keepalive-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2015 01:58:18 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-dnsop-edns-tcp-keepalive-04.txt
Reviewer: Brian Carpenter
Review Date: 2015-11-23
IETF LC End Date: 2015-11-30
IESG Telechat date:

Summary: Ready with issues
--------

Comment: These are only standards-language issues, nothing fundamental.
--------

Major Issues:
-------------

Last paragraph of section 3.2.2.  Receiving Responses:

   A DNS client that sent a query containing the edns-keepalive-option
   but receives a response that does not contain the edns-keepalive-
   option should assume the server does not support keepalive and behave
   following the guidance in [DRAFT-5966bis].  This holds true even if a
   previous edns-keepalive-option exchange occurred on the existing TCP
   connection.

Firstly, shouldn't that "should" be a SHOULD?

More important, [DRAFT-5966bis] really looks like a normative reference to me.
I couldn't code this without reading that reference. It's already entering
Last Call so hopefully this won't waste much time.

Section 3.6.  Anycast Considerations:

   ...
   Changes in network topology between clients and anycast servers may
   cause disruption to TCP sessions making use of edns-tcp-keepalive
   more often than with TCP sessions that omit it, since the TCP
   sessions are expected to be longer-lived.  Anycast servers MAY make
   use of TCP multipath [RFC6824] to anchor the server side of the TCP
   connection to an unambiguously-unicast address in order to avoid
   disruption due to topology changes.

IMHO, [RFC6824] is another normative reference; and it's a downref since
it's an Experimental RFC. I think you could avoid this by weakening
the last sentence a bit:

   It might be possible for anycast servers to avoid disruption due to
   topology changes by making use of TCP multipath [RFC6824] to anchor
   the server side of the TCP connection to an unambiguously unicast address.