[Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09

Vijay Gurbani via Datatracker <noreply@ietf.org> Fri, 12 August 2022 19:50 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 54E07C157B52; Fri, 12 Aug 2022 12:50:53 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Vijay Gurbani via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.13.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166033385333.7724.14555622442470360665@ietfa.amsl.com>
Reply-To: Vijay Gurbani <vijay.gurbani@gmail.com>
Date: Fri, 12 Aug 2022 12:50:53 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/XdX6DQcSJviepiZBVDd2WehpoW8>
Subject: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Aug 2022 19:50:53 -0000

Reviewer: Vijay Gurbani
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-idr-bgp-ls-flex-algo-??
Reviewer: Vijay K. Gurbani
Review Date: 2022-08-12
IETF LC End Date: 2022-08-17
IESG Telechat date: Not scheduled for a telechat

Summary: Draft is ready with nits for a Proposed Standard.

Major issues: 0

Minor issues: 1 (please see below)

Nits/editorial comments: 4 (please see below)

Minor:
- Sec. 3.6: Note that Type is "TBD" here.  Should this be 1046, as shown in
 Table 1?  (Or is the use of 1046 still under discussion?)

Nits:
- I note that certain acronyms --- IGP, NLRI, ASLA --- are not defined.  I
suspect that these are well-known in the community, hence need no definition. 
Just in case they are not, you may consider expanding the rare ones on first
use. - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so
called because/ - Sec. 2: s/Definition(s) (FAD) advertised by a node
is/Definition(s) (FAD) advertised by a node is (are)/
  Reason: symmetry in the sentence construction
- Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes?

Thanks.