[Gen-art] Genart last call review of draft-ietf-sipcore-originating-cdiv-parameter-05
Vijay Gurbani <vijay.gurbani@gmail.com> Mon, 29 October 2018 20:50 UTC
Return-Path: <vijay.gurbani@gmail.com>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id AD7BE13108C; Mon, 29 Oct 2018 13:50:12 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Vijay Gurbani <vijay.gurbani@gmail.com>
To: gen-art@ietf.org
Cc: sipcore@ietf.org, ietf@ietf.org, draft-ietf-sipcore-originating-cdiv-parameter.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.87.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154084621265.4963.11856647404649644525@ietfa.amsl.com>
Date: Mon, 29 Oct 2018 13:50:12 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/XjQL71ermyaXzgyNo2VtO_lnxno>
Subject: [Gen-art] Genart last call review of draft-ietf-sipcore-originating-cdiv-parameter-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Oct 2018 20:50:13 -0000
Reviewer: Vijay Gurbani Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-sipcore-originating-cdiv-parameter-?? Reviewer: Vijay K. Gurbani Review Date: 2018-10-29 IETF LC End Date: 2018-10-26 IESG Telechat date: Not scheduled for a telechat Summary: This draft is on the right track but has open issues, described in the review. Major issues: 0 Minor issues: 1 Nits/editorial comments: 1 Minor: - S1.3: I am not sure I follow the logic in the problem statement. Who is the "diverting" user? The user to who the call was destined? If so, best to say that explicitly. (To be sure, I looked into rfc5502 as well, and it does not define "diverting" user either.) A bit below (in S4), you use the term "served" user to refer to the diverting user. All in all, the terminology here could be refined. I suspect that the "originating" user is the callee. Concretely, I think that the first paragraph of S1.3 should be re-written, perhaps with a figure (?) to explain the call flow, or at least some context using Alice, Bob and Carol as the example in S7.1 does (I suspect that Carol is the "diverting" user here). Nits, typos: - S4, step 3: s/user an INVITE that/user as an INVITE that/ Also, the "secase" and "regstate" parameters are what you are standardizing this I-D, as such you mention this before S4 so the reader knows that these are the new parameters. Same for "orig-cdiv" parameter.
- [Gen-art] Genart last call review of draft-ietf-s… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… marianne.mohali
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… marianne.mohali
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… marianne.mohali
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… Ben Campbell
- Re: [Gen-art] Genart last call review of draft-ie… marianne.mohali
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper