Re: [Gen-art] Genart last call review of draft-ietf-lpwan-schc-yang-data-model-14

Laurent Toutain <laurent.toutain@imt-atlantique.fr> Mon, 01 August 2022 17:22 UTC

Return-Path: <laurent.toutain@imt-atlantique.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93ED6C14F72B; Mon, 1 Aug 2022 10:22:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=imt-atlantique.fr
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MdOrOsQUUr3K; Mon, 1 Aug 2022 10:22:53 -0700 (PDT)
Received: from zproxy110.enst.fr (zproxy110.enst.fr [IPv6:2001:660:330f:2::c0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99C7EC14F72D; Mon, 1 Aug 2022 10:22:52 -0700 (PDT)
Received: from localhost (localhost [IPv6:::1]) by zproxy110.enst.fr (Postfix) with ESMTP id C1361813EF; Mon, 1 Aug 2022 19:22:50 +0200 (CEST)
Received: from zproxy110.enst.fr ([IPv6:::1]) by localhost (zproxy110.enst.fr [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id BoxmmufW9CdO; Mon, 1 Aug 2022 19:22:48 +0200 (CEST)
Received: from localhost (localhost [IPv6:::1]) by zproxy110.enst.fr (Postfix) with ESMTP id 8A60581796; Mon, 1 Aug 2022 19:22:48 +0200 (CEST)
DKIM-Filter: OpenDKIM Filter v2.10.3 zproxy110.enst.fr 8A60581796
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imt-atlantique.fr; s=50EA75E8-DE22-11E6-A6DE-0662BA474D24; t=1659374568; bh=pj3uhgYLiEo1L6ONVmFVWtDr7/MD71Iy9E6lGT1IcCk=; h=MIME-Version:From:Date:Message-ID:To; b=mvwT799k5OFrEJYW+frFDz7LlS8D+da8M2BYSWE/B6bcusz+UiOESyuLvqsaSiWyv aMayyyVF3zpiVnfQSdzYtoHbMLdeOf9fEYdVjeiYEq1joyLU7/3EBAqmeybeyEbe4J 9XkAG+CbpgJkGQexYti9yht6KzkisLqCghSX+YSU=
X-Virus-Scanned: amavisd-new at zproxy110.enst.fr
Received: from zproxy110.enst.fr ([IPv6:::1]) by localhost (zproxy110.enst.fr [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id I2KolsM5BVlD; Mon, 1 Aug 2022 19:22:48 +0200 (CEST)
Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by zproxy110.enst.fr (Postfix) with ESMTPSA id 5BAF9813EF; Mon, 1 Aug 2022 19:22:48 +0200 (CEST)
Received: by mail-ot1-f44.google.com with SMTP id g8-20020a9d6b08000000b0061d0ac9ebb2so8661736otp.10; Mon, 01 Aug 2022 10:22:48 -0700 (PDT)
X-Gm-Message-State: AJIora+Gq9nrfxpR+XtLNg39DZrj0pnaz388vg5F7SXDcmxL2yXNS4yw bKt19BdpardLE8714yozosAKuvQYeeigsO5zkMU=
X-Google-Smtp-Source: AGRyM1tbw9YXPN22WOd1gVxevawfV2FcDe70Y78GKSHAAonRRc722n8l4BG80jiDb/J3iet9mo/FoW4umxODZy3XatM=
X-Received: by 2002:a9d:19cd:0:b0:61d:3117:579 with SMTP id k71-20020a9d19cd000000b0061d31170579mr6189295otk.232.1659374566819; Mon, 01 Aug 2022 10:22:46 -0700 (PDT)
MIME-Version: 1.0
References: <165895925536.50632.6409191646047601343@ietfa.amsl.com>
In-Reply-To: <165895925536.50632.6409191646047601343@ietfa.amsl.com>
From: Laurent Toutain <laurent.toutain@imt-atlantique.fr>
Date: Mon, 01 Aug 2022 19:22:10 +0200
X-Gmail-Original-Message-ID: <CABONVQaXONZQ2pKU8DqYC3Qx-y+ftOqVdnaJh-GwxnVQAgbagQ@mail.gmail.com>
Message-ID: <CABONVQaXONZQ2pKU8DqYC3Qx-y+ftOqVdnaJh-GwxnVQAgbagQ@mail.gmail.com>
To: Meral Shirazipour <meral.shirazipour@ericsson.com>
Cc: gen-art@ietf.org, draft-ietf-lpwan-schc-yang-data-model.all@ietf.org, last-call@ietf.org, lp-wan@ietf.org
Content-Type: multipart/alternative; boundary="0000000000009acf6305e5313f6c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/YQvcrPKrHlGa4q9cXNuXWMQayYI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lpwan-schc-yang-data-model-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2022 17:22:57 -0000

Hi Meral,

Thanks for the comments.

On Thu, Jul 28, 2022 at 12:01 AM Meral Shirazipour via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Meral Shirazipour
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-lpwan-schc-yang-data-model-14
> Reviewer: Meral Shirazipour
> Review Date: 2022-07-27
> IETF LC End Date: 2022-08-02
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: This draft is almost ready to be published as Standards Track RFC.
>
> Major issues:
>
> Minor issues:
> In Intro section please clarify benefits of this RFC formalizing the
> description of the compression rules. :
>
> "The goal of this document is to formalize the description of the rules to
> offer" to allow X Y Z ?
>

There is a brief description in the introduction. I added few words in the
abstract:for -15

This document formalizes the description of the rules for better
interoperability between SCHC instances either
to exchange a set of rules or to modify some rules parameters.




>
> Nits/editorial comments:
> [Page 3], Section 3, Typo
> "options definied"-->"options defined"
>

done

>
> [Page 3], Section 3, Typo
> "serveur"-->"server"
>

done


>
> [Page 6], Section 3.7, Typo
> "same enconding."-->"same encoding."
>

done

>
> [Page 7], Section 3.10.1, Typo
> "unidirectionnal,"--->"unidirectional,"
>

done


>
> [Page 10], Section 3.10.5, Typo
> "range sould"-->"range should"
> "recommandation"-->"recommendation"
>

done

>
> [Page 10], Section 3.10.5, Typo
> "the the"-->"the"
>

done

>
> [Page 10], Section 4, Typo
> "idenfied"-->"identified"
>

done

>
> [Page 33], Typo x2
> "bidirectionnal is forbiden"-->"bidirectional is forbidden"
>

don't find, should have corrected before