Re: [Gen-art] Gen-ART Last Call review of draft-ietf-hip-rfc5206-bis-12

Orit Levin <oritl@microsoft.com> Fri, 09 September 2016 21:02 UTC

Return-Path: <oritl@microsoft.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61D5312B023; Fri, 9 Sep 2016 14:02:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.022
X-Spam-Level:
X-Spam-Status: No, score=-2.022 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yRXPO8gCMelv; Fri, 9 Sep 2016 14:02:18 -0700 (PDT)
Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0103.outbound.protection.outlook.com [104.47.42.103]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8EAB912B3E5; Fri, 9 Sep 2016 14:02:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hKnmMqre7wq82qRiI7yCZYvb9wYXQ/3GgrFDzl1j8Ps=; b=mretpv/O85dIO/9R9QPUxstEsN8o7JqU7cEbbMU6x7RgIUzLs4dnkGzJnEMhXXh00nXUJxPGC7NmOPVk4bTrb0ZCVSMKJ1TwJgL5dTKq3+N+jpIh12t2YrjuhGUsFvol/+uPngPShT5swQk8Qerys+4zyIijvv6Hgb5RTlMON4M=
Received: from MWHPR03MB2863.namprd03.prod.outlook.com (10.175.135.21) by MWHPR03MB2861.namprd03.prod.outlook.com (10.175.135.19) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.21; Fri, 9 Sep 2016 21:02:17 +0000
Received: from MWHPR03MB2863.namprd03.prod.outlook.com ([10.175.135.21]) by MWHPR03MB2863.namprd03.prod.outlook.com ([10.175.135.21]) with mapi id 15.01.0557.032; Fri, 9 Sep 2016 21:02:17 +0000
From: Orit Levin <oritl@microsoft.com>
To: Tom Henderson <tomh@tomh.org>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>, "draft-ietf-hip-rfc5206-bis.all@ietf.org" <draft-ietf-hip-rfc5206-bis.all@ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-hip-rfc5206-bis-12
Thread-Index: AdH8vhVYnPtwgrKzSRqH1hQhAe++awGnTWAAAVy9LoAAgyjQ0A==
Date: Fri, 09 Sep 2016 21:02:17 +0000
Message-ID: <MWHPR03MB2863EAB99D1EFA1F24AB7C71ADFA0@MWHPR03MB2863.namprd03.prod.outlook.com>
References: <MWHPR03MB28639038A6D48CE94C9622FBADEA0@MWHPR03MB2863.namprd03.prod.outlook.com> <2b1eb276-6341-70dc-5ce5-5375a0035a93@ericsson.com> <8435a4ad-4094-e065-63bc-7d096f769605@tomh.org>
In-Reply-To: <8435a4ad-4094-e065-63bc-7d096f769605@tomh.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=oritl@microsoft.com;
x-originating-ip: [73.157.101.212]
x-ms-office365-filtering-correlation-id: 1c877676-aa28-4938-02c8-08d3d8f4950e
x-microsoft-exchange-diagnostics: 1; MWHPR03MB2861; 6:ypdOhJve9kuJUfgIx7CZLv9+GrNK4i0ZX7w975UTBQlJRWm3lNRxSAGyfvJbLf3KfVw20XTX4Y6IWUVeVJ7bQmZWELNLVV2dINWw1+PfeGHFV+6tIQGzPivl/4hq4pLwBIb8yCciiwpPBAfhQX6Ddz+oMKDhVn9YYIiDrjP+6vZM2QCe/XhA4y90qLuPyvVyjF2jx8iLIoinOo5/dxtgTAMJR3BEM1FTfWJBirKB6+vH93VI1MsYPdPuWMiSorv/7EKUDMJbQ6+oRjXs6zfMSbQaM/vbCmQU67SMpV9ICgNIxRLjhLGdzdh8Dhei/elJJtYbz0RFMXu9kgdBvrkBLA==; 5:xcxJXPwgAxArI65nJNbq/Lz2OndNEmcRGkV6x/JoKHYk9v0ZwyTiIkGcuVQZYWbajuC/ye2cRIF0juxJ+rCE2JIBr+axtEWqUfT1TtqCarYGvZH3++59Ea5+hfqOaQMRC7Pc8dHegpx6Mo39PO6ccQ==; 24:ufHrzPbAPyv94TNUIsTb/qYDHfhN5OVHhHQDMN3PoZRTNFvZApCtLBs+KE1S6klGRXjctEXFJJsx8+Ezcvpk8c23hI2mza8ZkBM0xzp/9As=; 7:1GlE6ST6hVwgxlxVaRkcjVDSQ5tmo93/bZInrTGDk0b/kIuejRICdjn2RINtHiFocVL2RUD89RNy5WzfkBiSaXZZh24yxhnOxcm9R4a1jhmbtxLuGnbtczAnI0CTRvZdAAX35zxJHkoq3BATqHS2TVRRdEOLLYd7MfPmN79zSvQEeJnkYwT+ln7TnkXUyEbolePZb6ekhdcbSS6Q4RNbP6F/GItAchl5Ygavy0iSklNrR6i/2iZ/JfdJJYTkGqV1
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2861;
x-microsoft-antispam-prvs: <MWHPR03MB28619EF0D0ED0BD76EE5897DADFA0@MWHPR03MB2861.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(37575265505322)(158342451672863)(192374486261705)(131327999870524)(788757137089);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038); SRVR:MWHPR03MB2861; BCL:0; PCL:0; RULEID:; SRVR:MWHPR03MB2861;
x-forefront-prvs: 00603B7EEF
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(24454002)(377424004)(199003)(189002)(13464003)(45984002)(377454003)(2906002)(68736007)(77096005)(19580395003)(54356999)(50986999)(2501003)(189998001)(74316002)(8676002)(345774005)(7696004)(92566002)(11100500001)(5002640100001)(3660700001)(101416001)(10090500001)(230783001)(19580405001)(81166006)(97736004)(8990500004)(10290500002)(86612001)(8936002)(5001770100001)(7846002)(7736002)(87936001)(5005710100001)(86362001)(81156014)(586003)(9686002)(76176999)(15975445007)(3280700002)(102836003)(76576001)(99286002)(4326007)(10400500002)(6116002)(2900100001)(106356001)(2950100001)(5660300001)(122556002)(105586002)(305945005)(3846002)(66066001)(33656002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR03MB2861; H:MWHPR03MB2863.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2016 21:02:17.2152 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2861
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Yd2i0Z2NbiRPcDp8CJPjYoqvbJA>
Cc: General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-hip-rfc5206-bis-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2016 21:02:22 -0000

Hi Tom,
I am really sorry that you didn't get the original email. I didn't sent it directly to the authors assuming that draft-ietf-hip-rfc5206-bis.all@ietf.org contains authors' names... 

I read your reply and looked at the diff between -12 and -13. I agree and like your changes - thank you very much! The only nit is that I would add the reference to the mulihoming draft/RFC in the Abstract (as in you did in your reply) instead of saying "elsewhere" (as in -13).

Unfortunately Gonzalo's email got trimmed so I am including the rest of my comments below. Hopefully it will not take much time to go over them.

------------------------------------------------------------------------------------------------------------------------------------------------------------
3.2.3 
Par. 2 Bullet 1: All "may" occurrences need to be capitalized. 

3.3.1
Add reference to Section 5.4, which uses a more formal language and provides more details.

4. LOCATOR_SET Parameter Format
Par. 1: "The LOCATOR_SET parameter ... defined by [RFC7401]" seems to be a mistaken statement.
Last paragraph: Describe what  a "sufficient scope" means.

5.1
Par.1 Remove "In a typical implementation" or explain the meaning of "typical".

5.2 and 5.3
Replace in the titles and in the text "LOCATOR_SETs" with "a/the LOCATOR_SET". Since handling of multiple SETs is left for future study, the current language is confusing.

5.2
Par. 1: Remove "Basically".

5.6
Ed. Par. 1: Replace "The following algorithm meets the security considerations" with "The following algorithm addresses the security considerations".


Additional editorial suggestions throughout the document:
1. Replace "--" with "i.e., ".
2. For each item or a list of items in brackets specify whether it is the full list (by adding i.e.,) or a list of examples (by adding e.g.,). 
3. Replace all/most low case appearances of "must" with "need(s) to". 
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Thanks!
Orit.

> -----Original Message-----
> From: Tom Henderson [mailto:tomh@tomh.org]
> Sent: Tuesday, September 06, 2016 11:08 PM
> To: Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>; Orit Levin
> <oritl@microsoft.com>; draft-ietf-hip-rfc5206-bis.all@ietf.org
> Cc: General Area Review Team <gen-art@ietf.org>
> Subject: Re: Gen-ART Last Call review of draft-ietf-hip-rfc5206-bis-12
> 
> On 08/31/2016 12:42 AM, Gonzalo Camarillo wrote:
> > Hi Tom,
> >
> > could you please address the review below as well?
> >
> > Thanks,
> >
> > Gonzalo
> 
> Orit, thank you for the review; for some reason, I did not get the
> original email. The updates due to your comments will appear in draft
> version 13.
> 
> >
> > On 24/08/2016 3:38 AM, Orit Levin wrote:
> >> I am the assigned Gen-ART reviewer for this draft. The General Area
> >> Review Team (Gen-ART) reviews all IETF documents being processed by
> >> the IESG for the IETF Chair.  Please treat these comments just like
> >> any other last call comments.
> >>
> >> For more information, please see the FAQ at
> >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> >>
> >> Document: draft-ietf-hip-rfc5206-bis-12 Reviewer: Orit Levin
> >> (oritl@microsoft.com) Review Date: 2016-08-23 IETF LC End Date:
> >> 2016-08-25 IESG Telechat date: unknown
> >>
> >> Summary: This draft is basically ready for publication, but has
> >> nits that should be fixed before publication. The nits below are
> >> arranged by sections of the draft. The majority of nits relate to
> >> explaining the scope of the draft and its relationship to the
> >> multihome functionality. Nits with suggestions for resolution are
> >> listed per section below. (Purely editorial suggestions are marked
> >> "Ed.".)
> >>
> >> Abstract: 1. Replace "extensions" to "extension" since the
> >> multihost case is addressed separately.
> 
> OK
> 
> 
> 2. Remove "general" in "a
> >> general LOCATOR_SET parameter" since it introduces confusion rather
> >> than adds clarification.
> OK
> 
> 
> 3. Replace "elements of procedure " with
> >> "a basic procedure".  Otherwise, the immediate question arises:
> >> what was the criteria for specifying some "elements" of the
> >> procedure, but not the others?
> 
> I have replaced the term here, although in my experience, the term
> 'elements of procedure' is commonly used in protocol specifications; e.g.:
> 
> https://tools.ietf.org/html/rfc1157#section-4.1
> 
> Since we use the term extensively throughout the draft, I would prefer
> to retain its use in general.
> 
> 4. Replace "While the same
> >> LOCATOR_SET parameter can also be used to support end-host
> >> multihoming, detailed procedures are out of scope for this
> >> document"  with something along these lines:
> >> "draft-ietf-hip-multihoming [replace with the future RFC number]
> >> addresses multihost functionality with HIP. At this time,
> >> coexistence of mobility and multihoming is left for future study."
> >> Reason: multihosting and mobility relate to each other
> >> hierarchically. The fact that the same parameter carrying a flat
> >> structure is used for both cases is counter-intuitive. Therefore,
> >> mentioning this fact without further explanation will only confuse
> >> the readers. My assumption is that the two extensions are expected
> >> to be implemented together, although not deployed together at this
> >> stage. This point needs to be clarified in the Abstract and,
> >> especially, in the Scope.
> 
> Note, I am not sure about the term 'multihosting' above and also below--
> do you mean multihoming?
> 
> I decided to list this as an 'out-of-scope' list item, as follows:
> 
>        While the same LOCATOR_SET parameter supports host multihoming
>        (simultaneous use of a number of addresses), procedures for host
>        multihoming are out of scope, and are specified in
>        [I-D.ietf-hip-multihoming].
> 
> 
> >>
> >> Introduction and Scope: Par. 3: Remove "generalized" as explained
> >> under Abstract.
> 
> OK
> 
> Par. 3: Replace "SA" with "security association
> >> (SA)" since it is being used for the first time.
> 
> the abbreviation is already expanded in paragraph 1
> 
> Par. 4: Replace
> >> "elements of procedure" with "a basic procedure" as explained under
> >> Abstract.
> 
> changed to 'procedures'
> 
> Par. 4: Add a brief description of the scope "by
> >> inclusion", not only by "exclusion". Describe the basic
> >> functionality  addressed by this standard in a couple of sentences.
> >> Perhaps rearrange the Scope into "in scope" and "out of scope".
> 
> see below Par. 5 response:
> 
> >> Par. 4: Replace "the sequential change" with "a change" because it
> >> is not clear what "sequential change" means without contrasting it
> >> with the "parallel change" of the multihosting case.
> 
> I shortened the whole sentence as follows:
> 
>        This document also specifies the messaging and elements of
>        procedure for end-host mobility of a HIP host.
> 
> 
> Par. 5:
> >> Replace the whole paragraph with a statement along the following
> >> lines: "This standard does not address multihosting.
> >> draft-ietf-hip-multihoming [replace with the future RFC number]
> >> defines multihost functionality with HIP. At this time, coexistence
> >> of mobility and multihoming is left for future study" as explained
> >> under Abstract. This is also probably the place to add the
> >> clarification that this draft support inclusion of a single
> >> LOCATOR_SET parameter and a single ESP_INFO parameter only in
> >> support of basic mobility scenarios.
> 
> I decided to address this and the the comment above about scope with a
> slight reorganization of 'in scope' and 'out of scope' so that the items
> are grouped together.
> 
> 
> > Ed. Par. 7: Replace " there is
> >> a need for some helper functionality in the network, such as a HIP
> >> rendezvous server" with "there is a need for some assistance from
> >> the network, such as by deploying a HIP rendezvous server".
> 
> This was reworded and simplified in the edit mentioned above.
> 
> >>
> >> Terminology and Conventions: LOCATOR_SET: Remove "The name of" from
> >> the definition.
> 
> OK
> 
> Locator and Address: Replace "A name" with "A
> >> parameter" or "A field" in both definitions.
> 
> Here I would like to keep 'A name' since such terminology refers back to
> the RFC 4423 HIP architecture document, on names and namespaces.
> 
> 
> Preferred locator: Add
> >> an explanation and/or a definition of the "scope" of a preferred
> >> locator.
> 
> I tried to handle this comment with a rewrite of the definition:
> 
>     Preferred locator.  A locator on which a host prefers to receive
>        data.  Certain locators are labelled as preferred when a host
>        advertises its locator set to its peer.  By default, the locators
>        used in the HIP base exchange are the preferred locators.  The use
>        of preferred locators, including the scenario where multiple
>        address scopes and families may be in use, is defined more in
>        [I-D.ietf-hip-multihoming] than in this document.
> 
> 
> >> Credit Based Authorization: Remove the first sentence.
> 
> OK
> 
> >> Replace the second sentence with "An approach [or a design choice]
> >> allowing a peer to receive a certain amount of data at the new
> >> locator before the result of mandatory verification is known."
> 
> Replaced with:
> 
>             A mechanism allowing a host to send a certain amount of data
>             to a peer's newly announced locator before the result of
>             mandatory address verification is known.
> 
> >>
> >> 3.1 Operating Environment Par. 2: Replace "extensions" with
> >> "extension"  and remove "and multihoming" because it is more
> >> confusing than helpful as explained above.
> 
> 
> OK
> 
> Ed. Par. 5: Change
> >> "Second" to "Secondly".
> 
> OK
> 
> >>
> >> 3.1.2 Mobility Overview Par. 1: Replace "containing a LOCATOR_SET
> >> parameter" with "containing a single ESP_INFO and a single
> >> LOCATOR_SET parameters".
> 
> OK
> >>
> >> 3.2 Protocol Overview Par. 1: Remove "However, for the (relatively)
> >> uninitiated reader" because this is not a standardization
> >> language.
> 
> OK
> 
> Par. 3: Replace "The majority of the packets on which the
> >> LOCATOR_SET parameters are expected to be carried are UPDATE
> >> packets" with "In support of mobility, the LOCATOR_SET parameter is
> >> carried in UPDATE packets".
> 
> OK
> >>
> >> 3.2.1 Par. 1: Replace "as in the first address" with "as in the
> >> previous address"
> >>
> 
> 
> OK
> 
> Are there more comments beyond 3.2.1?  (I am wondering if I may have
> missed another message).
> 
> - Tom