Re: [Gen-art] Genart last call review of draft-ietf-ice-rfc5245bis-16

Stewart Bryant <stewart.bryant@gmail.com> Sun, 28 January 2018 23:35 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D342913148C; Sun, 28 Jan 2018 15:35:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n5pJETEkCUtl; Sun, 28 Jan 2018 15:35:19 -0800 (PST)
Received: from mail-wr0-x235.google.com (mail-wr0-x235.google.com [IPv6:2a00:1450:400c:c0c::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0EF0F131478; Sun, 28 Jan 2018 15:35:19 -0800 (PST)
Received: by mail-wr0-x235.google.com with SMTP id 16so5272072wry.12; Sun, 28 Jan 2018 15:35:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=d16jsK3X1VaDMsHHCWa/+sBWPDQibIdQHsrR3Gla0pM=; b=gN6tMYKwYqlw/QXOQVfcwxuydMPycn9sVrzW/m5HDthwd3Pudi/PMQU5yT534X5b/R i9LmSZ0MvgWii1w/l03MqqjB45rLmPsA/ffllmOr9c9AWUtoEGi0Hq8but5jKELrLzOg kM7SNAVVA5LncYfi57zGAJaOrQIEevKsfTmwyfWKG1uBZXjiRV5TePy67zn7VA1RIPGL hyF8zdp1jN4135cpE3hU+oxoK4WXvYzRhw30tmyJT9EfFmnWgn13Q/RBH5L7JQX7CbeV nXiCxuEmWFVo1mfTrRyBdrmMUJzN7RIpFbjHiZsgk4akBv+8GW999fCKLvDJfSiBNYnb D5FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=d16jsK3X1VaDMsHHCWa/+sBWPDQibIdQHsrR3Gla0pM=; b=dCZ/G9VezFaMqZ2mLVIGoqJcWr6U5dj/1IgsYu6cB5aSMZy9P5O6BoFwqc7SJcmYAs ph9VK9jlFxI+eHot9bGXBwOVkz+1U2CNqW1kafv+PPgPBff1ukj9Ukyh0mkAWV6kin8U quy8EZ+CcB2gXY8MHbA9RkIKxB8cDmj3xKY3iUhqyAn1Fmm7xhJP7vG64aBr0WeO0beq vJL5QPs9a9W5WyUhIOcJFBgJzitCEgUmSR8erqx/X8GBRGAHs4tKdgfLX3rby4vES2Ks XyHEqy792QlC7p6kxofMSFICP7z48SnUMvmQVuecVCdU/ztEAefO4bShHcGg17iP02YD eXFw==
X-Gm-Message-State: AKwxytdz6lon0EbszoCvULAUDaMNKEh+VtBt49kRfapH3v3frkcXIaju EFHLmA8qWRuaoL7lumkDvoSCrPM6
X-Google-Smtp-Source: AH8x225QQyQQs39ngFy6B7uza1X1MyNiUpFICF64jeijfRRFWNtw37FS5uuAWiM41Sn9zxRRlLyaGQ==
X-Received: by 10.223.184.102 with SMTP id u35mr17069634wrf.143.1517182517370; Sun, 28 Jan 2018 15:35:17 -0800 (PST)
Received: from [192.168.2.173] (host213-123-124-182.in-addr.btopenworld.com. [213.123.124.182]) by smtp.gmail.com with ESMTPSA id x127sm7977861wmb.36.2018.01.28.15.35.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jan 2018 15:35:16 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (1.0)
From: Stewart Bryant <stewart.bryant@gmail.com>
X-Mailer: iPad Mail (15C153)
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B6C143F85@ESESSMB109.ericsson.se>
Date: Sun, 28 Jan 2018 23:35:15 +0000
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-ice-rfc5245bis.all@ietf.org" <draft-ietf-ice-rfc5245bis.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "ice@ietf.org" <ice@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <02C75B51-EA38-42C7-BD9B-FAC477FF0AC8@gmail.com>
References: <151691740516.8342.10156383952294498449@ietfa.amsl.com> <7594FB04B1934943A5C02806D1A2204B6C13FB29@ESESSMB109.ericsson.se> <2e40bec1-ce67-edd5-c2f8-73b00344e856@gmail.com> <7594FB04B1934943A5C02806D1A2204B6C143F85@ESESSMB109.ericsson.se>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/YlKZ8TWlT51yDv0KgUfH54WR65I>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ice-rfc5245bis-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Jan 2018 23:35:21 -0000

Yes, both would be excellent clarifications that would have helped me.

Thanks

Stewart

Sent from my iPad

> On 28 Jan 2018, at 13:28, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi Steward,
> 
> Please see inline.
> 
>> ---
>> 
>>> SB> You introduce Ta, but it would be so much kinder to the reader to 
>>> SB> give it a real name.
>> Ta was defined in RFC 5245, and it's commonly used in ICE-related 
>> discussions, so I think it would cause confusion to change the name at 
>> this point.
>> 
>> I understand. Maybe some words to explain it a little. Perhaps "the foo timer known in this technology as Ta" of something similar.
>> 
>>>> You say "Let HTO" again a user friendly name would be helpful to the 
>>>> new reader
>>> The name was provided by transport people that provided text. As it¹s 
>>> similar to RTO, I¹d like to keep it.
>> 
>> I see what you are doing. You could however give it a name and say known as HTO. A name just makes it easier to remember what it does.
> 
> First, I am not sure which generic timer Ta could be associated with. Ta is very ICE specific, as it controls the STUN/TURN transactions. 
> 
> Section 5.1.1.2 says:
> 
>   "The gathering process is controlled using a timer, Ta.  Every time Ta
>   expires, the agent can generate another new STUN or TURN transaction."
> 
> Would it help if I added the timer descriptions to the Terminology section? Something like:
> 
> Timer Ta:    The timer for generating new STUN or TURN transactions.
> Timer RTO:    The retransmission timer for a given STUN or TURN transaction.
> Timer HTO:    The timeout timer for a given STUN or TURN transaction.    
> 
> ---
> 
>>>> Appendix B is great, particularly from section B5 onwards. It would 
>>>> be great to forward reference this to help the reader understand the 
>>>> normative text earlier in the document.
>>> Any particular place where you would like to have the reference? In the Introduction?
>> Yes a heads up to to Appendix in the Intro would be useful, the a pointer to the specific section 
>> when you first introduce a parameter doing something in the protocol.
> 
> What about adding the following new paragraph to the end of the Introduction.
> 
> "[REF-to-Appendix-B] provide background information and motivations regarding the design
> decisions that were made when designing ICE."
> 
> Regards,
> 
> Christer