Re: [Gen-art] Genart last call review of draft-ietf-ace-oscore-profile-11

[Benjamin Kaduk <[e-mail]>]

On Tue, Jul 21, 2020 at 03:56:07PM -0700, Elwyn Davies via Datatracker wrote:
> Reviewer: Elwyn Davies
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ace-oscore-profile-11
> Reviewer: Elwyn Davies
> Review Date: 2020-07-21
> IETF LC End Date: 2020-07-20
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:  Almost ready.  There is one minor issue that needs sorting out and a
> fair number of nits.  Overall I have to say that I found it difficult to keep
> clear in my mind what messages were fully encrypted and which ones were sent en
> clair and which are in some intermediate class.  The authors might wish to go
> back over the document from the point of a naive reader to ensure that it is
> clear for implementers.
> 
> Major issues:
> None
> 
> Minor issues:
> s2, para 5:  Where does the 'input salt' come from?  The term is not used
> anywhere else in this document and  isn't defined or mentioned in either
> dreft-ace-oauth-authz or RFC 8613.

Hmm, it looks like this was introduced in the -09 as a result of one of my
review comments (as the formulation in the -08 implicitly had the name
"Master Salt" refer to both the string with and without N1+N2).  I think I
forgot enough of how this works that the authors will need to chime in with
an appropriate clarification of where the original ("input") salt comes
from.

Thanks for spotting that (as well as the other comments),

Ben