Re: [Gen-art] Genart last call review of draft-ietf-lamps-hash-of-root-key-cert-extn-03

Russ Housley <housley@vigilsec.com> Fri, 04 January 2019 23:04 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 639B8126BED for <gen-art@ietfa.amsl.com>; Fri, 4 Jan 2019 15:04:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ss9tu9v-ugUI for <gen-art@ietfa.amsl.com>; Fri, 4 Jan 2019 15:04:56 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 56922130EA1 for <gen-art@ietf.org>; Fri, 4 Jan 2019 15:04:56 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id C34EB300A55 for <gen-art@ietf.org>; Fri, 4 Jan 2019 17:39:04 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VJhYGiLnnOW1 for <gen-art@ietf.org>; Fri, 4 Jan 2019 17:39:02 -0500 (EST)
Received: from a860b60074bd.fios-router.home (pool-108-45-137-105.washdc.fios.verizon.net [108.45.137.105]) by mail.smeinc.net (Postfix) with ESMTPSA id 98D8B300400; Fri, 4 Jan 2019 17:39:02 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <154663683668.18349.10721321094359754098@ietfa.amsl.com>
Date: Fri, 04 Jan 2019 17:57:19 -0500
Cc: IETF Gen-ART <gen-art@ietf.org>, spasm@ietf.org, draft-ietf-lamps-hash-of-root-key-cert-extn.all@ietf.org, IETF <ietf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD1B2E3C-682E-4B2B-84EE-1B5E3A8A386E@vigilsec.com>
References: <154663683668.18349.10721321094359754098@ietfa.amsl.com>
To: Joel Halpern <jmh@joelhalpern.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/ZbeJyYn-wGUC8YubidMTNpS5Pw8>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lamps-hash-of-root-key-cert-extn-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 23:04:57 -0000

Joel:

Thanks for the review.

> Document: draft-ietf-lamps-hash-of-root-key-cert-extn-03
> Reviewer: Joel Halpern
> Review Date: 2019-01-04
> IETF LC End Date: 2019-01-10
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This draft is nearly ready for publication as an Informational RFC.
> 
> Major issues: N/A
> 
> Minor issues:
>    The explanation at the end of section 5 about the remedy for losing access
>    to the new root key left me confused.
> It looks like the situation is that there is a certificate out there, with the
> hash of root key extensions. The certificate owner loses access to the new key
> pair underlying the hash. The certificate owner clearly has to issue a new key
> pair.  So far, so good.
> 
> What the text seems to say is to simply issue a new self-signed certificate. 
> There are two possibilities for what is intended. I think the idea is that the
> new certificate will use the existing key pair (not the promised one, nor
> another new one) for its own signature, and include a new hash of root key for
> the newly generated pair.  If the certificate owner can do that (I have not
> dived into the rest of the certificate operations to figure out if that is
> legal) then it works.  Please add some words explaining that better. If the
> certificate owner can not simply issue a new self-signed certificate with the
> existing key pair, then I am lost.  It appears that the text says that the
> certificate owner issues a new self-signed certificate using a new key pair. 
> But that will fail the check against the previous certificate hash of root key.
> I am hoping that it is the first of these alternatives, and all that is needed
> is clearer explanatory text stating that the new cert uses the existing key
> pair, and includes a new hash of root key promise.

Joel, the Root CA want to start using a different key par, but they have lost access to the one that was previously generated for that purpose.  So, the remedy is to create a new self-signed certificate with a newly generated key.

Does that help?  If so, what would make the paragraph more clear?

Russ