Re: [Gen-art] Genart last call review of draft-ietf-ace-cwt-proof-of-possession-08

Mike Jones <Michael.Jones@microsoft.com> Wed, 16 October 2019 19:39 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E27041200FA; Wed, 16 Oct 2019 12:39:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.99
X-Spam-Level:
X-Spam-Status: No, score=-1.99 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0AUe2gWuy-Ju; Wed, 16 Oct 2019 12:39:45 -0700 (PDT)
Received: from NAM06-DM3-obe.outbound.protection.outlook.com (mail-eopbgr640136.outbound.protection.outlook.com [40.107.64.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 35108120105; Wed, 16 Oct 2019 12:39:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hbk415qLwdrYrrjcRL7Bj7Y0XmNCCMl8kLnTDnKuvzu/86Iu5LzcKfDQ2W4tvMwKIf7iXlB5w+MlBRPqgiavG/JlBtctXsFrpXaZx+f4399rB43gzdThFDvSbGoU81jmeOAOPSwY/h62OKIRqP3jAZKnWMxPWdKs5Eb65AgQJOWcGcDOzPXGFjiAE1hGEf+Y1UApsjJqN4myjbcKNosbvqHB/bmLcwkfJRJzdJhQI5dZt2TzDMjhcNrMj5Vk5d5qrytqIHOye6BtTldt0Kp2xQyBW3b5IBZ+4jzRzyN5UKIS7LmXk6+MXnNBdUIjYUDYSVSR3qSj6plqBkslbI+NqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9YjQIv7kmVFCigYG5YppcS+zM76OitH5OEko6/9cZA=; b=HbwzhkyQMzzCZnPySgfKMnW66VHPqNYdIJJZWbo+OBbNJLh2Ahi45G5vnL4o5yJ9PmZlMhK4D2xQq6lyE6X6syPrGEqlDVFUw3Amf+YdiEDFKPRi2yqpjnXNdguBW9TaEWnEjfCwXW8ol/mvb27f2aG+gcGOHdVLpKaltGQNrSnCj7diknZauMYYaQqOGBDXA57rCtCnx4blLRukKM1Ljj5bXenxajlQttni70yiZfsiYYaoZ9o1e2HC1y7E/Kvdt25z7DE0Sxbzo0I0cgeQ6KoIqA4SqBGIphdROfndJvThWI/ymA+C0kRmJj+f9teTqDY+HLkjTvJRjrTrQq8l/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9YjQIv7kmVFCigYG5YppcS+zM76OitH5OEko6/9cZA=; b=V0vNhBQfe/zwaGqVjJO5jt2H+LiUMn2KB4FofW3Y/p4i+LcntJaK3xRPo2w7Pag9paGiVQ+FmIWd87u4RnrBHL94FxA2wAjVuLFzl7eB3bNfaYGQ0SWP4IFFb7NESB7Knn3jXdIeQUuOI+bjbLxbC2j5dqgfPH0g6zVQkxCp5JQ=
Received: from DM6PR00MB0569.namprd00.prod.outlook.com (20.179.51.12) by DM6PR00MB0618.namprd00.prod.outlook.com (20.179.49.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2401.0; Wed, 16 Oct 2019 19:39:42 +0000
Received: from DM6PR00MB0569.namprd00.prod.outlook.com ([fe80::9196:77fa:83c0:9418]) by DM6PR00MB0569.namprd00.prod.outlook.com ([fe80::9196:77fa:83c0:9418%7]) with mapi id 15.20.2405.000; Wed, 16 Oct 2019 19:39:42 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-ace-cwt-proof-of-possession.all@ietf.org" <draft-ietf-ace-cwt-proof-of-possession.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "ace@ietf.org" <ace@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-ace-cwt-proof-of-possession-08
Thread-Index: AQHVettbQ32ECifdD0O+TX7Aa2ifMadduf7w
Date: Wed, 16 Oct 2019 19:39:42 +0000
Message-ID: <DM6PR00MB0569B15A50D4CA0EEA4B4DECF5920@DM6PR00MB0569.namprd00.prod.outlook.com>
References: <157021105722.1446.14439223392992273252@ietfa.amsl.com>
In-Reply-To: <157021105722.1446.14439223392992273252@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=92595862-c8a0-449e-9d88-0000d093eac5; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-10-16T19:28:15Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael.Jones@microsoft.com;
x-originating-ip: [2001:4898:80e8:f:98d9:5a0a:3425:3ebe]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b45c6728-65d3-4e0b-032d-08d752709789
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: DM6PR00MB0618:
x-microsoft-antispam-prvs: <DM6PR00MB061841C49B19B73997463C6EF5920@DM6PR00MB0618.namprd00.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0192E812EC
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(13464003)(189003)(199004)(22452003)(66446008)(6116002)(71200400001)(8936002)(81166006)(81156014)(606006)(8676002)(229853002)(4326008)(10290500003)(66556008)(66946007)(66476007)(71190400001)(54906003)(14454004)(86362001)(110136005)(64756008)(76116006)(25786009)(498600001)(790700001)(33656002)(2906002)(10090500001)(6506007)(53546011)(9686003)(11346002)(102836004)(186003)(55016002)(52536014)(54896002)(236005)(8990500004)(6246003)(2501003)(6306002)(76176011)(7736002)(7696005)(99286004)(256004)(486006)(6436002)(5660300002)(446003)(476003)(46003)(74316002)(14444005); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR00MB0618; H:DM6PR00MB0569.namprd00.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2jIA4XcFf9n0fZ9NtfuPe7Zc6V/1INTrj9maGQOWmUyFKi8mwiPBAFqam+Zuqwi6ev0uEGWjctc3qRCZ1rv36JkSqX6odnffBYJArFoifNozNBk21fOZhX05tkRFmcVCOh4DB5Z/u0R3jo4T81Q8e0Xx/7TLNvSyPtcBNJzH9jd/T1ra6J2Zy04fU2TiPSlsxYL/4+1Psbv0xwjt8E1g7IhDqodGMWxu7PUQGtzDaj8PAnjEqQHv/EEd08t3GmmK4iv1oM1VuyRQqhAijSN8ymNUgwWYpH+W1tBXMtD9O7v1UqI2RwaYc7JgtfcokEhqMvEgMjWY35LD8JtQ3OdMw8tdDkXCe2jEadCPo/Bd5lqK/kl8on+uVwLkEpnMvzTWByXG5I4/Syd7BKCUCv9GKp01sz0WQiRHnkRC6gtLcZE=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_DM6PR00MB0569B15A50D4CA0EEA4B4DECF5920DM6PR00MB0569namp_"
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b45c6728-65d3-4e0b-032d-08d752709789
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 19:39:42.7008 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /bIj0BJsp5QUP0sYQzVEx7uPyQWcEiU0sukwwgvkdMAk1ymUD1V/BayqgoWt+UtJzktCc5COqu5PYTH2bpcHlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR00MB0618
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Zzv7HM5EKaL_5-F_CPIlVrO-ww0>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ace-cwt-proof-of-possession-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 19:39:48 -0000

Thanks for your review, Christer.  Replies are inline, prefixed by "Mike>"…



-----Original Message-----
From: Christer Holmberg via Datatracker <noreply@ietf.org>;
Sent: Friday, October 4, 2019 10:44 AM
To: gen-art@ietf.org
Cc: draft-ietf-ace-cwt-proof-of-possession.all@ietf.org; ietf@ietf.org; ace@ietf.org
Subject: Genart last call review of draft-ietf-ace-cwt-proof-of-possession-08



Reviewer: Christer Holmberg

Review result: Ready with Issues



I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.



For more information, please see the FAQ at



<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrac.ietf.org%2Ftrac%2Fgen%2Fwiki%2FGenArtfaq&amp;data=02%7C01%7CMichael.Jones%40microsoft.com%7C4ffc136d2e014bc995db08d748f27b79%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C637058078607739810&amp;sdata=Lusqkbg276AKiI%2Fd5MNEMGYKLcP3y%2FfrHP5L1u6UqYw%3D&amp;reserved=0>;.



Document: draft-ietf-ace-cwt-proof-of-possession-08

Reviewer: Christer Holmberg

Review Date: 2019-10-04

IETF LC End Date: 2019-10-09

IESG Telechat date: Not scheduled for a telechat



Summary: For most part the document is ready, but I have a few editorial comments and an issue.



Major issues: N/A



Minor issues:



The text says in the Security Considerations that one must ensure that the might not understand the "cnf" claim, and that applications must ensure that receivers support it.



Q1: How are you going to ensure that, and why do you have to ensure that? RFC

8392 doesn't even seem to require that one must ensure that the receivers support CWT.



Mike> I agree that this text isn't actually actionable.  I propose that we simply delete it.



Q2: For receivers that do support CWT, RFC 8392 says that unsupported claims must be discarded. If that can't be applied for "cnf" I think you need to explain why.



Mike> The RFC 8392 requirement does apply.  This is also aligned with the text in 3.1, so I don't think there are any changes needed to the spec for this.



Nits/editorial comments:



Q_ED_1: Please use [RFC8392] instead of [CWT] when referencing to RFC 8392.



Mike> OK – will do.



Q_ED_2: Shall CBOR be enhanced on first occurrence (in the Abstract or Introduction), or is it on the list of well-known abbreviations?



Mike> I’d be glad to expand it to enhance readability.



Q_ED_3: Add a reference for CBOR map on first occurrence.



(I was looking in RFC 7049, and while it mentions maps in many places I could not find a proper definition for "CBOR map")



Mike> Sure.  I can add a reference to Section 2.1 of RFC 7049.