[Gen-art] Genart last call review of draft-ietf-teas-yang-te-types-09

Linda Dunbar via Datatracker <noreply@ietf.org> Tue, 14 May 2019 22:40 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DBE381202C1; Tue, 14 May 2019 15:40:52 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Linda Dunbar via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-teas-yang-te-types.all@ietf.org, ietf@ietf.org, teas@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.96.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Linda Dunbar <Linda.dunbar@huawei.com>
Message-ID: <155787365282.30182.991962621463628123@ietfa.amsl.com>
Date: Tue, 14 May 2019 15:40:52 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/_2HpZ7QNcBCqN_rTAEgNwq_f0bU>
Subject: [Gen-art] Genart last call review of draft-ietf-teas-yang-te-types-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2019 22:41:00 -0000

Reviewer: Linda Dunbar
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-teas-yang-te-types-??
Reviewer: Linda Dunbar
Review Date: 2019-05-14
IETF LC End Date: 2019-05-16
IESG Telechat date: Not scheduled for a telechat

Summary:
This document defines all the "Identity" (or types) for TE data types.
Therefore, it is hard to tell if all the types are completely specified without
cross reference to the TE specification drafts. For example, I tried to cross
reference to RFC3209 on "identity local-protection-desired", the words are not
completely matched in RFC3209.

(e.g. identity local-protection-desired {
base session-attributes-flags;
description "Fastreroute local protection is desired.";
reference "RFC3209";
}

It would make it much easier to validate the YANG model if the page number of
the referenced RFC is listed in the Reference, or the actual TLV being
referenced are described.

Major issues:

Minor issues:

Nits/editorial comments:
Add the page number of the referenced RFC  to make it easier to validate the
correctness of the "types", or describe the actual TLV being referenced .