Re: [Gen-art] Genart last call review of draft-ietf-6tisch-6top-protocol-10

Alissa Cooper <alissa@cooperw.in> Tue, 03 April 2018 18:01 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7076C12EB1B; Tue, 3 Apr 2018 11:01:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=efibTwsf; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=Y0GnoScS
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEh0JwD62dSe; Tue, 3 Apr 2018 11:01:22 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E6F912EAA6; Tue, 3 Apr 2018 11:00:40 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BEA1C20DED; Tue, 3 Apr 2018 14:00:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 03 Apr 2018 14:00:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=vXjIYz858hYVT6DZIpM29+G2tK6vc BCmyOExc3DjMtY=; b=efibTwsf7VJKUmMN42Gz8utMRmK8rBee1xrNspZFimH4B i6pN7MyphXW66vMUyCojGddDv9wrwbslUJTWk+FssSUgXOIMu7bQYapfxVeXz3si JI91cplBADzE/KjieeLC+0z2v21g++IgxkrdKlvSaX8oVujkFtyGRGAWWcO+q7el OSOBq4+a59ULK7kD/y5SeHqz83eSx+EgRzIwKsZdRXi5UWrjWNbQeodQ65wH2Pxh JWBXEo+w/bUdmM6n5XdCnp+Wi0PeOilhqQYVR1ggJPknRRdJ/JgSMeie/uAXxpBC t1fMtXZ6zDNwzG1hBYDmYZO0rZFMLdp0qyo89FlXQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vXjIYz 858hYVT6DZIpM29+G2tK6vcBCmyOExc3DjMtY=; b=Y0GnoScSN5XKTG0h80Oegi +RHvtQsQ2uWEHVRniDGpbbBcFCgSAZlJvHIo+OyMya3YfxNNFLYKFD4tvpUw/CMP KO8WWPpvpwAB2t3KASW7JfbFiLSQnTjb0RW+cK6rlfPm1Xf+IXzjzMx/gtKiEGYv HuaA82lXt6X5vKl2ZqEOd8BSunCX3HLKJ6fSdxPZNAAN5s0Y2Gor5jv48iuw74/m bUTURa42NCEn3Ze1XrhSB6/CVjbg89PIZhlbPp9y+wM4edWautNrGPwWFIwkGy1o 5wCqgGn8vhXWlx/TTshMjjTIgiq2wI9u57zi5t1er7ji96SjPuODwKcHNl3ib/Fw ==
X-ME-Sender: <xms:R8HDWn71W1gBLYSaCVrFm-KOV0vvFW-nT116zi8j1R8vj8HKt6glww>
Received: from rtp-alcoop-nitro3.cisco.com (unknown [173.38.117.78]) by mail.messagingengine.com (Postfix) with ESMTPA id CEFD4E50A8; Tue, 3 Apr 2018 14:00:38 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <9c248d9a-445f-ad4a-9f8c-f6d84c5cd882@gmail.com>
Date: Tue, 03 Apr 2018 14:00:37 -0400
Cc: Xavi Vilajosana Guillen <xvilajosana@uoc.edu>, draft-ietf-6tisch-6top-protocol.all@ietf.org, gen-art@ietf.org, tisch <6tisch@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B5DBAF85-DE7C-493A-8983-7071197A1403@cooperw.in>
References: <1795952350.395820.1520737954029.JavaMail.root@canet.uoc.es> <CAC9+vPiqHw1F7Nc+J5vQJreahHDfusBtgVMn03W=xa+TJN2HSw@mail.gmail.com> <03aaa42a-e65f-fc2f-9805-fbeec311c865@gmail.com> <9c248d9a-445f-ad4a-9f8c-f6d84c5cd882@gmail.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/_3PrGktny6Cp4tCN_f1gzEKfcAQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-6tisch-6top-protocol-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2018 18:01:35 -0000

Brian, thanks for your reviews. Authors, thanks for addressing Brian’s comments. I entered a No Objection ballot.

Alissa

> On Mar 31, 2018, at 5:28 PM, Brian E Carpenter <brian.e.carpenter@gmail.com> wrote:
> 
> Hi,
> 
> The published -11 text is even better than the proposal below.
> 
> Thanks
>   Brian Carpenter
> 
> On 23/03/2018 08:10, Brian E Carpenter wrote:
>> That looks good to me. I think it will help implementers.
>> 
>> Thanks
>>   Brian Carpenter
>> 
>> On 22/03/2018 21:41, Xavi Vilajosana Guillen wrote:
>>> Dear Brian,
>>> 
>>> after the WG meeting we proceed to resolve your pointed issue. Thanks so
>>> much for going through the draft again.
>>> 
>>> We will publish v11 with the following update on the text as you suggested.
>>> We hope this clarifies your point.
>>> 
>>> 
>>> In section 3.1.1.  2-step 6P Transaction
>>> we added:
>>> Race conditions MAY happen when a timeout expires while a 6P
>>>       Response is on the air.  Other inconsistencies can also happen
>>>       when the last L2 ACK for a 6P Response is lost or when one of the
>>>       nodes is power cycled.  6P provides an inconsistency detection
>>>       mechanism described in Section 3.4.6.1 to cope with such
>>>       situations.
>>> 
>>> 
>>> In section 3.1.2.  3-step 6P Transaction
>>> we added:
>>>  Race conditions MAY happen when a timeout expires while a 6P
>>>       Confirmation is on the air.  Other inconsistencies can also
>>>       happen when the last L2 ACK for a 6P Confirmation is lost or when
>>>       one of the nodes is power cycled.  6P provides an inconsistency
>>>       detection mechanism described in Section 3.4.6.1 to cope with
>>>       such situations.
>>> 
>>> 
>>> kind regards
>>> Xavi
>>> 
>>> 
>>> 2018-03-11 4:11 GMT+01:00 Brian Carpenter <brian.e.carpenter@gmail.com>:
>>> 
>>>> Reviewer: Brian Carpenter
>>>> Review result: Ready
>>>> 
>>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>>> Review Team (Gen-ART) reviews all IETF documents being processed
>>>> by the IESG for the IETF Chair.  Please treat these comments just
>>>> like any other last call comments.
>>>> 
>>>> For more information, please see the FAQ at
>>>> 
>>>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>>> 
>>>> Document: draft-ietf-6tisch-6top-protocol-10
>>>> Reviewer: Brian Carpenter
>>>> Review Date: 2018-03-10
>>>> IETF LC End Date: 2018-03-26
>>>> IESG Telechat date: 2018-04-05
>>>> 
>>>> Summary: Ready
>>>> 
>>>> Comment:
>>>> 
>>>> Most of my previous comments have been fixed, thanks. I still disagree
>>>> with the authors on one point, but not enough to delay the draft:
>>>> 
>>>> In section 3.1.1 "2-step 6P Transaction" there seems to be a rare race
>>>> condition
>>>> if A's timeout expires while B's Response is in flight. This will be
>>>> detected
>>>> later as an inconsistency (section 3.4.6.2). The authors don't think it's
>>>> necessary
>>>> to mention this in 3.1.1. IMHO it would be useful to mention. (Similarly
>>>> for
>>>> section 3.1.2, 3-step transaction.)
>>>> 
>>>> 
>>>> 
>>> 
>>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art