IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Telechat review of draft-ietf-rtgwg-remote-lfa-10.txt

Stewart Bryant <stbryant@cisco.com> Wed, 07 January 2015 11:49 UTC

Return-Path: <stbryant@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D774E1A89F6 for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 03:49:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id piMyF6pD0BWX for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 03:49:33 -0800 (PST)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC9AD1A89F5 for <gen-art@ietf.org>; Wed, 7 Jan 2015 03:49:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2451; q=dns/txt; s=iport; t=1420631373; x=1421840973; h=message-id:date:from:reply-to:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=mnjIXWalEF9YILoPEov9drsW4z5m62RfICpF/K8lMAw=; b=LpoccvOO/bm0Xm8Tu6x29e14gT3RC69i6B0RxrUehp47IYHbE1kudXJw LzT6Jh8qYzVFOX+aT/KlsTWbOCs6r5TV442J2kAnVn/Fd9JYxq0PWiE/0 6xinH5lSzFRutfkucNoxCoCmqSDKsu35Ge3woBWhGz9W/tICjEESEFv2r 0=;
X-IronPort-AV: E=Sophos;i="5.07,714,1413244800"; d="scan'208";a="298295520"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP; 07 Jan 2015 11:49:30 +0000
Received: from [64.103.108.132] (dhcp-bdlk10-data-vlan301-64-103-108-132.cisco.com [64.103.108.132]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id t07BnU3u008924; Wed, 7 Jan 2015 11:49:30 GMT
Message-ID: <54AD1D4A.8050609@cisco.com>
Date: Wed, 07 Jan 2015 11:49:30 +0000
From: Stewart Bryant <stbryant@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jari Arkko <jari.arkko@piuha.net>, Suresh Krishnan <suresh.krishnan@ericsson.com>
References: <E87B771635882B4BA20096B589152EF628A09746@eusaamb107.ericsson.se> <165B2599-7C0D-44A7-9CF4-0E12EF986B20@piuha.net>
In-Reply-To: <165B2599-7C0D-44A7-9CF4-0E12EF986B20@piuha.net>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/_QS0Vb8dwwkCRAFSgk3bB6fBhvU
Cc: "draft-ietf-rtgwg-remote-lfa.all@tools.ietf.org" <draft-ietf-rtgwg-remote-lfa.all@tools.ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Telechat review of draft-ietf-rtgwg-remote-lfa-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: stbryant@cisco.com
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2015 11:49:36 -0000

Thank you for the review Suresh.

On 07/01/2015 09:13, Jari Arkko wrote:
> Thanks for your review, Suresh. I agree with your points. Authors, are you taking this into account?
>
> Jari
>
> On 07 Jan 2015, at 08:10, Suresh Krishnan <suresh.krishnan@ericsson.com> wrote:
>
>> I am the assigned Gen-ART reviewer for this draft. For background on
>> Gen-ART, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>>
>> Please wait for direction from your document shepherd or AD before
>> posting a new version of the draft.
>>
>> Document: draft-ietf-rtgwg-remote-lfa-10.txt
>> Reviewer: Suresh Krishnan
>> Review Date: 2015/01/06
>> IESG Telechat date: 2015/01/08
>>
>> Summary: This draft is ready for publication as a Proposed Standard but
>> I have some minor issues that the authors may wish to address.
>>
>> Section 4.2.1.1:
>> This sentence is missing a verb (reach?)
>>
>> The exclusion of routers reachable via an ECMP that includes S-E
>> prevents the forwarding subsystem from attempting to <MISSING VERB> a
>> repair endpoint via the failed link S-E.
We will fix.
>>
>> Section 4.3:
>>
>> The Compute_Neighbor_SPFs() function seems to be missing a check for
>> verifying if the interface is not the failed interface. I think the
>> following check should be added.
>>
>> if (intf != fail_intf)
It is certainly harmless to do the computation, and in an implementation
that runs all the SPFs and banks them it will be needed if you protect
one than one interface. The rest of the code assumes that you have
all SPFs available. So I am not sure whether it is more confusing
to put it in or leave it out. I am also trying to get my head round
whether there are any corner cases that need that information (ECMP
is normally the optimization killer).

My inclination is to leave out the if statement and allow the implementer
to find the optimization rather than risk forgetting some subtly.

I could put in a comment about running them all so you have the
information ready for the next interface that needs rlfa protection.

Stewart
>> Thanks
>> Suresh
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art


-- 
For corporate legal information go to:

http://www.cisco.com/web/about/doing_business/legal/cri/index.html

v2.23.0 | Report a Bug | By Email