Re: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
"Roni Even (A)" <roni.even@huawei.com> Tue, 24 September 2019 04:30 UTC
Return-Path: <roni.even@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ADFEE1200F4; Mon, 23 Sep 2019 21:30:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E-hQ8sV-KQvP; Mon, 23 Sep 2019 21:30:01 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 758E51200B8; Mon, 23 Sep 2019 21:30:01 -0700 (PDT)
Received: from lhreml706-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 407E68E63D67543F9978; Tue, 24 Sep 2019 05:29:59 +0100 (IST)
Received: from DGGEMM401-HUB.china.huawei.com (10.3.20.209) by lhreml706-cah.china.huawei.com (10.201.108.47) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 24 Sep 2019 05:29:58 +0100
Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.207]) by DGGEMM401-HUB.china.huawei.com ([10.3.20.209]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 12:29:51 +0800
From: "Roni Even (A)" <roni.even@huawei.com>
To: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, Jaime Jiménez <jaime@iki.fi>, Roni Even <ron.even.tlv@gmail.com>
CC: "draft-ietf-core-hop-limit.all@ietf.org" <draft-ietf-core-hop-limit.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "core@ietf.org" <core@ietf.org>
Thread-Topic: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
Thread-Index: AQHVcUmuXxbPJdHB3E6qYwe0zeL4n6c4sylg//+RvoCAAfmSQA==
Date: Tue, 24 Sep 2019 04:29:51 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD23D6B5C5@DGGEMM506-MBX.china.huawei.com>
References: <156915425127.1340.18230115848839912205@ietfa.amsl.com> <20190922132830.kemraqhnzcjxprt2@EMB-918HFH01> <6E58094ECC8D8344914996DAD28F1CCD23D6A192@DGGEMM506-MBX.china.huawei.com> <787AE7BB302AE849A7480A190F8B933031324439@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <787AE7BB302AE849A7480A190F8B933031324439@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.202.58]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/_mopCx4n0pn2zD1lbA-Dwn_RUcM>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2019 04:30:04 -0000
Hi Med, Thanks, I have no further comments Roni -----Original Message----- From: mohamed.boucadair@orange.com [mailto:mohamed.boucadair@orange.com] Sent: Monday, September 23, 2019 9:19 AM To: Roni Even (A); Jaime Jiménez; Roni Even Cc: draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; ietf@ietf.org; core@ietf.org Subject: RE: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05 Hi Roni, Sure. We can include a suggested value. Thank you for the review. Cheers, Med > -----Message d'origine----- > De : Roni Even (A) [mailto:roni.even@huawei.com] Envoyé : lundi 23 > septembre 2019 07:01 À : Jaime Jiménez; Roni Even Cc : > draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; > ietf@ietf.org; core@ietf.org Objet : RE: [Gen-art] Genart last call > review of draft-ietf-core-hop- > limit-05 > > Hi, > I looked at section 5.4.6 and now I understand that the option is > elective, non-repeatable and part of cache key. > That will mean that the option number should have the two least > significant bits as 0 and the next 3 bits some combination that is not > all 1's, see also https://tools.ietf.org/html/rfc7252#section-5.10 > > I think you need to recommend a number for the option to IANA that > will allow understanding of the characteristics of the option, IANA > cannot allocate a random number to a new option > > Roni > > > > -----Original Message----- > From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Jaime > Jiménez > Sent: Sunday, September 22, 2019 4:29 PM > To: Roni Even > Cc: draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; > ietf@ietf.org; core@ietf.org > Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-hop- > limit-05 > > Dear Roni, > > I believe the CUNR bit mask is defined in 5.4.6 > https://tools.ietf.org/html/rfc7252#page-39 > I assume it has to be added for every new option defined. > > Ciao! > > On Sun, Sep 22, 2019 at 05:10:51AM -0700, Roni Even via Datatracker wrote: > > Reviewer: Roni Even > > Review result: Ready with Nits > > > > I am the assigned Gen-ART reviewer for this draft. The General Area > > Review Team (Gen-ART) reviews all IETF documents being processed by > > the IESG for the IETF Chair. Please treat these comments just like > > any other last call comments. > > > > For more information, please see the FAQ at > > > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > > > Document: draft-ietf-core-hop-limit-?? > > Reviewer: Roni Even > > Review Date: 2019-09-22 > > IETF LC End Date: 2019-09-27 > > IESG Telechat date: Not scheduled for a telechat > > > > Summary: > > The document is ready for publication as a standard track RFC with > > nits > > > > Major issues: > > > > Minor issues: > > > > Nits/editorial comments: > > > > In section 6.2 I am not sure why you have CUNR , I did not see these > > values in > > RFC7252 section 12.2 > > https://tools.ietf.org/html/rfc7252#section-12.2 > > or in the registry > > > > +--------+---+---+---+---+------------------+-----------+ > > | Number | C | U | N | R | Name | Reference | > > +--------+---+---+---+---+------------------+-----------+ > > | TBA2 | | | | | Hop-Limit | [RFCXXXX] | > > +--------+---+---+---+---+------------------+-----------+ > > C=Critical, U=Unsafe, N=NoCacheKey, R=Repeatable > > > > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-ietf-c… Roni Even via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Jaime Jiménez
- Re: [Gen-art] Genart last call review of draft-ie… Roni Even (A)
- Re: [Gen-art] Genart last call review of draft-ie… mohamed.boucadair
- Re: [Gen-art] Genart last call review of draft-ie… Roni Even (A)
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper