Re: [Gen-art] Genart last call review of draft-ietf-lwig-crypto-sensors-05

Alissa Cooper <alissa@cooperw.in> Thu, 22 February 2018 05:46 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B83E4126FB3; Wed, 21 Feb 2018 21:46:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=bF3s9YX7; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=X7XIBPDG
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OB1-2QDKSz6u; Wed, 21 Feb 2018 21:46:50 -0800 (PST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3DA09126D3F; Wed, 21 Feb 2018 21:46:50 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A42AA20D0E; Thu, 22 Feb 2018 00:46:49 -0500 (EST)
Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Thu, 22 Feb 2018 00:46:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=nwbROZYD6NBNSxqIxKUoN986bntSL FwjJAujEGJ8jT8=; b=bF3s9YX7p5hfBmnrfFi6EuJidm43812lKYb1dh89wlqQp eG4bZsiwpCVGdxCPZwDRPzBe9vxkoQGlmY/KHsL/FVCBcB8H0AedGO3mzm7vLW79 mqlu9GvMecumYRSIuK/uPmYVy9g0ofSFUWj64ubbiLjm0zep9FC/M5jQcX2/OgOr t6TyKe+oFeAaCLMWuaXnZHB9/FmChmJrO4BHS2YayhUj3/Cy9B33E9beXtLaOTaU rVKCZ18GEDmws65GlbwmUHJ+BkFOax4k+E9joMjZVgx+DyED0w/9AdET88ew4rIt HCzcdZLVNPlIkPuHH4w14RMyYQAuv75LQOFD9mxLQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=nwbROZ YD6NBNSxqIxKUoN986bntSLFwjJAujEGJ8jT8=; b=X7XIBPDGMnyzyZfPL8F9w9 9H8U6rOzRMFCS6lP6jkYOJRKYf2TZlQlgqNwkNpQfQY5ejkgyOvk6oPUr1l18prH gJlA6pDQgbGQFFU3lPxQmYo5uVtGk5xdeDg+WL3XcXzYFYk4DU1+ImoG7zn3+Mqn sAyA/Z2EqjcDZizOphtq3t59zHR0vhU/dfTbydOfP2kO/51iwq/udzVpnv7VyR0y IhfBTccOtZnkRPQpLhKP8UIG7pm4Ns/McmDH5RK+rEdAdoudso6FRuj4TXanZia+ a466O7GozLd7gTZ1NIeEGTUNCOx85tm6xvtqvyNOd+e2l58C5jPybhprQGEcZU2Q ==
X-ME-Sender: <xms:SVmOWuPYwFFBtjtXUo2GrHU-0yaNwdNs0IC2ovHI3VwtbAZ52m4ozg>
Received: from [10.19.234.245] (unknown [128.107.241.191]) by mail.messagingengine.com (Postfix) with ESMTPA id A715A241A9; Thu, 22 Feb 2018 00:46:48 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <151851864376.22238.17813481758804477460@ietfa.amsl.com>
Date: Wed, 21 Feb 2018 21:46:47 -0800
Cc: General Area Review Team <gen-art@ietf.org>, lwip@ietf.org, draft-ietf-lwig-crypto-sensors.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <360B01B3-8FE2-4C15-95B6-3E75CDAE6518@cooperw.in>
References: <151851864376.22238.17813481758804477460@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/azItyQoDqvSU4jIbPHNX3iOSNLo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lwig-crypto-sensors-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 05:46:52 -0000

Dan, thanks for your review. I entered a No Objection ballot and look forward to responses from the authors/shepherd.

Alissa

> On Feb 13, 2018, at 2:44 AM, Dan Romascanu <dromasca@gmail.com> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lwig-crypto-sensors-05
> Reviewer: Dan Romascanu
> Review Date: 2018-02-13
> IETF LC End Date: 2018-02-19
> IESG Telechat date: 2018-02-22
> 
> Summary:
> 
> This is a well-written clear informational memo, documenting methods to secure
> networks built of resource-constrained devices. It describes a deployment model
> based on exchanges of signed objects, and documents available cryptographic
> libraries that may be suited to the targets. The conclusions include analysis
> of trade-offs and recommendations for future development and deployments.
> 
> The document is READY from Gen-ART perspective. There are a couple of
> non-blocking issues that I would be glad to have them clarified before
> approval. I have also pointed to a couple of nits.
> 
> Major issues:
> 
> Minor issues:
> 
> 1. In Section 7:
> 
> 'The location of the resource directory was configured into
>   the smart object sensor by hardcoding the IP address'
> 
> Is this reasonable? I understand that the goal of the exercise was to
> demonstrate that it is possible to implement the entire architecture with
> public-key cryptography on an 8-bit micro-controller, but hard-coding the IP
> address seems to be below the threshold of a functional system. IMO there is a
> need to be able for the sensor to acquire this address (DHCP stack, or a simple
> UI to stream in one address, etc.)
> 
> 2. In section 8.1 - I would expect some discussion about the extra-power needed
> to run the cryptography. There is a statement about these being less than
> device wake-up and sending messages, but some quantitative evaluation (in
> percentage) of the impact would be useful, taking into account that battery
> capacity is one of the most important constrained resources.
> 
> Nits/editorial comments:
> 
> 1. The document uses the alternate term of 'small devices' for
> 'resource-constraint devices'. I view this as kind of an inaccurate verbal
> automatism in the world of IoT, as 'small' is a relative term,
> resource-constrained devices are not necessarily small (like in reduced
> physical footprint), and small devices can be rich in resources. I would
> suggest to either avoid the term, or explain what it means in the context (e.g.
> ''Smart objects', 'small devices' and 'resource-constrained devices are used
> interchangeably in this document and mean ...')
> 
> 2. Please expand ECDSA at first occurrence
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art