Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05

Donald Eastlake <d3e3e3@gmail.com> Wed, 16 September 2015 07:05 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DCC51B37C4; Wed, 16 Sep 2015 00:05:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pS23ryLDRsXx; Wed, 16 Sep 2015 00:05:16 -0700 (PDT)
Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9129A1B37C6; Wed, 16 Sep 2015 00:05:16 -0700 (PDT)
Received: by oixx17 with SMTP id x17so114482200oix.0; Wed, 16 Sep 2015 00:05:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=5KRokiXXfrb4aWF4HPWNHx7CzOY1/mw85TAM0MA+y6Y=; b=ul4zLsZdaqNUuMNvDLepEHHThxeOd/LKv1ILA/eTJfF+Evzwzk5NnPXFRqCP8b8xAP bd4iY3rGIRkXhFAOCR0B/vZcNGJ2TqB6jKTHmbGa2HVfDG9cfrFjx35kHKC3SQiEum// nCqb2pB7wW6Tu6lAvDoT5Lz9iF+SbhQvDsgjcoGv6z3C/VsCdSBRbHDy18tz6eOypcOJ 3KYDfoT0p0qF3G0DwVBaZzxt7ukJDLLZ89lBiHVy08i8wPyFkc+atH2UMnm9wOe7EyCr T+98Lo15o2dKKOKA60yBVtn66B/MRIf5sCrZBGwmJzTpwSZ2dhmuyyF7gpqux2RaIYeG KlTg==
X-Received: by 10.202.202.14 with SMTP id a14mr21195990oig.73.1442387116013; Wed, 16 Sep 2015 00:05:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.76.144.65 with HTTP; Wed, 16 Sep 2015 00:05:01 -0700 (PDT)
In-Reply-To: <53C61587-9F97-4664-9F84-603199B46D3E@vigilsec.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com> <4552F0907735844E9204A62BBDD325E7871A2CFE@nkgeml512-mbx.china.huawei.com> <CAF4+nEGAnyBVrv=Rbc0gfDijYsjraBW62ugC1Rwo07e6PSg_NA@mail.gmail.com> <53C61587-9F97-4664-9F84-603199B46D3E@vigilsec.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 16 Sep 2015 03:05:01 -0400
Message-ID: <CAF4+nEFgeL0X8UpRqz30bHdb3jfoHO4i2gUEF_CVeJkPPwxioQ@mail.gmail.com>
To: Russ Housley <housley@vigilsec.com>
Content-Type: text/plain; charset=UTF-8
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/buw2VPp76y5hIwXKAqI0YpByqrk>
Cc: Mingui Zhang <zhangmingui@huawei.com>, IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>, "draft-ietf-trill-pseudonode-nickname.all@ietf.org" <draft-ietf-trill-pseudonode-nickname.all@ietf.org>
Subject: Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2015 07:05:17 -0000

See below:

On Fri, Sep 11, 2015 at 12:17 PM, Russ Housley <housley@vigilsec.com> wrote:
> Donald:
>
>>>> Document: draft-ietf-trill-pseudonode-nickname-05
>>>> Reviewer: Russ Housley
>>>> Review Date: 2015-08-24
>>>> IETF LC End Date: 2015-09-01
>>>> IESG Telechat date: unknown
>>>>
>>>> Summary: Almost Ready
>>>>
>>>> Major Concerns:
>>>>
>>>> ...
>>> ...
>>>
>>>> (2)  Also, in Section 5.2, Step 1, I think the intended sort order depends on all
>>>> of the LAALP IDi values being represented with the same number of bits.
>>>> Since Section 9.1 provides a variable length field to carry a LAALP ID value, I
>>>> assume that they are not always the same length.  Is a step needed to
>>>> encode the LAALP ID to a consistent length?
>>>
>>> [MZ] The sort is done in the per-LAALP base. It's not necessary to make the LAALP ID to a constant length. Besides, the 'mod' function always returns a value in [0, k-1] whatever the length of LAALP ID is.
>>
>> We could add "considering System ID and LAALP ID as byte strings".
>
> I am not sure that is enough unless all of the System IDs are the same length.
>
> Russ

I believe that currently all LAALP IDs are 8-byte System Identifiers
as specified in Clause 6.3.2 of IEEE Std 802.1AX-2014 used for MC-LAGs
or DRNIs; however, there could be other kinds in the future. Perhaps
the draft should say that the LAALP ID needs to be unique across the
TRILL campus, that it is a System Identifier as above if it is
8-bytes, and that the meaning for other length is reserved. But that
doesn't really answer the sort order or mod arithmetic questions.

How about just saying that they are treated as unsigned integers with
the bytes in network order?

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com