Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06

Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com> Thu, 07 June 2018 10:52 UTC

Return-Path: <spencerdawkins.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AA561310BF; Thu, 7 Jun 2018 03:52:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 52sUT8YGpW4V; Thu, 7 Jun 2018 03:52:44 -0700 (PDT)
Received: from mail-yb0-x22a.google.com (mail-yb0-x22a.google.com [IPv6:2607:f8b0:4002:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B039130ED0; Thu, 7 Jun 2018 03:52:44 -0700 (PDT)
Received: by mail-yb0-x22a.google.com with SMTP id f79-v6so3067107ybg.2; Thu, 07 Jun 2018 03:52:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+8f9LH6ebkJSa4WN/iX5Wj9kAgBH/j/TcyG7y+kMaN0=; b=k5AI7FWtXgIBdGd59+h2KkfXj3/ukxvN/yRmhuesV67MYH4tfZSMOxg+vYje+V2XjD l1grsvgnfQCqJXGSW9NV7ERaIzTw8HnFsgue4mcobVexz70NGr0A/KMf7l+pMkzSVp8q KyJ3eQbPv2RmPUkDe6xuQOCaVcFbfw4AUb1es+jDVP3hFmK3KajFFy45CHf1y9yieMd2 xY089mCUlU4Pci9Hdke14yPter+yXR5PbdT+yeOr7Jx6VHADG2AvwqRR719VyMZsAib7 qPPLTxxCTYzUnxJsyDHzHRT/UiMAP9JAiHfzKa20Og4LN7ZBucr/xft5HZCyHa9lD8Rn R39Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+8f9LH6ebkJSa4WN/iX5Wj9kAgBH/j/TcyG7y+kMaN0=; b=sO5jhgZqF375JSmzgtf9FPmPk/mJTeumoGH48G6NswIheU53uoXyXszTyvQJxJ3JVL yP8+pPwkoCzdwNtsYOGU2U3yY3q9zS1Vi2Luq8U7weJPDu66g2/GB8+WGNQaDpXW7A8E /79/feCzYxEf5on9x15htXPnlzYvirJ61t5o00S9pCOSE9Btv4qDLfV9d3xcxXIpmuCO 0VuSMrqfMbeJyaOahHEkjjDyhyQJj0Z0QVXYEZx+p06OkkqJV4Up240AHrBao3kvL9Nc iLNh9WimqOzozlz2SMctAtKwvHbk2tyv+9MskPTrkhwGkUoQFyvG+Yhe+4BS42sf2WZr O9+A==
X-Gm-Message-State: APt69E3Xh/FRu2yTaSd6xb5EbE5Agi9fQOj7XJiTmsbz+6Ah5x4ovaAe kjfbnviohRKNle8D55mGu+HdG+3Apxl7U1zCXic=
X-Google-Smtp-Source: ADUXVKJpQxYBHWk5IooG1LD9QbeZbFO9ZnF/HE/Wr0AaQgnvDILsUHv0Os+c5X7rd7VDjLAQZmrRoXP0V1yWU5eHsu8=
X-Received: by 2002:a25:ba48:: with SMTP id z8-v6mr705729ybj.110.1528368763255; Thu, 07 Jun 2018 03:52:43 -0700 (PDT)
MIME-Version: 1.0
References: <9c54eccb-82f2-e135-39af-6bf32824b648@alum.mit.edu> <D73AC219.30C7F%christer.holmberg@ericsson.com> <D73ADF2B.30D2E%christer.holmberg@ericsson.com> <21073937-e22d-2b13-ffc2-aec9e14fd3bb@erg.abdn.ac.uk> <D73AE907.30D50%christer.holmberg@ericsson.com> <D73AF870.30D78%christer.holmberg@ericsson.com> <F7AFF99B-5709-418B-BD70-5F3210E9EF0D@macmic.franken.de> <D73EAF20.30F9C%christer.holmberg@ericsson.com> <A587E359-6A0F-4803-82B4-B41D251B1239@macmic.franken.de> <5B1909D3.4050509@erg.abdn.ac.uk>
In-Reply-To: <5B1909D3.4050509@erg.abdn.ac.uk>
From: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
Date: Thu, 07 Jun 2018 05:52:31 -0500
Message-ID: <CAKKJt-dn=HRnJR3vPaHmGjcMb6pvdQ-bBYdPfRLbU0M2=VFbUQ@mail.gmail.com>
To: G Fairhurst <gorry@erg.abdn.ac.uk>
Cc: Michael.Tuexen@macmic.franken.de, Christer Holmberg <christer.holmberg@ericsson.com>, Paul Kyzivat <pkyzivat@alum.mit.edu>, draft-ietf-tsvwg-rfc4960-errata.all@ietf.org, gen-art <gen-art@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000003841d5056e0b15c7"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/cHfLeT2qk9dDB5tHHAHn7SxEfH0>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2018 10:52:51 -0000

FWIW,

On Thu, Jun 7, 2018 at 5:33 AM Gorry Fairhurst <gorry@erg.abdn.ac.uk> wrote:

> +1, as Chair. I see we have caused a little confusion here - The WG will
> not repeat this list of changes again as a part of the new .bis document.
>
> There could always be potentially be further changes as the .bis
> document passes through the WG - of course - but we'd rather expect this
> spec is mature -- indeed there was suggestion the final Spec could
> progress to Full Standard (to be confirmed of course).
>

Thanks, Michael and Gorry, for clarifying this.

I think everyone who lived through 4460 and 4960 knew this, and no one one
who didn't live through that knew it, so that's very helpful.

Spencer


> Gorry
>
> On 07/06/2018, 11:19, Michael Tuexen wrote:
> >> On 7. Jun 2018, at 02:43, Christer Holmberg<
> christer.holmberg@ericsson.com>  wrote:
> >>
> >>
> >> Hi,
> >>
> >>>> Not a comment on the document, but a question/suggestion:
> >>>>
> >>>> If you want to have a place holder for changes to be done in the bis
> >>>> (which seems to be the main purpose of the errata document), why not
> >>>> create a GitHub repo for the bis, and then document everything as
> GitHub
> >>>> issues? Then, when you start working on the bis, you can map each
> issue
> >>>> to
> >>>> a pull request etc.
> >>> We did use a github report using issues which working on this document.
> >>>
> >>> Replacing this document with an github issue tracker doesn't seem
> >>> attraktive to me. Github can go away at any time or gets replaced
> >>> by other tools and than the information would not be accessible
> >>> anymore. Please note that we document the changes and the reasoning
> >>> not for us, but for developers which are interested in it in the
> >>> future.
> >> Sure, but my understanding is that the future, i.e., the bis document,
> is
> >> coming soon, and I guess the bis document will anyway describe the
> changes
> >> (and the reasons) compared to RFC 4960.
> > Hi Christer,
> >
> > no it doesn't. It will be basically RFC 4960 + the diff from the errata
> > document applied.
> >
> > We did this in the past. See
> > RFC 2960 as the initial specification of SCTP.
> > RFC 4460 as an errata document
> > RFC 4960 as the updated specification of SCTP.
> >
> > As you see, RFC 4960, does not tell you what has changed or why.
> > If a developer is not interested in that and just wants to
> > implement SCTP, only the reading on RFC 4960 is needed. If
> > someone wants to understand the changes, he can read RFC 4460.
> >
> > Best regards
> > Michael
> >> Anyway, since I haven’t been involved in the work, I don’t want to argue
> >> about the way the WG is working. It was just a question/suggestion :)
> >>
> >> Regards,
> >>
> >> Christer
> >>
> >>
> >>
> >>
> >>>> Regards,
> >>>>
> >>>> Christer
> >>>>
> >>>> On 04/06/18 13:13, "Gen-art on behalf of Christer Holmberg"
> >>>> <gen-art-bounces@ietf.org on behalf of christer.holmberg@ericsson.com
> >
> >>>> wrote:
> >>>>
> >>>>> Hi Gorry,
> >>>>>
> >>>>> ...
> >>>>>
> >>>>>> The information in this document does not update RFC4640 or the
> Errata
> >>>>>> to that specification.  The document is instead provided as input to
> >>>>>> preparation of a new document that is expected to be a
> standards-track
> >>>>>> replacement for RFC4960. If approved, the replacement document will
> >>>>>> incorporate the updates described here and any other changes needed
> to
> >>>>>> allow this to progress this specification along the standards track.
> >>>>> I am ok with the two first sentences.
> >>>>>
> >>>>> But, I don’t think you can make the last sentence. This document
> cannot
> >>>>> normatively define text for the replacement document, or assume that
> >>>>> everything will be incorporated: the WG will have to agree on what
> goes
> >>>>> into the replacement document once it has been added to the charter
> >>>>> etc,
> >>>>> using normal IETF procedures.
> >>>>>
> >>>>> Regards,
> >>>>>
> >>>>> Christer
> >>>>>
> >>>>>
> >>>>>
> >>>>>>>> On 03/06/18 21:59, "Gen-art on behalf of Paul Kyzivat"
> >>>>>>>> <gen-art-bounces@ietf.org on behalf of pkyzivat@alum.mit.edu>
> wrote:
> >>>>>>>>
> >>>>>>>>> [[INCOMPLETE, NOT READY TO SEND. PLEASE IGNORE]]
> >>>>>>>>>
> >>>>>>>>> I am the assigned Gen-ART reviewer for this draft. The General
> Area
> >>>>>>>>> Review Team (Gen-ART) reviews all IETF documents being processed
> by
> >>>>>>>>> the
> >>>>>>>>> IESG for the IETF Chair. Please treat these comments just like
> any
> >>>>>>>>> other
> >>>>>>>>> last call comments. For more information, please see the FAQ at
> >>>>>>>>> <​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> >>>>>>>>>
> >>>>>>>>> Document: draft-ietf-tsvwg-rfc4960-errata-06
> >>>>>>>>> Reviewer: Paul Kyzivat
> >>>>>>>>> Review Date: 2018-06-03
> >>>>>>>>> IETF LC End Date: 2018-06-04
> >>>>>>>>> IESG Telechat date: ?
> >>>>>>>>>
> >>>>>>>>> Summary:
> >>>>>>>>>
> >>>>>>>>> This draft is on the right track but has open issues, described
> in
> >>>>>>>>> the
> >>>>>>>>> review.
> >>>>>>>>>
> >>>>>>>>> Issues:
> >>>>>>>>>
> >>>>>>>>> Major: 1
> >>>>>>>>> Minor: 2
> >>>>>>>>> Nits:  1
> >>>>>>>>>
> >>>>>>>>> 1) MAJOR:
> >>>>>>>>>
> >>>>>>>>> The format of this document disturbs me. According to the
> abstract:
> >>>>>>>>>
> >>>>>>>>>    ... This
> >>>>>>>>>    document provides deltas to RFC4960 and is organized in a time
> >>>>>>>>>    ordered way.  The issues are listed in the order they were
> >>>>>>>>> brought
> >>>>>>>>>    up.  Because some text is changed several times the last delta
> >>>>>>>>> in
> >>>>>>>>> the
> >>>>>>>>>    text is the one which should be applied.
> >>>>>>>>>
> >>>>>>>>> This format makes the document hard to deal with. A developer who
> >>>>>>>>> wants
> >>>>>>>>> to implement sctp with some or all of the errata fixes will want
> to
> >>>>>>>>> work
> >>>>>>>>> from a variant of 4960 that incorporates all of those fixes - a
> >>>>>>>>> bis.
> >>>>>>>> But
> >>>>>>>>> it isn't clear how this document helps with that. I don't think
> you
> >>>>>>>>> can
> >>>>>>>>> start with 4960 and simply apply all the deltas sequentially,
> >>>>>>>>> because
> >>>>>>>>> overlapping changes won't work right.
> >>>>>>>>>
> >>>>>>>>> A developer won't be interested in the order in which errata were
> >>>>>>>>> reported. An actual bis document would be more useful to a
> >>>>>>>>> developer
> >>>>>>>>> than this format. Is that not being done because doing so would
> be
> >>>>>>>>> more
> >>>>>>>>> difficult? Or because it isn't yet certain that these are the
> >>>>>>>>> correct
> >>>>>>>>> fixes?
> >>>>>>>>>
> >>>>>>>>> I think you should give some serious consideration of the most
> >>>>>>>>> suitable
> >>>>>>>>> form for this document, in the context of how it is intended to
> be
> >>>>>>>>> used.
> >>>>>>>>>
> >>>>>>>>> 2) MINOR (maybe MAJOR):
> >>>>>>>>>
> >>>>>>>>> Discovering where one change is impacted by another change is
> hard.
> >>>>>>>>>
> >>>>>>>>> I dug into the details of the document to understand how many
> >>>>>>>>> places
> >>>>>>>>> there are actually overlaps between the changes in multiple
> >>>>>>>>> sections.
> >>>>>>>>> (It took a lot of work to do this.) I found five of these:
> >>>>>>>>>
> >>>>>>>>> - 3.1 / 3.23
> >>>>>>>>> - 3.3 / 3.43
> >>>>>>>>> - 3.5 / 3.10
> >>>>>>>>> - 3.6 / 3.23
> >>>>>>>>> - 3.24 / 3.32
> >>>>>>>>>
> >>>>>>>>> (I don't guarantee that this list is exhaustive.)
> >>>>>>>>>
> >>>>>>>>> Of these, I think only one (3.1/3.23) explicitly indicates the
> >>>>>>>>> conflict,
> >>>>>>>>> and it only indicates it within 3.23.
> >>>>>>>>>
> >>>>>>>>> Most of the changes don't have any conflicts. And some of the
> >>>>>>>>> conflicts
> >>>>>>>>> could be removed by being more precise in indicating the change
> >>>>>>>>> being
> >>>>>>>>> made. In cases where this isn't possible, the presence of the
> >>>>>>>>> conflict
> >>>>>>>>> should be indicated in each section that has a conflict, with
> cross
> >>>>>>>>> references. IOW, shift the burden of detecting conflicts from the
> >>>>>>>>> reader
> >>>>>>>>> to the document.
> >>>>>>>>>
> >>>>>>>>> 3) MINOR:
> >>>>>>>>>
> >>>>>>>>> Errata Tracking: Apparently each subsection of section 3 covers
> one
> >>>>>>>>> erratum. But the errata numbers are not mentioned. Each section
> >>>>>>>>> ought
> >>>>>>>>> to
> >>>>>>>>> reference the errata number it responds to.
> >>>>>>>>>
> >>>>>>>>> 4) NIT:
> >>>>>>>>>
> >>>>>>>>> In section 3.35 (DSCP Changes) the change to section 10.1 isn't
> >>>>>>>>> properly
> >>>>>>>>> indicated. It shows 'Old text' twice rather than 'Old text' and
> >>>>>>>>> 'New
> >>>>>>>>> text'.
> >>>>>>>>>
> >>>>>>>>> _______________________________________________
> >>>>>>>>> Gen-art mailing list
> >>>>>>>>> Gen-art@ietf.org
> >>>>>>>>> https://www.ietf.org/mailman/listinfo/gen-art
> >>>>>>>> _______________________________________________
> >>>>>>>> Gen-art mailing list
> >>>>>>>> Gen-art@ietf.org
> >>>>>>>> https://www.ietf.org/mailman/listinfo/gen-art
> >>>>>>
> >>>>> _______________________________________________
> >>>>> Gen-art mailing list
> >>>>> Gen-art@ietf.org
> >>>>> https://www.ietf.org/mailman/listinfo/gen-art
>
>