Re: [Gen-art] Gen-ART review of draft-ietf-dhc-dynamic-shared-v4allocation-06

<ian.farrer@telekom.de> Fri, 08 May 2015 14:03 UTC

Return-Path: <ian.farrer@telekom.de>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D86451A1B0E for <gen-art@ietfa.amsl.com>; Fri, 8 May 2015 07:03:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.859
X-Spam-Level:
X-Spam-Status: No, score=-3.859 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_DE=0.35, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EY88JdwSDguj for <gen-art@ietfa.amsl.com>; Fri, 8 May 2015 07:03:27 -0700 (PDT)
Received: from tcmail13.telekom.de (tcmail13.telekom.de [80.149.113.165]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 481C31A1B56 for <gen-art@ietf.org>; Fri, 8 May 2015 07:02:58 -0700 (PDT)
Received: from s4de8nsazdfe010.bmbg.telekom.de ([10.175.246.202]) by tcmail11.telekom.de with ESMTP; 08 May 2015 16:02:20 +0200
X-IronPort-AV: E=Sophos;i="5.13,391,1427752800"; d="scan'208,217";a="669585113"
Received: from he110889.emea1.cds.t-internal.com ([10.134.92.130]) by q4de8nsa015.bmbg.telekom.de with ESMTP/TLS/AES128-SHA; 08 May 2015 16:02:20 +0200
Received: from HE111643.EMEA1.CDS.T-INTERNAL.COM ([10.134.93.12]) by HE110889.emea1.cds.t-internal.com ([fe80::841f:f92c:15ca:8526%16]) with mapi; Fri, 8 May 2015 16:02:20 +0200
From: ian.farrer@telekom.de
To: christer.holmberg@ericsson.com, gen-art@ietf.org
Date: Fri, 08 May 2015 16:02:18 +0200
Thread-Topic: Gen-ART review of draft-ietf-dhc-dynamic-shared-v4allocation-06
Thread-Index: AdCA49V9mSr3sg2JTiu45XbVlzOA7AImkBkw
Message-ID: <8A1B81989BCFAE44A22B2B86BF2B76318BFA4DE671@HE111643.EMEA1.CDS.T-INTERNAL.COM>
References: <7594FB04B1934943A5C02806D1A2204B1D7D97B5@ESESSMB209.ericsson.se>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B1D7D97B5@ESESSMB209.ericsson.se>
Accept-Language: en-US, de-DE
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US, de-DE
Content-Type: multipart/alternative; boundary="_000_8A1B81989BCFAE44A22B2B86BF2B76318BFA4DE671HE111643EMEA1_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/cdtjlvuwnphMlWtbIq4L4h4XO70>
Cc: sunqi.csnet.thu@gmail.com, draft-ietf-dhc-dynamic-shared-v4allocation.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-dhc-dynamic-shared-v4allocation-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 May 2015 14:03:32 -0000

Hi Christer,

Many thanks for your review. Please find suggested updates inline below.

Best regards,
Ian

From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Montag, 27. April 2015 14:36
To: gen-art@ietf.org
Cc: draft-ietf-dhc-dynamic-shared-v4allocation.all@tools.ietf.org
Subject: Gen-ART review of draft-ietf-dhc-dynamic-shared-v4allocation-06

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                                   draft-ietf-dhc-dynamic-shared-v4allocation-06
Reviewer:                                     Christer Holmberg
Review Date:                               27 April 2015
IETF LC End Date:                       6 May 2015
IETF Telechat Date:                   N/A
Summary:                                     The document is well written, and almost ready for publication. However, I have spotted a few places where I think some additional text is needed.
Major Issues: None
Minor Issues: None
Editorial Issues:

Section 2:
Q_2_1:
The text says that the solution is not applicable for network access over shared mediums.
I think it would be useful to add some words describing why that is the case.

[if] Proposed text to be added:
The solution allows multiple hosts to be simultaneously allocated the same IP address. As the IP address is no longer a unique identifier for a host, this extension is only suitable for specific architectures based on the Address plus Port model (A+P) [RFC6346]> such as [I-D.ietf-softwire-lw4over6] and certain configurations of [I-D.ietf-softwire-map].
Section 10:
                             Q_10_1:
                             The text says: "The security considerations in [RFC2131] and [RFC7341] are to be considered."
                             I think a little more text is needed, talking about what type of security considerations are referenced.
[if] Proposed text to be added:
The security considerations described in [RFC2131] and [RFC7341] are also potentially applicable to this solution. Unauthorised DHCP 4o6 servers in the network could be used to stage an amplification attack or to supply invalid configuration leading to service disruption. The risks of these types of attacks can be reduced through the use of unicast DHCP 4o6 message flows (enabled by supplying DHCP 4o6 server unicast addresses within the OPTION_DHCP4_O_DHCP6_SERVER option).

A malicious user could attempt a DoS attack by a large number of IPv4 address (or fractional address) and port sets allocations, exhausting the available addresses and port sets for other clients. This can be mitigated through DHCP 4o6 address allocation policy, limiting the number of simultaneously active IPv4 leases for clients whose request originate from each customer site.

Additional considerations are elaborated in the following sub-sections.


                             Q_10_2:
In section 10.1, I don't think you need to refer to section 2 for the target use-case. Similar to my comment Q_2_1, you should give a little more information about the DoS attack vulnerability in a shared medium.
[if] Looking at this text again (and discussing this with the authors), it's there because it was present in one of the former drafts that was combined into this document. It's actually not accurate: There isn't a denial of service attack risk from multiple clients using a single IP address on a shared medium. It doesn't work by design.
So, given that, and that a real DoS attack risk is described in the proposed text above, I suggest that section 10.1 is removed.