Re: [Gen-art] Gen-Art review of draft-holmberg-dispatch-rfc7315-updates

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 12 July 2016 11:41 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 37C7712D7BB for <gen-art@ietfa.amsl.com>; Tue, 12 Jul 2016 04:41:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Si8Z2XIaQuZ for <gen-art@ietfa.amsl.com>; Tue, 12 Jul 2016 04:41:33 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BAB1F12D0F4 for <gen-art@ietf.org>; Tue, 12 Jul 2016 04:41:32 -0700 (PDT)
X-AuditID: c1b4fb2d-f79936d0000030e4-12-5784d76a6666
Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 60.53.12516.A67D4875; Tue, 12 Jul 2016 13:41:30 +0200 (CEST)
Received: from ESESSMB208.ericsson.se ([169.254.8.19]) by ESESSHC005.ericsson.se ([153.88.183.33]) with mapi id 14.03.0294.000; Tue, 12 Jul 2016 13:41:29 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Ralph Droms <rdroms.ietf@gmail.com>, "Review Area gen-art@ietf.org Team" <gen-art@ietf.org>
Thread-Topic: [Gen-art] Gen-Art review of draft-holmberg-dispatch-rfc7315-updates
Thread-Index: AQHR1x5qs4fP6a3Fa0uRKOnNyPxeF6AUyFuA
Date: Tue, 12 Jul 2016 11:41:29 +0000
Message-ID: <D3AAAD06.BC52%christer.holmberg@ericsson.com>
References: <EDF251D1-13F4-4AB5-8489-2DDC663A9ED7@gmail.com>
In-Reply-To: <EDF251D1-13F4-4AB5-8489-2DDC663A9ED7@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.6.5.160527
x-originating-ip: [153.88.183.20]
Content-Type: multipart/alternative; boundary="_000_D3AAAD06BC52christerholmbergericssoncom_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsUyM2K7om7W9ZZwg+3HlC1WP/a1uPrqM4tF 47U+Vgdmj52z7rJ7LFnyk8njy+XPbAHMUVw2Kak5mWWpRfp2CVwZR+deYSp46VJx8NBntgbG VssuRk4OCQETiVdTPrFB2GISF+6tB7K5OIQEjjBKbLi/gAkkISSwmFHi8Bz5LkYODjYBC4nu f9ogYRGBRImzsycygoSZBeol/hzJAwkLCwRJtPzsZYIoCZZobdsPZRtJvNvaCbaKRUBVYuq2 x6wgrbwCVhJv7hRBLLKRePn8AlgJp4CtRPe902A2I9Bl30+tARvDLCAucevJfCaIiwUkluw5 zwxhi0q8fPyPFcQWFdCT+P51NlRcUeLq9OVMEFfGSyzp1gAJ8woISpyc+YRlAqPYLCRTZyFU zUJSBVFiIPH+3HxmCFtbYtnC11C2vsTGL2cZIWxribn3TjIhq1nAyLGKUbQ4tbg4N93IWC+1 KDO5uDg/Ty8vtWQTIzBOD275rbuDcfVrx0OMAhyMSjy8C+41hwuxJpYVV+YeYpTgYFYS4S27 2hIuxJuSWFmVWpQfX1Sak1p8iFGag0VJnNf/pWK4kEB6YklqdmpqQWoRTJaJg1OqgbHA7Nbj f7WpGzNa+12Cn756uJb1xtmYjGdzGO5nmFwqTFDTeqhg9X0qa6O0S2Xfm7+Sc9SYr+iXe+3O KBF9On+BnvFJhZ55LkvVL6/iVLHcXpekJeb0Vang3hyDCl3VQk9r22Pun3Wy/q6/FCuwrWCZ 5nyjb5864/5W93bfvJE8a++nzm9y1kosxRmJhlrMRcWJAMw39fnPAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/cnAw5X8D1xrcvzCKG5Io_Rx6eSg>
Cc: "draft-holmberg-dispatch-rfc7315-updates.all@tools.ietf.org" <draft-holmberg-dispatch-rfc7315-updates.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-Art review of draft-holmberg-dispatch-rfc7315-updates
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2016 11:41:35 -0000

Hi Ralph,

Thanks for your comments! Please see inline.

Minor issues:

> I had some difficulty unraveling the relationship among the text in section 3.3.2, 3.3.3, 4 and RFC 7315.  Section 3.3.2 specifies the
> inclusion of the NPLI option in the P-Access-Network-Info header field.  Section 4 does not include text about the NPLI option in the
> updates to RFC 7315, and I can't find any reference to the NPLI option in RFC 7315.  Is the intention that the text in section 3.3.2
> constitutes new Internet Standard behavior, not reflected in the update to RFC 7315, am I missing something or am I completely confused?

Sections 3.3.2 and 3.3.3 describe the 3GPP use-cases which justify the changes to RFC 7315. Section 4 defines those changes.

Section 4 then defines the changes to RFC 7315, in order to support those use-cases.

RFC 7315 (Annex A) does talk about the possibility for network provided location information, and the ABNF supports it, but the details of the network provided location information (and the other types of location information) are defined in the 3GPP specification.

> Section 3.3.3 specifies the inclusion of the IOI option in the P-Charging-Vector header field.  In this case, I am not sure if this specification represents a change to  existing text in RFC 7315 or new behavior.

Section 3.3.3 (and 3.3.2) does not update RFC 7315. Section 3.3.3 only provides the use-case/justification for the update. The update to RFC 7315 is specified in section 4.

> I would be happy to hear that I am completely confused; otherwise, I suggest some text be added to clarify that sections 3.3.2 and 3.3.3 also specify some behaviors in addition to explaining the text in section 4.

Does my clarification above clarify?


Nits/editorial comments:

> In section 3.2, it would reduce potential confusion to consistently name the header field referenced in each bullet; e.g.:
>
> OLD:
>
> o  P-Called-Party-ID: Delete statement that the header field can
>    appear in SIP responses.  Add statement that the P-Called-Party-ID
>    header field can appear in the SIP REFER method.
>
> NEW:
>
> o  P-Called-Party-ID: Delete statement that the P-Called-Party-ID
>    header field can appear in SIP responses.  Add statement that
>    the P-Called-Party-ID header field can appear in the SIP REFER method.

I’ll fix as suggested.

>Section 3.3.1:
>
>OLD:
>
>This following sections describe, for individual P- header fields,
> the 3GPP use-cases that are base for the updates.
>
>NEW:
>
> The following sections describe, for individual P- header fields,
> the 3GPP use-cases that are the basis for the updates.

I’ll fix as suggested.

> Section 3.3.2: uniformly capitalize "Network Provided Location Information".

I’ll fix as suggested.

> Section 3.3.2: 3GPP TS 23.228 needs a citation of the referenced document.

I’ll add the reference.


Thanks!

Regards,

Christer