[Gen-art] Gen-ART Telechat review of draft-ietf-ospf-prefix-link-attr-10.txt
Suresh Krishnan <suresh.krishnan@ericsson.com> Wed, 19 August 2015 02:14 UTC
Return-Path: <suresh.krishnan@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E8CA1A8A8F; Tue, 18 Aug 2015 19:14:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xg66ah4u7yYw; Tue, 18 Aug 2015 19:14:39 -0700 (PDT)
Received: from usevmg21.ericsson.net (usevmg21.ericsson.net [198.24.6.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8287E1A82E2; Tue, 18 Aug 2015 19:14:39 -0700 (PDT)
X-AuditID: c6180641-f792c6d00000686a-54-55d37d11441c
Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 71.76.26730.11D73D55; Tue, 18 Aug 2015 20:44:33 +0200 (CEST)
Received: from EUSAAMB107.ericsson.se ([147.117.188.124]) by EUSAAHC005.ericsson.se ([147.117.188.87]) with mapi id 14.03.0210.002; Tue, 18 Aug 2015 22:14:30 -0400
From: Suresh Krishnan <suresh.krishnan@ericsson.com>
To: "draft-ietf-ospf-prefix-link-attr.all@ietf.org" <draft-ietf-ospf-prefix-link-attr.all@ietf.org>, General Area Review Team <gen-art@ietf.org>
Thread-Topic: Gen-ART Telechat review of draft-ietf-ospf-prefix-link-attr-10.txt
Thread-Index: AdDaJMe7pHezg0kRTXmNmM5Vd6JL2A==
Date: Wed, 19 Aug 2015 02:14:30 +0000
Message-ID: <E87B771635882B4BA20096B589152EF63A8CE253@eusaamb107.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsUyuXRPuK5g7eVQg/0/pS3efueyuPrqM4sD k8eSJT+ZAhijuGxSUnMyy1KL9O0SuDKO3FMveCJQsfDeZsYGxuu8XYwcHBICJhJP90d3MXIC mWISF+6tZ+ti5OIQEjjKKPHr8xJWCGc5o8SVF8sZQarYgBo27PzMBGKLCExhlHh/GywuLOAt 8f9rByNEPEji5f9VULaexIL3f9lBbBYBVYk3P9rA4rwCvhLbX34Em8MItPn7qTVgNrOAuMSt J/OZIC4SkFiy5zwzhC0q8fLxP1YIW0ni4+/57BD1OhILdn9ig7C1JZYtfM0MMV9Q4uTMJywT GIVnIRk7C0nLLCQts5C0LGBkWcXIUVqcWpabbmS4iREYzsck2Bx3MC74ZHmIUYCDUYmHd0HR 5VAh1sSy4srcQ4zSHCxK4rzSfnmhQgLpiSWp2ampBalF8UWlOanFhxiZODilGhhXXDghef7L WueXIqHT9tlfEd7BzMqb3P4u11ckeGJUliD/fO4VyS7etzRWLo+0VitQWvDTNOVhZmxUcOrd /v7/vpe3cTeuNFi6asu+rKx91xetOsj/uiusLDLnOFv+jQfMVfIrzmfrxN+P3Gjr62s/7dOu Y2m1U/Mk1tyRWmV58dXytOtdqe+UWIozEg21mIuKEwEgopsDSAIAAA==
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/csM_k7LcAMxUjWwyjYOGArRLNTk>
Subject: [Gen-art] Gen-ART Telechat review of draft-ietf-ospf-prefix-link-attr-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2015 02:14:41 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-ospf-prefix-link-attr-10.txt Reviewer: Suresh Krishnan Review Date: 2015/08/18 IESG Telechat date: 2015/08/20 Summary: The draft is almost ready for publication as Proposed Standard but there are some minor issues that need to be addressed as stated in my last call review. We are on the process of converging on the fixes by email. * Section 2 * In the packet format described in Figure "OSPFv2 Extended Prefix Opaque LSA" the numbers 9, 10 and 11 are shown in a field. I think it would be better if these are replaced by the text "LS type" as it is the actual field. This will provide consistency with the rest of the figure. The following text can then describe the allowed LS types as 9,10, and 11. s/differential/differentiate/ * Padding of TLVs. I am assuming that the TLVs are padded using zero octets. If so, please state it explicitly. * Section 2.1. * In the packet format the "Address Prefix" field is marked as variable length when it actually *is not*. It is always encoded as 32 bits long, right? If so please the "(variable)" designation needs to be removed for the Address Prefix. * Shouldn't there be some IANA instructions for further extensions to the Flags field in the OSPFv2 Extended Prefix TLV? Or is this field not expected to be extended? * IANA Considerations * The Opaque LSA Options types used by this document (7 & 8) seem to be wrongly entered into the IANA registry and are pointing to [draft-ietf-ospf-segment-routing-extensions] instead of this draft. It is probably worth taking this up during the IANA check. Thanks Suresh
- [Gen-art] Gen-ART Telechat review of draft-ietf-o… Suresh Krishnan
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Acee Lindem (acee)
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Suresh Krishnan
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Acee Lindem (acee)
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Jari Arkko