Re: [Gen-art] Review of draft-ietf-mmusic-msid-13
Jari Arkko <jari.arkko@piuha.net> Thu, 16 June 2016 06:04 UTC
Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 824B112D115; Wed, 15 Jun 2016 23:04:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.326
X-Spam-Level:
X-Spam-Status: No, score=-3.326 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.426] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zAwzHDTnMncy; Wed, 15 Jun 2016 23:04:37 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 7875612D1A9; Wed, 15 Jun 2016 23:04:36 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id E20F62CEF0; Thu, 16 Jun 2016 09:04:34 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mj1Y66x2FIG0; Thu, 16 Jun 2016 09:04:34 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 05BDD2CECE; Thu, 16 Jun 2016 09:04:34 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_08646ADD-93E4-475B-82A1-8891970840B6"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.2
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <74EA3075-7D73-406E-BAFE-95EFED61DF95@cisco.com>
Date: Thu, 16 Jun 2016 09:04:30 +0300
Message-Id: <7489D826-29E6-43CD-9E82-63B19E83FC42@piuha.net>
References: <2AAAC8A1-2B21-443B-88E8-FE2617DA6C82@cisco.com> <1EAC760B-D06E-46BC-A285-7C8DD23AC172@piuha.net> <74EA3075-7D73-406E-BAFE-95EFED61DF95@cisco.com>
To: "Matt Miller (mamille2)" <mamille2@cisco.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/dEyP1MCh7E9bM9JPXC2gT5kQcqE>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mmusic-msid.all@ietf.org" <draft-ietf-mmusic-msid.all@ietf.org>
Subject: Re: [Gen-art] Review of draft-ietf-mmusic-msid-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2016 06:04:39 -0000
Thank you for checking - authors do note the two new ones below: On 16 Jun 2016, at 01:37, Matt Miller (mamille2) <mamille2@cisco.com> wrote: > -14 addressed all of my previous nits. I just noticed one nit in -14: > > * In Section 3. "Procedures", "si2gnal" should be "signal". > > There is one outdated reference (draft-ietf-mmusic-sdp-bundle-negotiation, -29 vs -30), that I assume will be addressed before publication. > > > - m&m > > Matt Miller > Cisco Systems, Inc. > > > >> On Jun 15, 2016, at 4:05 PM, Jari Arkko <jari.arkko@piuha.net> wrote: >> >> Thanks! Were these comments noted by the authors? Or possibly even addressed in -14? >> >> Jari >> >> On 25 May 2016, at 03:29, Matt Miller (mamille2) <mamille2@cisco.com> wrote: >> >>> I am the assigned Gen-ART reviewer for this draft. The General Area Review >>> Team (Gen-ART) reviews all IETF documents being processed by the IESG for >>> the IETF Chair. Please treat these comments just like any other last call >>> comments. >>> >>> For more information, please see the FAQ at >>> >>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >>> >>> Document: draft-ietf-mmusic-msid-13 >>> Reviewer: Matthew A. Miller >>> Review Date: 2016-05-24 >>> IETF LC End Date: 2016-05-24 >>> IESG Telechat date: N/A >>> >>> Summary: >>> >>> This document is ready for publication as a Proposed Standard once >>> some minor editorial nits are address. >>> >>> Major issues: NONE >>> >>> Minor issues: NONE >>> >>> Nits/editorial comments: >>> >>> * idnits is complaining that something smells of code that isn't bounded. >>> However, I think it is clear that the "suspicious text" is the detailed >>> SDP example, and is already clearly noted as such. >>> >>> * idnits warns of a number of outdated references, which I assume will >>> be updated with the next revision of this document or by the RFC Editor: >>> >>> - draft-ietf-mmusic-sdp-mux-attributes-02 >>> - draft-ietf-rtcweb-jsep-07 >>> - draft-ietf-mmusic-sdp-bundle-negotiation-07 >>> - draft-ietf-rtcweb-overview-10 >>> >>> * In Section 1.1. "Structure Of This Document", there is a spacing issue >>> in "WebRTC[I-D.ietf-rtcweb-overview] ." >>> >>> * In Section 2. "The Msid Mechanism", there is an extra "." in >>> "... defined in [W3C.WD-webrtc-20150210]., and to ...". >>> >>> * In Section 3.1. "Handling of non-signalled tracks", some of the >>> phrasing in the third paragraph seems awkward to me. Might I suggest >>> the following instead: >>> >>> When MSID is used, the only time this can happen is when, after the >>> initial negotiation, a negotiation is performed where the answerer >>> adds a MediaStreamTrack to an already established connection and >>> starts sending data before the answer is received by the offerer. >>> For initial negotiation, packets won't flow until the ICE candidates >>> and fingerprints have been exchanged, so this is not an issue. >>> >>> * Also in Section 3.1. "Handling of non-signalled tracks", I think the >>> sentence after the bullet list ought to be split in two between "entered" >>> and "If": >>> >>> The process above may involve a considerable amount of buffering >>> before the stable state is entered. If the implementation wishes to >>> limit this buffering, it MUST signal to the user that media has been >>> discarded. >>> >>> _______________________________________________ >>> Gen-art mailing list >>> Gen-art@ietf.org >>> https://www.ietf.org/mailman/listinfo/gen-art >> >
- Re: [Gen-art] Review of draft-ietf-mmusic-msid-13 Jari Arkko
- Re: [Gen-art] Review of draft-ietf-mmusic-msid-13 Matt Miller (mamille2)
- Re: [Gen-art] Review of draft-ietf-mmusic-msid-13 Jari Arkko
- [Gen-art] Review of draft-ietf-mmusic-msid-13 Matt Miller (mamille2)