Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
"Andrew G. Malis" <agmalis@gmail.com> Tue, 03 November 2015 05:21 UTC
Return-Path: <agmalis@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A75671ACDCB; Mon, 2 Nov 2015 21:21:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPQR1CHeOBWV; Mon, 2 Nov 2015 21:21:03 -0800 (PST)
Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8DF661B2E15; Mon, 2 Nov 2015 21:20:55 -0800 (PST)
Received: by wicll6 with SMTP id ll6so4348913wic.1; Mon, 02 Nov 2015 21:20:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Jr3BFcc/r+xJ7hBF1nMvzgPy0fZ5TVTxEdEFJgG23Ys=; b=yHkOMdMH53h8NNvx46t56dnXNO6cNmQXYr4aCUKddlVr5869DeCXsTbTjV5V+/9thA rlVGDTaVOBzuVir4GKpiAlg455x+qQ5PoavAZbR33RKEog/zHJd6Ltznhit0Svc0/Qij T5HsJIgFvJPgYhx3gL89F1ah5Ue8SZv6Qu6htSTbS4mv+c2M5DzXKvm5BA7GWutRf+xq 4acA9rW3TktJDjQKVlxDfN22SsloiVsaPfOzQuV3OZs2bPB4uOJzPn8zlifo/o7FuOtd 201zgEXy3YAWCdy0eXJ3CJMJAsI2w8sMVCJjP7d9zBJ2jPxCXtb2Zwsn6zQXljkxHglK T84g==
X-Received: by 10.194.242.106 with SMTP id wp10mr27487579wjc.116.1446528054148; Mon, 02 Nov 2015 21:20:54 -0800 (PST)
MIME-Version: 1.0
Received: by 10.28.195.10 with HTTP; Mon, 2 Nov 2015 21:20:34 -0800 (PST)
In-Reply-To: <40746B2300A8FC4AB04EE722A593182B9C821650@ONWVEXCHMB04.ciena.com>
References: <095AB7C0-C1B7-4963-852C-A5A613AD261A@cisco.com> <40746B2300A8FC4AB04EE722A593182B9ACC4AF3@ONWVEXCHMB04.ciena.com> <D98030BB-32EB-4859-A71B-8D54BDBF031C@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C37860E@ONWVEXCHMB04.ciena.com> <2F4FBE17-D7D8-4B96-AB1C-8ACFE48B2630@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C378941@ONWVEXCHMB04.ciena.com> <CAA=duU0Jeva2=1CdKxW3D3wHonFnWv7JpwWkyD6ORePzQfmSYg@mail.gmail.com> <40746B2300A8FC4AB04EE722A593182B9C3789B3@ONWVEXCHMB04.ciena.com> <8D144BAF-E93F-4BCE-A940-E1AB48947C12@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C8214D6@ONWVEXCHMB04.ciena.com> <CAA=duU0mo36DokhcTBkU2ZVFS=O6mCR32JVe27a9yzV1pkKzWw@mail.gmail.com> <40746B2300A8FC4AB04EE722A593182B9C821650@ONWVEXCHMB04.ciena.com>
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Tue, 03 Nov 2015 14:20:34 +0900
Message-ID: <CAA=duU2ZQqBnmGZFTS-bijgLT62rRZspjPPxTepcysXp4pA0fQ@mail.gmail.com>
To: "Shah, Himanshu" <hshah@ciena.com>
Content-Type: multipart/alternative; boundary="089e0141a1c8d3469e05239c0ef4"
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/dIB05pQNz-2vX97Q6AahSJosm5U>
Cc: General Area Review Team <gen-art@ietf.org>, "Alia Atlas <akatlas@gmail.com> (akatlas@gmail.com)" <akatlas@gmail.com>, "draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org" <draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org>, The IESG <iesg@ietf.org>, "Ralph Droms (rdroms)" <rdroms@cisco.com>
Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 05:21:06 -0000
Himansu, Looks great to me, thanks. Ralph and Alia, Please review the updates. Thanks, Andy On Tue, Nov 3, 2015 at 1:49 PM, Shah, Himanshu <hshah@ciena.com> wrote: > *Ok, I updated the section. Please review.* > > > > *Thanks,* > > *Himanshu* > > > > *From:* Andrew G. Malis [mailto:agmalis@gmail.com] > *Sent:* Tuesday, November 03, 2015 1:24 PM > *To:* Shah, Himanshu > *Cc:* Ralph Droms (rdroms); A. Jean Mahoney; Alia Atlas <akatlas@gmail.com> > (akatlas@gmail.com); General Area Review Team; > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG > > *Subject:* Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd > > > > Himanshu, > > > > Section 6.2 isn’t quite right yet. Here’s some suggested text instead: > > > > 6.2. Sequence Number TLV > > > > This document requests IANA to assign a new TLV Type (requested value > > 0x0001) from the existing LDP "TLV Type Name Space" registry. The > > description for the new TLV Type is "Sequence Number TLV”. > > > > Note to IANA (TO BE REMOVED BY THE RFC EDITOR): This registration should > > take place at the following location: > > http://www.iana.org/assignments/ldp-namespaces/ldp-namespaces.xhtml]. In > > an earlier revision of this draft, we created a new sub-TLV registry > > with one entry, a new "Sequence Number TLV" with the value 0x0001. This > > has been implemented by several vendors. The IESG proposed that rather > > than create a new sub-TLV registry, we simply allocate a new TLV Type from > > the existing LDP "TLV Type Name Space" registry. In this registry, the > > value 0x0001 is available for allocation by standards action, so we > > request this code point for the new "Sequence Number" TLV type to avoid > > needing to change the existing implementations. > > > > > > Cheers, > > Andy > > > > > > > > On Tue, Nov 3, 2015 at 4:24 AM, Shah, Himanshu <hshah@ciena.com> wrote: > > Hi Ralph and Alia - > > Ralph - I have replace the sequence number/mac withdraw sub-TLV > registration, > Section with request for the value 0x0001 from the LDP's TLV type name > space. > Please review and verify that it addresses your concern. > > Alia - I have also addressed your concern by replacing the original text > with > Steve Bryant's offered text (which you stated you were OK with). Please > review, > verify and accept by removing "DISCUSS" on this draft review. > > Thanks, > Himanshu > > -----Original Message----- > From: Shah, Himanshu > Sent: Monday, October 26, 2015 7:05 PM > To: 'Ralph Droms (rdroms)' > Cc: Andrew G. Malis; A. Jean Mahoney; General Area Review Team; > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG > Subject: RE: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd > > Hi Ralph - > > You make a good point on the sub-TLV. > I have talked to my WG chairs and we are going to change the text based on > your suggestion. > I will remove the MAC Withdraw sub-TLV registry for sequence number TLV > and instead use the Value from the LDP Type values (same as MAC List TLV). > > As for combining text of section 3 and 4.1. > > Section 3 described the packet fields, including the sequence number text. > The reason for sequence number text is - that it is applicable to both; > Sender (section 4.1) and Receiver (section 4.2). > > I will explore to remove the overlap.. > > Thanks, > Himanshu > > > -----Original Message----- > From: Ralph Droms (rdroms) [mailto:rdroms@cisco.com] > Sent: Monday, October 26, 2015 3:13 PM > To: Shah, Himanshu > > Cc: Andrew G. Malis; A. Jean Mahoney; General Area Review Team; > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG > Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd > > Himanshu - I've been tied up in meetings most of the day today and am > about to go into more meetings that will last until the end of the day. > > I reviewed your revised draft briefly and it mostly looks OK. I have one > substantive comment, which is about an issue I didn't notice until now: > > How is the Mac Withdraw sub-TLV registry from which the "Sequence Number" > code point is taken differentiated from the LDP Parameters sub-TLV registry > from which the "MAC List" and "MAC Flush Parameter" code points are taken? > In other words, how does the receciver know to interpret the code point on > the Sequence Number TLV as a code point in the Mac Withdraw sub-TLV > registry while the code points on the MAC List TLV and the MAC Flush > Paramter TLV are interpreted as code points in the LDP Paramteres sub-TLV? > Shouldn't all the code points on the TLVs in this message come from a > single registry? > > I also have an editorial comment from my earlier review: the ifrst > paragraph of section 3 is mostly redundant with section 4.1 and that text > in section 3 should be merged into the text in section 4.1 > > - Ralph > > > On Oct 26, 2015, at 2:09 PM 10/26/15, Shah, Himanshu <hshah@ciena.com> > wrote: > > > > Thanks Andy. > > He did re-send the email without MIME and I was able to read and reply. > > > > Thanks, > > Himanshu > > > > From: Andrew G. Malis [mailto:agmalis@gmail.com] > > Sent: Monday, October 26, 2015 2:08 PM > > To: Shah, Himanshu > > Cc: Ralph Droms (rdroms); A. Jean Mahoney; General Area Review Team; > > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG > > Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd > > > > Himanshu, > > > > Ralph said: > > > > Himanshu - I've received your revised draft. I've been stuck in a > variety of meetings Monday and haven't had time to review it. I should be > able to look at it before the end of the day. > > > > - Ralph > > > > On Mon, Oct 26, 2015 at 1:04 PM, Shah, Himanshu <hshah@ciena.com> wrote: > > Can you send the email without MIME signature? > > > > Thanks, > > Himanshu > > > > From: Ralph Droms (rdroms) [mailto:rdroms@cisco.com] > > Sent: Monday, October 26, 2015 1:02 PM > > To: Shah, Himanshu > > Cc: A. Jean Mahoney; General Area Review Team; > > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG > > Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd > > >
- [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Jari Arkko
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Andrew G. Malis
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Ralph Droms (rdroms)
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Andrew G. Malis
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Andrew G. Malis
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Alia Atlas
- Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac… Shah, Himanshu