From: "Roni Even (A)" <roni.even@huawei.com>
To: "Black, David" <David.Black@dell.com>, Roni Even <ron.even.tlv@gmail.com>,
  "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "detnet@ietf.org"
 <detnet@ietf.org>, "draft-ietf-detnet-ip.all@ietf.org"
 <draft-ietf-detnet-ip.all@ietf.org>
Thread-Topic: [Detnet] Genart last call review of draft-ietf-detnet-ip-05
Thread-Index: AQHV9iEfrvzeNKPz5UimJkvyiID576hA4UVAgAChaHA=
Date: Tue, 10 Mar 2020 08:40:50 +0000
Message-ID:
 <6E58094ECC8D8344914996DAD28F1CCD27DB2636@dggemm526-mbx.china.huawei.com>
References: <158376501185.5507.4470173275140890090@ietfa.amsl.com> 
 =?utf-8?q?=3CMN2PR19MB40450DAF56072EDC65926A0683FE0=40MN2PR19MB4045=2Enampr?=
 =?utf-8?q?d19=2Eprod=2Eoutlook=2Ecom=3E?=
In-Reply-To: =?utf-8?q?=3CMN2PR19MB40450DAF56072EDC65926A0683FE0=40MN2PR19MB?=
 =?utf-8?q?4045=2Enamprd19=2Eprod=2Eoutlook=2Ecom=3E?=
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At:
 <https://mailarchive.ietf.org/arch/msg/gen-art/dVjEV6dlhqXxEPupgnRJDRqPGbM>
Subject: Re: [Gen-art] [Detnet] Genart last call review of
 draft-ietf-detnet-ip-05
Precedence: list

Hi David,
Thanks, the new text is clearer
Roni

> -----Original Message-----
> From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Black, David
> Sent: Tuesday, March 10, 2020 1:20 AM
> To: Roni Even; gen-art@ietf.org
> Cc: Black, David; last-call@ietf.org; detnet@ietf.org; draft-ietf-detnet-
> ip.all@ietf.org
> Subject: Re: [Gen-art] [Detnet] Genart last call review of draft-ietf-det=
net-ip-05
>=20
> Hi Roni,
>=20
> Inline ...
>=20
> Thanks, --David
>=20
> > -----Original Message-----
> > From: detnet <detnet-bounces@ietf.org> On Behalf Of Roni Even via
> > Datatracker
> > Sent: Monday, March 9, 2020 10:44 AM
> > To: gen-art@ietf.org
> > Cc: last-call@ietf.org; detnet@ietf.org;
> > draft-ietf-detnet-ip.all@ietf.org
> > Subject: [Detnet] Genart last call review of draft-ietf-detnet-ip-05
> >
> >
> > [EXTERNAL EMAIL]
> >
> > Reviewer: Roni Even
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed by
> > the IESG for the IETF Chair.  Please treat these comments just like
> > any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> >
> > Document: draft-ietf-detnet-ip-??
> > Reviewer: Roni Even
> > Review Date: 2020-03-09
> > IETF LC End Date: 2020-03-13
> > IESG Telechat date: Not scheduled for a telechat
> >
> > Summary: The document is ready for publication as a standard track RFC
> > with nits
> >
> > Major issues:
> >
> > Minor issues:
> >
> > Nits/editorial comments:
> >
> > 1. In section 3 the paragraph before the last one " the appropriate
> > DetNet flow-specific information and ensures that the receives the
> > proper traffic treatment within the domain", looks to me that it
> > should be "that the flow receives ..."
> [David>] That looks like what was intended.
>=20
> >
> > 2.  In section 6  I could not parse the second level bullet "When the
> > DSCP field is used in flow identification, a list of field values that
> > may be used by a specific flow."
> [David>] The text after the comma is intended to describe the management =
and
> control information used to identify the flow, referring back to the DSCP=
 field.
>=20
> As I'm responsible for this DSCP list "thorn" in the WG's "side" ;-), her=
e's a
> suggestion to improve clarity:
>=20
> OLD
>       *  If the DSCP field is to be used in flow identification.
>          Ignoring the DSCP filed is optional.
>=20
>       *  When the DSCP field is used in flow identification, a list of
>          field values that may be used by a specific flow.
> NEW
>       *  Whether or not the DSCP field is used in flow identification.
>           Use of the DSCP field for flow identification is optional.
>=20
>       *  If the DSCP field is used to identify a flow, then the flow
>           identification information (for that flow) includes a list of
>           DSCPs used by that flow.
>=20
> I took out "that may be used" as including too much detail - that text co=
vers
> situations where not all of the DSCP values are actually used, e.g., ther=
e could be
> 5 possible DSCP values for a flow, but only 2 of them occur in actual pac=
kets.
> That's not particularly important here, as the logic that determines whet=
her or
> not a packet is part of that flow has to match on all 5 possible DSCP val=
ues.
>=20
> >
> >
> >
> > _______________________________________________
> > detnet mailing list
> > detnet@ietf.org
> > https://www.ietf.org/mailman/listinfo/detnet
>=20
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art