Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Alissa Cooper <alissa@cooperw.in> Thu, 13 August 2020 00:50 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC78D3A1518; Wed, 12 Aug 2020 17:50:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=MqSWAw3q; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=etKox4tK
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BZYdAuXgjst9; Wed, 12 Aug 2020 17:50:39 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 182E23A0DEE; Wed, 12 Aug 2020 17:50:39 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5A8BE5C0131; Wed, 12 Aug 2020 20:50:38 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 12 Aug 2020 20:50:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=w ++89yzRwlWt8G9hBctT95ifvyXdoXeg4KMIdNzIGbA=; b=MqSWAw3qpCmm5I/bS 2xM2jTUQFSHh2+Pn3qouEIGihORJyV+5YR/SMmocKHmdYY+WJNt1Po0LARNdgbZU ofyDCV4H8Le82qo2xjjRbxBhdEN82kfAPMLyj9S/ueDJkOoTU+x8AjSUzqdcy3+J 5lAARl8ijMbxaI2A9qdDXxj9+fX0tLaJSOCOjt81QIPMLDvPgXWJvT3uvugsKkfs lSfJok8p0Zn6m2DX/5wHWITJY3NnQrnnBDaHyMx83S5i1+uwTQyClQuPxAu437Ce l6mWZXkLuHM6u0DzS0yhHTo+0o9hoX6wmdcSn7Mi+GerPHUlnXu8PadJQeF2B4H/ 9ahpw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=w++89yzRwlWt8G9hBctT95ifvyXdoXeg4KMIdNzIG bA=; b=etKox4tK5dq/Gc5Z3bxmF1xpcG6cI/KdCk0Wh9wcCQH/mjFPEuxG37G18 MI9n4UYPqqCWN8oGdsBWpwyH3tWWEsB7FkdY8Be/bC6R6cFWRq09B1SdwVBYWKG9 /yDVxImQh6KV6tdmHISQClK39l8hyjckrDH8cBQdPABJ2343+chtW/RIBxsoKBHm jz9sYG1aXzMBj95NJ6N7QkcDsAINSMScjsqrtBvLS3dLVDTK1YwXA2MydZAxNPRR qX87DEl14H4egAZ6k8KQ5TXXFKx6RQsKyaWLosIhoMkm07hNtKTuLLxtLPZYjXKx npFOBc+F9ICv9x+36Uwv9a7UN8jug==
X-ME-Sender: <xms:XY40X5UW1wbiaoz0HVHqVpsSZCk6jGLRYV6JF3IhAgc1sIFFe8zQmA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrleefgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuggftrfgrth htvghrnhepgfeutdektefhkeelheehteehvdekkeettddvvdejgffhieekffeggeevfeeu gedtnecuffhomhgrihhnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrd eikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegr lhhishhsrgestghoohhpvghrfidrihhn
X-ME-Proxy: <xmx:XY40X5mXMHfMfXvmWhFb5rZP8KP63Tdx9RfvBd-W4iidHaoEcXTQJg> <xmx:XY40X1ZaUM4tgvUMWxxPTNuqiiEIi1gPba_hj4BB76snQIF7RDbSEQ> <xmx:XY40X8UmiykigTvg22eK8HkcIXtQ75SApfYjRWihjfDFo0dWmRjqyA> <xmx:Xo40X4w_5NlIrQyWUHsdVzj4FfKtDrPDL5ZAn4_f1Fw2bQkq4xwSRA>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.68]) by mail.messagingengine.com (Postfix) with ESMTPA id E7A8A3060067; Wed, 12 Aug 2020 20:50:36 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <1f035833-3efe-3444-3387-1c8feac48538@gmail.com>
Date: Wed, 12 Aug 2020 20:50:36 -0400
Cc: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D2525A5A-F7E8-45AD-9B5D-8C6BB31F31DA@cooperw.in>
References: <159459362316.14150.6160122631877971567@ietfa.amsl.com> <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com> <1f035833-3efe-3444-3387-1c8feac48538@gmail.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/e5vX1pcDqhenrZB4CebJsy2X6QY>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2020 00:50:41 -0000

Brian, thanks for your review. Christer, thanks for addressing Brian’s comments. I entered a No Objection ballot.

Alissa


> On Jul 13, 2020, at 4:51 PM, Brian E Carpenter <brian.e.carpenter@gmail.com> wrote:
> 
> Thanks Christer, that all looks good to me,
> 
> Regards
>   Brian
> 
> On 13-Jul-20 20:58, Christer Holmberg wrote:
>> Hi Brian,
>> 
>> Thank You for the review! Please see inline.
>> 
>> 
>> Nits:
>> -----
>> 
>>>> 4.1.  MSRP URI
>>>> ....
>>>>    transport  /= "dc"
>>>> 
>>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>> 
>>>>    transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>> 
>>> The advantage of listing out
>>> 
>>> transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>> 
>>> would be that the reader sees the full list.
>> 
>> The MMUSIC WG has previously decided to take the approach of only writing the new value, using the "/=" format.
>> 
>> ---
>> 
>>>>                 ; Add "dc" to existing transports per [RFC4975]
>>>> 
>>>> I suggest
>>>> 
>>>>                ; Add "dc" to existing transports per Section 9 of [RFC4975]
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 4.6.  Session Closing
>>>> 
>>>>  The SDP answerer must ensure that no dcmap or dcsa attributes are
>>>>  present in the SDP answer if no corresponding attributes are present
>>>>  in the received SDP offer.
>>>> 
>>>> Should that be MUST?
>> 
>> The reason for "must" is that is referring to generic data channel SDP O/A procedures.
>> 
>> I suggest to remove the paragraph.
>> 
>> ---
>> 
>>>> B2BUA
>>>> 
>>>> Define the acronym please.
>> 
>> We normally don't do that in MMUSIC specifications. Also, it is on the IETF list of well-known acronyms.
>> 
>> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back User Agent (B2BUA)'
>> 
>> ---
>> 
>>>> 9.2.  Subprotocol Identifier MSRP
>>>> 
>>>>  A reference to this document is added to the subprotocol identifier
>>>>  "msrp" in the "WebSocket Subprotocol Name Registry"
>>>> 
>>>> s/this document/RFCXXXX/
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 11.  CHANGE LOG
>>>> 
>>>> Mark this section for deletion by the RFC Editor
>> 
>> I think the RFC Editor will delete it by default, but we can add explicit text.
>> 
>> Regards,
>> 
>> Christer
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art