Re: [Gen-art] Gen-ART Telechat review: draft-ietf-tls-dtls-heartbeat-03.txt

Michael Tuexen <tuexen@fh-muenster.de> Fri, 28 October 2011 16:12 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B64C621F8B1A for <gen-art@ietfa.amsl.com>; Fri, 28 Oct 2011 09:12:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L538swAKNcsw for <gen-art@ietfa.amsl.com>; Fri, 28 Oct 2011 09:12:19 -0700 (PDT)
Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) by ietfa.amsl.com (Postfix) with ESMTP id DE82221F8AFE for <gen-art@ietf.org>; Fri, 28 Oct 2011 09:12:17 -0700 (PDT)
Received: from [192.168.1.200] (p508FD754.dip.t-dialin.net [80.143.215.84]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id A46341C0C0BEA; Fri, 28 Oct 2011 18:12:15 +0200 (CEST)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset="iso-8859-1"
From: Michael Tuexen <tuexen@fh-muenster.de>
In-Reply-To: <CAHBDyN5L9a6UY6seczmw=S_Wmu3YwZnbJ+dhtqw2D95ZEqva=Q@mail.gmail.com>
Date: Fri, 28 Oct 2011 18:12:14 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <A6BADDAE-B891-4A1B-B832-E4438C294730@fh-muenster.de>
References: <CAHBDyN5L9a6UY6seczmw=S_Wmu3YwZnbJ+dhtqw2D95ZEqva=Q@mail.gmail.com>
To: Mary Barnes <mary.ietf.barnes@gmail.com>
X-Mailer: Apple Mail (2.1251.1)
Cc: gen-art@ietf.org, draft-ietf-tls-dtls-heartbeat.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART Telechat review: draft-ietf-tls-dtls-heartbeat-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Oct 2011 16:12:19 -0000

Mary,

thank you very much for the review.
See my comments in-line.

Best regards
Michael

On Oct 28, 2011, at 5:56 PM, Mary Barnes wrote:

> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
> 
> Document: draft-ietf-tls-dtls-heartbeat-03.txt
> Reviewer:  Mary Barnes 
> Review Date:  28 Oct 2011
> IETF LC Date:  18 Oct 2011   
> IESG Telechat Date:  3 Nov 2011
> 
> Summary:  Ready with editorial comments
> 
> Editorial:  
> 
> 1) Section 2 (1st P, last sentence).  The following sentence needs some work (there's a missing noun before the SHOULD) - I suggest something like the following:
> OLD:
> If an endpoint has indicated peer_not_allowed_to_send and receives a
> HeartbeatRequest message SHOULD drop the message silently and MAY
> send an unexpected_message Alert message.
> 
> NEW:
> If an endpoint that has indicated peer_not_allowed_to_send receives a HeartbeatRequest message, the endpoint SHOULD drop the message silently and MAY send an unexpected_message Alert message.
I agree. I made the change in our CVS version, so the change will be
included in the next revision.
> 
> 2) Section 3: Should the "has to be" in this sentence be a MUST? 
>    Whenever a HeartbeatRequest message is
>    received, it has to be answered with a corresponding
>    HeartbeatResponse message.
I think SHOULD is better since the next sentences describe exceptions.
I changed it to SHOULD in CVS. If this change is not OK for you,
please let me know.

Again: Thank you very much for the comments.