[Gen-art] Genart last call review of draft-ietf-ipsecme-split-dns-12

Christer Holmberg <christer.holmberg@ericsson.com> Fri, 17 August 2018 06:25 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C2C01130E2E; Thu, 16 Aug 2018 23:25:55 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: gen-art@ietf.org
Cc: ipsec@ietf.org, draft-ietf-ipsecme-split-dns.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.83.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153448715569.12184.4843735916628840351@ietfa.amsl.com>
Date: Thu, 16 Aug 2018 23:25:55 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/eT3D-BMKujx0U1BiuvfmVCzlm9g>
Subject: [Gen-art] Genart last call review of draft-ietf-ipsecme-split-dns-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.27
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Aug 2018 06:25:56 -0000

Reviewer: Christer Holmberg
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ipsecme-split-dns-12
Reviewer: Christer Holmberg
Review Date: 2018-08-16
IETF LC End Date: 2018-08-24
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well written, and almost ready for publication. I have
a couple of questions that I would like the authors to address.

Major issues: N/A

Minor issues:

Q1:

Section 3.1 contains some SHOULD-do statements, e.g.,:

"the initiator SHOULD also include one or more INTERNAL_IP4_DNS and
INTERNAL_IP6_DNS attributes in the CFG_REQUEST"

"the initiator SHOULD also include one or more INTERNAL_DNS_DOMAIN attributes
in the CFG_REQUEST."

Is there a reason for not using MUST instead of SHOULD?

Q2:

Section 3.2 says:

"the initiator SHOULD behave as if Split DNS configurations are not supported
by the server."

Again, is there a reason for not using MUST?

Nits/editorial comments:

Q3:

Is there a need for the "Background" section? Since the text is related to what
is described in the "Introduction", could the the text be moved there?