IETF Logo Mail Archive

[Gen-art] Gen-ART telechat review of draft-ietf-l3sm-l3vpn-service-model-17

Brian E Carpenter <brian.e.carpenter@gmail.com> Fri, 21 October 2016 03:41 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56CE51294AA; Thu, 20 Oct 2016 20:41:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ns2WMyJX4_6I; Thu, 20 Oct 2016 20:41:41 -0700 (PDT)
Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01EEC12941D; Thu, 20 Oct 2016 20:41:39 -0700 (PDT)
Received: by mail-pf0-x229.google.com with SMTP id 128so48741075pfz.0; Thu, 20 Oct 2016 20:41:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:organization:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=aBXhqMBhv55LCWDpaZCGbfFIVksybA2xlKP91BylQ5Y=; b=uIHymlGMt9nwmInA5XrlJDO41iF8IBtkek6wNFhFjGL/Hmd3hz4y7MtGh/aZSrUfdU +Dzs54VnNzve9OaSVDHQLjNC9sW9SYzWw+rQFyiUUDBPrNyGwS+eqI8pqcwTOF2BpUgr wc2HQ4VT5ovOwpXjlPaVbINa+t46s9EdsSf2ZqcecDwe268P5xGlBSiS5rP9bsDk0gH3 fp7Aj0LAw0+teLV/vRmt+5OVhH91VFAriwV9/+TXTGTHW/0vvZmcaaA3UgEeRZGTRfp/ X7rNsxHld9BxLKdmUeOvRnHENA1qvA2fsRbNILLFzy9Q7fXLwKYeggG0+4g0sxBPlM51 USGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:organization:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=aBXhqMBhv55LCWDpaZCGbfFIVksybA2xlKP91BylQ5Y=; b=VyIjd0j6OAD6zkLTWghSbAT2t0Xj24qGzyFoJ14FM3blkLdNp5ddsIVcQtQqvHAy0u +B1ZNEWDFqat5g5ww/uWWBS9cNe0NfPwC1LfhJ5EXASoEfBVCmYP2KC/sM8v6LnwY+hd ILHoNLWk6kpJKbOjOj3LkiSmssCQcysKBRsaSSttOYCDp+H4xMpSz2fP9gaCMdhgtWdo xFVtedwtxuMnUWy2brA6e/ZxHfls6K41QufVgKQYUOIJrs9pWnNvlNdHBAhNLN52dwk2 LBeRRtNNZW2IUiIIDXOFtW6k26xoo7TbMor07ww5YzFFpv/8kWh0kyleEucTU77bxcSq EqXA==
X-Gm-Message-State: AA6/9RlpTF7oatHBfWBqOOJDiFVHrpJUoVNkILI4yI8IH/+HjF8/TISnpT9OC1XKCKbOLw==
X-Received: by 10.98.75.8 with SMTP id y8mr7488303pfa.30.1477021299301; Thu, 20 Oct 2016 20:41:39 -0700 (PDT)
Received: from [192.168.178.23] (214.218.69.111.dynamic.snap.net.nz. [111.69.218.214]) by smtp.gmail.com with ESMTPSA id z87sm530660pfk.67.2016.10.20.20.41.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 20:41:38 -0700 (PDT)
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
To: draft-ietf-l3sm-l3vpn-service-model.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Organization: University of Auckland
Message-ID: <bcc0cc8c-03d7-2489-93a7-447899741c04@gmail.com>
Date: Fri, 21 Oct 2016 16:41:45 +1300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/egNYyl8ttZGrLITMYIaeSEfkmAo>
Subject: [Gen-art] Gen-ART telechat review of draft-ietf-l3sm-l3vpn-service-model-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Oct 2016 03:41:42 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-l3sm-l3vpn-service-model-17.txt
Reviewer: Brian Carpenter
Review Date: 2016-10-21
IETF LC End Date: 2016-10-11
IESG Telechat date: 2016-10-27

Summary: Almost ready
--------

Comments:
---------

Thanks for responding to my LC comments. I have not checked the details of the yang.

Minor Issues:
-------------

This is a point I missed originally but I mentioned it during the discussion:
The model says:

      | | |   | | +--rw match-flow
      | | |   | |   +--rw dscp?        inet:dscp
      | | |   | |   +--rw tos?         uint8

but tos was obsoleted when dscp was defined by RFC 2474. I don't think
you should include tos. You don't mention ECN, which are the two bits
from tos that are not included in dscp. Those bits are no good for flow
matching because they are variable.  If an operator tries to use the 8 TOS
bits for flow matching but a user supports ECN, the matching will not work
consistently. So I think it's misleading to include this.

v2.23.0 | Report a Bug | By Email