Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05

Donald Eastlake <d3e3e3@gmail.com> Tue, 01 September 2015 14:36 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 461421B406E; Tue, 1 Sep 2015 07:36:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d_FgNjHeLtIm; Tue, 1 Sep 2015 07:36:13 -0700 (PDT)
Received: from mail-ob0-x22c.google.com (mail-ob0-x22c.google.com [IPv6:2607:f8b0:4003:c01::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E34521B4019; Tue, 1 Sep 2015 07:36:12 -0700 (PDT)
Received: by obbbh8 with SMTP id bh8so808370obb.0; Tue, 01 Sep 2015 07:36:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=nWIzyl61fIyh9MMidIsJfNFxMO97X5JzI3TOMPdKsEI=; b=Dh2FGO39tCfCskdMazhpPFsRYwAo55YMeXLfE42Ntxs1TmuXwI7mlvCxBBYAuQskyT jYzBIY1WIx3BgM+4XA2acdO1wc0SJyKNDWAafLDnn2xIti7V0UweZNd4Zn41PbBRa4ka ak0C0XT3Uc62DBhQ+RWgnEEkUBiobU48aVDcv5sQK75M/vKs/TnWQV8Yf7dslC0Q0JSP HJfVhtHkr6BHweB8A+dtBFKPjX42h2VBsYWPvGIW9P4VAHeO21GO2+tWFIxHxICJdnxH U3PMzZ5NjAD5ir1OcCk4TsCcYxbg/DUmNQaBCuX0d/DK//ZKxaQIBv9BMT6P5AMRaW0c bwzQ==
X-Received: by 10.182.196.101 with SMTP id il5mr6576336obc.41.1441118172307; Tue, 01 Sep 2015 07:36:12 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.76.144.65 with HTTP; Tue, 1 Sep 2015 07:35:57 -0700 (PDT)
In-Reply-To: <4552F0907735844E9204A62BBDD325E7871A2CFE@nkgeml512-mbx.china.huawei.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com> <4552F0907735844E9204A62BBDD325E7871A2CFE@nkgeml512-mbx.china.huawei.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 1 Sep 2015 10:35:57 -0400
Message-ID: <CAF4+nEGAnyBVrv=Rbc0gfDijYsjraBW62ugC1Rwo07e6PSg_NA@mail.gmail.com>
To: Mingui Zhang <zhangmingui@huawei.com>
Content-Type: text/plain; charset=UTF-8
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/emR2zP2xbbsF_F1y-nTHItU2__k>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>, "draft-ietf-trill-pseudonode-nickname.all@ietf.org" <draft-ietf-trill-pseudonode-nickname.all@ietf.org>
Subject: Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Sep 2015 14:36:14 -0000

Hi,

Adding a little on two points:

On Sun, Aug 30, 2015 at 11:54 PM, Mingui Zhang <zhangmingui@huawei.com> wrote:
> Hi Russ,
>
> Thanks for the comments. Please see the in-lines below.
>
>> -----Original Message-----
>> From: Russ Housley [mailto:housley@vigilsec.com]
>> Sent: Friday, August 28, 2015 5:59 AM
>> ...
>>
>> Document: draft-ietf-trill-pseudonode-nickname-05
>> Reviewer: Russ Housley
>> Review Date: 2015-08-24
>> IETF LC End Date: 2015-09-01
>> IESG Telechat date: unknown
>>
>> Summary: Almost Ready
>>
>> Major Concerns:
>>
>> ...
> ...
>
>> (2)  Also, in Section 5.2, Step 1, I think the intended sort order depends on all
>> of the LAALP IDi values being represented with the same number of bits.
>> Since Section 9.1 provides a variable length field to carry a LAALP ID value, I
>> assume that they are not always the same length.  Is a step needed to
>> encode the LAALP ID to a consistent length?
>
> [MZ] The sort is done in the per-LAALP base. It's not necessary to make the LAALP ID to a constant length. Besides, the 'mod' function always returns a value in [0, k-1] whatever the length of LAALP ID is.

We could add "considering System ID and LAALP ID as byte strings".

>> ...
>
>...
>
>> Minor Concerns:
>>
>> (1)  ...
>...
>
>> (2)  I found the last sentence of Section 2 confusing.  I am suggesting a
>> rewording to see if I figured it out.  If I did not figure it out properly, then the
>> sentence really does need to be reworked.
>>
>>    Under the assumption that the default learning is enabled at
>>    edge RBridges, MAC flip-flopping can be solved by using a
>>    Virtual RBridge together with its pseudo-nickname.  This
>>    document specifies a way to do so.
>
> [MZ] Yes, this is clear. Will be incorporated.

Suggest: "Assuming that the default data-plane learning is enabled at
edge RBridges, MAC flip-flopping can be solved by using a Virtual
RBridge together with its psuedo-nickname. This document specifies a
way to do so."

>> ...
> ...
>
>> ...
>>

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> Thanks,
> Mingui