[Gen-art] Genart last call review of draft-ietf-ospf-yang-23

Erik Kline via Datatracker <noreply@ietf.org> Wed, 17 July 2019 23:07 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E9E4120203; Wed, 17 Jul 2019 16:07:40 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Erik Kline via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-ospf-yang.all@ietf.org, ietf@ietf.org, lsr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.99.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Erik Kline <ek@google.com>
Message-ID: <156340486027.25730.15500316030505591807@ietfa.amsl.com>
Date: Wed, 17 Jul 2019 16:07:40 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/fCMqUgA_LnMmzn27DJmhz2thhKY>
Subject: [Gen-art] Genart last call review of draft-ietf-ospf-yang-23
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2019 23:07:40 -0000

Reviewer: Erik Kline
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ospf-yang-??
Reviewer: Erik Kline
Review Date: 2019-07-17
IETF LC End Date: 2019-07-17
IESG Telechat date: Not scheduled for a telechat

Summary:

Major issues:

Minor issues:

I feel like the "version" text in 2.3 was confusing.  The first thing I did was
glance back up the overview where I (a) didn't see "version" mentioned and (b)
initially thought that "af" was maybe a proxy for "version".

But then later on it seems that "version" is only a mandatory property of the
LSA.

I'm not sure that I have concretely useful suggestions for improving this text,
and in fact it might well be that for expected readers of the document this is
in fact a non-issue.  Just thought I'd relay my experience.

Nits/editorial comments:

Page 25: NMDA RFC is 8342, not 8242.

Page 81: references draft-ietf-bdf-yang-xx.txt. This is referenced
elsewhere in the doc (correctly), so I think just remove the -xx may
be fine?