[Gen-art] Genart telechat review of draft-ietf-lamps-cms-update-alg-id-protect-03

Peter Yee via Datatracker <noreply@ietf.org> Wed, 26 August 2020 04:30 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id BCA953A0C73; Tue, 25 Aug 2020 21:30:59 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Peter Yee via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-lamps-cms-update-alg-id-protect.all@ietf.org, last-call@ietf.org, spasm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.14.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159841625970.23138.505710654934913808@ietfa.amsl.com>
Reply-To: Peter Yee <peter@akayla.com>
Date: Tue, 25 Aug 2020 21:30:59 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/fYss1GCSiOw7RY5ElA1wQryZgjU>
Subject: [Gen-art] Genart telechat review of draft-ietf-lamps-cms-update-alg-id-protect-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Aug 2020 04:31:00 -0000

Reviewer: Peter Yee
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at


Document: draft-ietf-lamps-cms-update-alg-id-protect-03
Reviewer: Peter Yee
Review Date: 2020-08-25
IETF LC End Date: 2020-08-10
IESG Telechat date: 2020-08-27

Summary: This update to CMS (RFC 5262) attempts to prevent algorithm
substitution attacks on the hash algorithms. The changes seems reasonable, with
one of them already being specified in RFC 6211. There are a few nits that
should be cleared up prior to publication. [Ready with Nits]

Major issues: None

Minor issues: None

Nits/editorial comments:

Page 2, section 1, 2nd paragraph, last sentence: change "associate" to

Page 4, 1st NEW block, 4th sentence: insert "the" before "signedAttrs field".

Page 5, section 3.5, 2nd paragraph, 1st sentence: insert "the" before "same

Page 5, section 4 title: change "Recommend" to "Recommended" for parallel
construction with the section 3 title.

Page 6, ADD block: delete the first "known".

Page 6, section 6, 3rd paragraph, 5th sentence: change "signalling" to