Re: [Gen-art] Gen-ART Telechat review of draft-ietf-rtgwg-remote-lfa-10.txt

Jari Arkko <jari.arkko@piuha.net> Wed, 07 January 2015 09:13 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B63121A898C for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 01:13:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c9tefDcNXPWI for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 01:13:23 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id A69BC1A8993 for <gen-art@ietf.org>; Wed, 7 Jan 2015 01:13:14 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 032EF2CCCF; Wed, 7 Jan 2015 11:13:14 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DrZ91UAOxbya; Wed, 7 Jan 2015 11:13:10 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id F15382CC4D; Wed, 7 Jan 2015 11:13:09 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Content-Type: multipart/signed; boundary="Apple-Mail=_2A795280-494C-4C27-87A6-51F8107EE4ED"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <E87B771635882B4BA20096B589152EF628A09746@eusaamb107.ericsson.se>
Date: Wed, 07 Jan 2015 11:13:08 +0200
Message-Id: <165B2599-7C0D-44A7-9CF4-0E12EF986B20@piuha.net>
References: <E87B771635882B4BA20096B589152EF628A09746@eusaamb107.ericsson.se>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/gFXoEPQL1sXAhTulj_nVDcvGw4c
Cc: "draft-ietf-rtgwg-remote-lfa.all@tools.ietf.org" <draft-ietf-rtgwg-remote-lfa.all@tools.ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Telechat review of draft-ietf-rtgwg-remote-lfa-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2015 09:13:28 -0000

Thanks for your review, Suresh. I agree with your points. Authors, are you taking this into account?

Jari

On 07 Jan 2015, at 08:10, Suresh Krishnan <suresh.krishnan@ericsson.com> wrote:

> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> 
> Please wait for direction from your document shepherd or AD before 
> posting a new version of the draft.
> 
> Document: draft-ietf-rtgwg-remote-lfa-10.txt
> Reviewer: Suresh Krishnan
> Review Date: 2015/01/06
> IESG Telechat date: 2015/01/08
> 
> Summary: This draft is ready for publication as a Proposed Standard but 
> I have some minor issues that the authors may wish to address.
> 
> Section 4.2.1.1:
> This sentence is missing a verb (reach?)
> 
> The exclusion of routers reachable via an ECMP that includes S-E 
> prevents the forwarding subsystem from attempting to <MISSING VERB> a 
> repair endpoint via the failed link S-E.
> 
> Section 4.3:
> 
> The Compute_Neighbor_SPFs() function seems to be missing a check for 
> verifying if the interface is not the failed interface. I think the 
> following check should be added.
> 
> if (intf != fail_intf)
> 
> Thanks
> Suresh
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art