Re: [Gen-art] Genart last call review of draft-ietf-ipsecme-qr-ikev2-09

Alissa Cooper <alissa@cooperw.in> Mon, 06 January 2020 17:25 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 254FE120871; Mon, 6 Jan 2020 09:25:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.72
X-Spam-Level:
X-Spam-Status: No, score=-2.72 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=0yg/yoR+; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=IJa6IEJC
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ll6OqdYwDu-u; Mon, 6 Jan 2020 09:25:57 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C9CE1208C1; Mon, 6 Jan 2020 09:25:57 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0E69D22101; Mon, 6 Jan 2020 12:25:55 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 06 Jan 2020 12:25:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=g egEicOU4QiNK0ZkIduJUWhOuZej/CpoFxG3rMhv3/g=; b=0yg/yoR+qLqA9iWk9 8mFWgXwkLSsPS9NvfeEmc9YpdsTtHLfnUmOWufmCvIt0FJFaYh15U+oi9kDxDMR2 hw9H9XyO9cC1X9CpoYA4a8QPOZeI2rjSC9aMFxuK3kDkhQIJfpipAm+4EqjeQF3F Bp6BlEaU/7hWvPR/pQ0yE7N/tMklpLSdCcnkB/s3orlXQ/M//zyIpmTYr+D7Eaye ggO/9dhtPiCdfTuFpqCW3b1qMo9eAl/etkDHczAKBA8BiIjvGP8cAQ7DX9gN5Yw6 KfinXwMM13UIxGwYNwTSOeK5Zg/EvNyTmnY6m991az3xzHK+eDd4e5Dn9AZHCQue RI61w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=gegEicOU4QiNK0ZkIduJUWhOuZej/CpoFxG3rMhv3 /g=; b=IJa6IEJCtt9AH1YHNVIzlsulawECrP3qPvVuIyj8FhN1YS74NrZ1o/aor 5MuOtjnT0mjgLSJDFP1QgWM2OngymEiow3TwpWEI8mGCUurOhi48HuM7X2P7EcQi ZGIP2U4GXir6oFQqY+0RZt5dtnRCDnLA0re0ir79tkCN4m4DQI22s+ZPWESYmjuz wiO3ckCBCQaN54Dt4nmPtunUk6k2bAljqdNpY1KKlg29ARozfe99XKqhyBBEZqGU vPhiz+Lh9lE9V/ITGO3c8eLYkjFgXZLpFPtV5cwoHM9AUVs4cp/joYSKdiRXH9x5 AMfAnBXleSy5pexyBQJAt8P5Zv1Lg==
X-ME-Sender: <xms:o20TXvyKl6m75Fk-5Lv4sgocPtUDGP1l2DO2_hjwwW2sHYxzt_CaAw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdehtddguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeetlhhi shhsrgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomh grihhnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdekvdenucfrrghr rghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhush htvghrufhiiigvpedt
X-ME-Proxy: <xmx:o20TXu1kRlvX2f5kjFx4v3J8XhW3q_-UxG6ongJc1csRwVA_J7uUQA> <xmx:o20TXo_xzMYGbcRFXX3NgJVk0g0gXfkRWUAHWqFjMIGe4HHnenD1Nw> <xmx:o20TXmSz0CuJGdBmD37jsrQmNn1KETOzxyhi_-9KSWbfW2h6Xz1tew> <xmx:o20TXrNM17QiwWtkfLkFV9ccwQ8GvE6frFNMHSLHldw-lmXrOmLlcg>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.82]) by mail.messagingengine.com (Postfix) with ESMTPA id A9D7C80066; Mon, 6 Jan 2020 12:25:54 -0500 (EST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <157626827886.12929.4367951047776204825@ietfa.amsl.com>
Date: Mon, 6 Jan 2020 12:25:53 -0500
Cc: gen-art@ietf.org, ipsec@ietf.org, last-call@ietf.org, draft-ietf-ipsecme-qr-ikev2.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9C65D43A-D669-44B2-BFC0-C4C14DA7CFF3@cooperw.in>
References: <157626827886.12929.4367951047776204825@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gRGHj7XRoEHkdar5IqZxIVZeQBo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ipsecme-qr-ikev2-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2020 17:26:00 -0000

Christer, thanks for your review. Valery, thanks for your responses. I entered a No Objection ballot.

Alissa


> On Dec 13, 2019, at 3:17 PM, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ipsecme-qr-ikev2-09
> Reviewer: Christer Holmberg
> Review Date: 2019-12-13
> IETF LC End Date: 2019-12-25
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: The document is well-written, and almost ready for publication.
> However, I have a couple of minor comments that I would like the authors to
> address.
> 
> Major issues: None
> 
> Minor issues:
> 
> Q1:
> 
> The Security Considerations lists IKEv2/IPSec algorithms that are not
> considered quantum-resistant. However, that is not mentioned anywhere else. I
> think it would be good to mention that in the Abstract and/or Introduction.
> 
> Q2:
> 
> Section 3 says:
> 
>   "If the responder does not support this specification or does not have
>   any PPK configured, then it ignores the received notification and
>   continues with the IKEv2 protocol as normal."
> 
> I assume the ignoring of a non-supported notification and continuing with
> normal IKEv2 is part of the IKEv2 specification. If so, I suggest to say add
> something like:
> 
> ", as described in RFCXXXX."
> 
> Nits/editorial comments:
> 
> Q3:
> 
> The Security Considerations talk about the Grover's algorithm. Please add a
> reference.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art