[Gen-art] Genart last call review of draft-ietf-ipsecme-labeled-ipsec-10

Ines Robles via Datatracker <noreply@ietf.org> Mon, 10 April 2023 18:57 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D656C151554; Mon, 10 Apr 2023 11:57:04 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ines Robles via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-ipsecme-labeled-ipsec.all@ietf.org, ipsec@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.16.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168115302430.32336.7010056407732824949@ietfa.amsl.com>
Reply-To: Ines Robles <mariainesrobles@googlemail.com>
Date: Mon, 10 Apr 2023 11:57:04 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gTc6yk7Q4jKh4sNNEQREidgJa70>
Subject: [Gen-art] Genart last call review of draft-ietf-ipsecme-labeled-ipsec-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Apr 2023 18:57:04 -0000

Reviewer: Ines Robles
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ipsecme-labeled-ipsec-10
Reviewer: Ines Robles
Review Date: 2023-04-10
IETF LC End Date: 2023-04-10
IESG Telechat date: Not scheduled for a telechat

Summary:

This document defines a new Traffic Selector (TS) Type for Internet Key
Exchange version 2 to add support for negotiating Mandatory Access Control
(MAC) security labels as a traffic selector of the Security Policy Database
(SPD).  The new TS type is TS_SECLABEL.

The document is well written and easy to read.

Major issues: None

Minor issues: None

Nits/editorial comments:

Section 3.2: "198.51.0/24" --> "198.51.100.0/24" ?

Question: Section 2.1, the Security Label should be at least of one octet. Is
there a limit of octets for this field?

Thank you for this document,

Ines.