IETF Logo Mail Archive

Re: [Gen-art] [Ice] Genart last call review of draft-ietf-ice-trickle-16

Peter Saint-Andre <stpeter@stpeter.im> Mon, 12 February 2018 18:39 UTC

Return-Path: <stpeter@stpeter.im>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 996CF12D881; Mon, 12 Feb 2018 10:39:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=stpeter.im header.b=cfc4+jrL; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=RquxG7uT
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rIbk_tK4MF8u; Mon, 12 Feb 2018 10:39:35 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 514EC12D872; Mon, 12 Feb 2018 10:39:35 -0800 (PST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8E8F521519; Mon, 12 Feb 2018 13:39:34 -0500 (EST)
Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Mon, 12 Feb 2018 13:39:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stpeter.im; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=CT3u7Di/u6/gLIv6RtDlJN4GL8P9qzbbaDvaxxmWJlc=; b=cfc4+jrL fj61GiqvXCxPKTqMueUNGYG9uDbFRQ6eMiz5cd4edxbwui9t6F0W2YyoQ7qM40Re A1g+UV4YcwaKOG+VVi3MdVa6wXPjMtlyVPbBmBLXUexC8DLpI75cf4dMuNi6WMFn hs80qn2P5TMsfjfQ8w4iYA+aU/sFkqV+gIFt5dinQ2bVtFIqVMPs/TEn/7Rfpa3O NCYAkVqFaFgYgjkBGb1HbQGQgjUpewnmKJr1U5Lbtc14D1wl5ebKKOnTca9r2pwT jZlYPDb3bbc5Jz96GSLPBZ3fDfw0dDL6W9c5s5VTyavY5HjunJ8tiD0BMU4JCzu1 +EiKu1oCLboi/A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=CT3u7Di/u6/gLIv6RtDlJN4GL8P9q zbbaDvaxxmWJlc=; b=RquxG7uTT+7N5F2u/1wrkrfWOAhDPvJojim5MHPbh4gib Ym9PtLGg8S/WZ24vmiFAf7QtCjCIehoJW+lfloi9wzoRC8VrrKmzxVvPUjhEHuij hp/hGMtWUvbkcqMGecPTm4vJaz/goKvXwpXFd8kHWznbSZ1IjLQc5xGmU1UluZxT ZL/VC9Ah4bd/A5kVZNyDA1B5R00ovcWPg3Bc6xLhOT8TRmmbhVZz72xA70M4vhbK U5i8vBdtfrtoKXPxs/sdQDHKhFos3koOhjKh7el7Wkk+p0/q67TS9mRfna6KGpnM BZbuK3tfl3en5cQBHyfqhBLyrVDgJEXEDUXbXcptA==
X-ME-Sender: <xms:Zt-BWnJjEUmYvRZLBgIYR7TrGQ3E5URua-4ANmh0XtHALmg6t1ShtA>
Received: from aither.local (unknown [76.25.3.152]) by mail.messagingengine.com (Postfix) with ESMTPA id DB8E62460B; Mon, 12 Feb 2018 13:39:33 -0500 (EST)
To: Roni Even <ron.even.tlv@gmail.com>, gen-art@ietf.org
Cc: draft-ietf-ice-trickle.all@ietf.org, ice@ietf.org
References: <151835365522.17100.3382413286251834508@ietfa.amsl.com>
From: Peter Saint-Andre <stpeter@stpeter.im>
Message-ID: <7485ad71-d2f1-6f93-6a25-0872e38fcc30@stpeter.im>
Date: Mon, 12 Feb 2018 11:39:32 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <151835365522.17100.3382413286251834508@ietfa.amsl.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="bkQRPQ4JkTBwFNasUPyBnWBoBbswvKZ2R"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/i0I7DoyJI4TT2MJ9JIgtHUafnVQ>
Subject: Re: [Gen-art] [Ice] Genart last call review of draft-ietf-ice-trickle-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2018 18:39:38 -0000

On 2/11/18 5:54 AM, Roni Even wrote:
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ice-trickle-??
> Reviewer: Roni Even
> Review Date: 2018-02-11
> IETF LC End Date: 2018-02-22
> IESG Telechat date: 2018-03-08
> 
> Summary:
> The document is ready for publication as a standard track RFC
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> In appendix B third paragraph "When performing full trickle, a full ICE
> implementation could conveying the initial ICE description or response thereto
> ..."  change to "convey"

Noted and fixed under source control:

https://github.com/ice-wg/trickle/commit/3c86705bd211e1b5bc2c8f7fc199ec2c2db7595d#diff-f7ced034e08b14404c7832d8f5f19567

Thanks for the review!

Peter

v2.23.0 | Report a Bug | By Email