Re: [Gen-art] Genart last call review of draft-ietf-isis-segment-routing-extensions-23

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Thu, 18 April 2019 04:27 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 573F31200C1; Wed, 17 Apr 2019 21:27:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.501
X-Spam-Level:
X-Spam-Status: No, score=-9.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=ZApY+l64; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=AoVyjayV
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zJH_ejn_4gQy; Wed, 17 Apr 2019 21:27:26 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0631F120072; Wed, 17 Apr 2019 21:27:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4044; q=dns/txt; s=iport; t=1555561646; x=1556771246; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GCpBS6sw6W3YC05UUKA4k3JllswPuQHDX76dbdlREIc=; b=ZApY+l648M9ivDt0e/6ZUA58Wuaq6Og5WHFyPqR5Xna6atcyi/fRY1CA 7p6dPODIOQ3ejnHTOlhE30Gw5jW862pCN3SXN5Vevmvdmh733IpaJmNQZ O0vUzk2qFnyEo2drFnfH0bSrDJeiC2Gf3yiuKUvHr7iQ8lsfVBLyHoRVC 8=;
IronPort-PHdr: =?us-ascii?q?9a23=3AbllZlhLoiYBmSdRFwdmcpTVXNCE6p7X5OBIU4Z?= =?us-ascii?q?M7irVIN76u5InmIFeBvKd2lFGcW4Ld5roEkOfQv636EU04qZea+DFnEtRXUg?= =?us-ascii?q?Mdz8AfngguGsmAXEL6KuXgYjY1NM9DT1RiuXq8NBsdFQ=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AIAAA3/Ldc/5pdJa1mGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUQUBAQEBCwGBPVADaFUgBAsohA6DRwOEUopCgleXHIEugXs?= =?us-ascii?q?OAQEjCoRAAheFfiM0CQ4BAwEBBAECAQJtHAyFSgEBAQQjBA0MAQE3AQsEAgE?= =?us-ascii?q?IDgMDAQEBAwIZDQICAjAVCAgCBAENBQiDG4FpAxwBAgyeAQKKFHF8M4J5AQE?= =?us-ascii?q?FhH8Ygg0DBoELJwGLSReBQD+BEAFGgkw+gmECgWMkgmQxgiaLI4IKmRQJAoI?= =?us-ascii?q?GhguITYNhggmGHYxXi3GGL414AgQCBAUCDgEBBYFPOIFWcBWDJ4IODBeDTIU?= =?us-ascii?q?UhT9ygSmPSQEB?=
X-IronPort-AV: E=Sophos;i="5.60,364,1549929600"; d="scan'208";a="548724593"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 18 Apr 2019 04:27:05 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by rcdn-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id x3I4R5Gm022052 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 18 Apr 2019 04:27:05 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Apr 2019 23:27:03 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Apr 2019 23:27:02 -0500
Received: from NAM05-BY2-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 18 Apr 2019 00:27:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GCpBS6sw6W3YC05UUKA4k3JllswPuQHDX76dbdlREIc=; b=AoVyjayV6ReGCAA1R3vW/XuhAygcn8Mc1kawH6gdpKFfETs5CF90bG2ZVb7qrFJ9ee6WX3SMIwGQ4GHDM55Jq9GkWFkWw7t2VKlQ5LKD3S+jFnyNO3rWYn05wEWJgNTAnV+VZgRt+qdVNh8umwCe3+oTVeNfBp9m4YPClvLGOzo=
Received: from BYAPR11MB3638.namprd11.prod.outlook.com (20.178.237.19) by BYAPR11MB2552.namprd11.prod.outlook.com (52.135.226.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Thu, 18 Apr 2019 04:27:00 +0000
Received: from BYAPR11MB3638.namprd11.prod.outlook.com ([fe80::d801:cf9d:b255:2b07]) by BYAPR11MB3638.namprd11.prod.outlook.com ([fe80::d801:cf9d:b255:2b07%6]) with mapi id 15.20.1813.011; Thu, 18 Apr 2019 04:27:00 +0000
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Erik Kline <ek@google.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "lsr@ietf.org" <lsr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-isis-segment-routing-extensions.all@ietf.org" <draft-ietf-isis-segment-routing-extensions.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-isis-segment-routing-extensions-23
Thread-Index: AQHU9Y1WOIyyMhb6fUaruTwn9yhhSaZBUZQQ
Date: Thu, 18 Apr 2019 04:26:59 +0000
Message-ID: <BYAPR11MB36389502EAFF03793EC45635C1260@BYAPR11MB3638.namprd11.prod.outlook.com>
References: <155555401259.21196.3824352311000750590@ietfa.amsl.com>
In-Reply-To: <155555401259.21196.3824352311000750590@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ginsberg@cisco.com;
x-originating-ip: [2001:420:c0c8:1006::4e0]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7243dde9-dd89-46b7-4593-08d6c3b619af
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BYAPR11MB2552;
x-ms-traffictypediagnostic: BYAPR11MB2552:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <BYAPR11MB2552E08CBC1E887334941B7DC1260@BYAPR11MB2552.namprd11.prod.outlook.com>
x-forefront-prvs: 0011612A55
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(376002)(136003)(366004)(189003)(199004)(13464003)(4326008)(68736007)(6436002)(74316002)(316002)(9686003)(5660300002)(305945005)(25786009)(6246003)(54906003)(8676002)(7736002)(110136005)(6116002)(229853002)(81156014)(8936002)(86362001)(81166006)(6306002)(53936002)(2501003)(486006)(33656002)(76176011)(14454004)(11346002)(52536014)(55016002)(7696005)(2906002)(446003)(6506007)(53546011)(99286004)(71200400001)(71190400001)(186003)(97736004)(102836004)(476003)(46003)(478600001)(256004)(14444005)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR11MB2552; H:BYAPR11MB3638.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: R3/wpwd3lS6kG7CLmxHUFnU8XOwnn/FiQb1la9qXR9oZrLDvM9rMprSKZXoW3xOr1fYWjtJaYWGpRuFHSu1p6Ix+KxaAWyOgVOMhTSVsZlBfp3ey1FgNE0bvoTW1F2tgPdowdP1M6MqE0RMpC4eBo3r9ip5CP74ErAsaLea6vk6zesm5SyU1MdVkCFJEBXcGsHFalc6QS0tMAYJwudTcR20hCsXcVDHuaQNsy85NE/JzUh/yFzokYn9RTbCMtIBLxAP1xbYZ6qatZgULcHJe5+kOZCcweHH/hqrQJ65cxIjF8eHovfcuuWE0g5obDgEJwDZKFXjpagbiRpN6mYxcHIyL5nc4ESLTt4oGAbzf67qsrMoKWKXBKqNBwYTrAbqclawG1H+gqye+7jnjiOzDzmi3NxO1QxQ2Rb9a8qXZ6bk=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7243dde9-dd89-46b7-4593-08d6c3b619af
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 04:26:59.9583 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2552
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.12, xch-rcd-002.cisco.com
X-Outbound-Node: rcdn-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/i3g3fZfFw9sHEhaHTHw_8ACpgjk>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-isis-segment-routing-extensions-23
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2019 04:27:29 -0000

Erik -

Thanx for the detailed review.
I have published V24 of the draft which addresses all of your comments (and a few pending AD review comments from Alvaro).
Some exceptions noted below.

> -----Original Message-----
> From: Erik Kline via Datatracker <noreply@ietf.org>
> Sent: Wednesday, April 17, 2019 7:20 PM
> To: gen-art@ietf.org
> Cc: lsr@ietf.org; ietf@ietf.org; draft-ietf-isis-segment-routing-
> extensions.all@ietf.org
> Subject: Genart last call review of draft-ietf-isis-segment-routing-extensions-
> 23
> 
> Reviewer: Erik Kline
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-isis-segment-routing-extensions-??
> Reviewer: Erik Kline
> Review Date: 2019-04-17
> IETF LC End Date: 2019-04-17
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> For what little I know of IS-IS and segment routing, this all seems to make
> general sense.  I simply had some language/style nits (below).
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> # Section 1
> 
> * "SR's control-plane can be applied ..., and do not require...".  It looks
> like the subject of the sentence is "control-plane" and so perhaps "do not"
> should be "does not".
> 
> * s/draft/document/g
> 
> # Section 2.1
> 
> * "Algorithms identifiers" -> "Algorithm identifiers"
> 
> # Section 2.2.2
> 
> * Length: variable
> 
> Should this say "11-12" (1 + 1 + 6 + 3-4)?
> 
[Les:] No. System ID may be a value from 1-8 octets in length (though in practice only the value 6 is used). I have clarified the text to mention that this field is of "ID Length" (as per ISO 10589).

> * "set of Adj-SID each router" -> "set of Adj-SIDs each router", perhaps.
> 
> # Section 2.3
> 
> s/valu eis/value is/
> 
> # Section 2.4
> 
> Silly, naive question: does the length include the sum of the octets
> representing the sub-TLVs?
>
[Les:] Yes. TLV length includes all of the data contained in the TLV - including sub-TLVs.

    Les

> # Section 2.4.6
> 
> In example 3, I would recommend s/0xD/0x0D/ & s/0x0/0x00/ & s/0x1/0x01/
> ,
> but perhaps that's just a personal readability thing.
> 
> # Section 3.3
> 
> * "by other components than" -> "by components other than", perhaps.
> 
> * "to know what are the local SIDs" -> "to know what the local SIDs are",
>   perhaps.
> 
> * "The SRLB sub-TLV is used for this purpose...", (instead of "that purpose")
> maybe.
> 
> * "which mechanisms are outside" -> "which are outside", maybe.
> 
> * "the SRLB TLV" -> "the SRLB sub-TLV", I think.
>