Re: [Gen-art] Genart last call review of draft-ietf-core-senml-etch-05

Ari Keränen <ari.keranen@ericsson.com> Sat, 14 September 2019 16:03 UTC

Return-Path: <ari.keranen@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AB2EA12006F; Sat, 14 Sep 2019 09:03:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ql1BNczKLI2K; Sat, 14 Sep 2019 09:03:23 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 848AB12006D; Sat, 14 Sep 2019 09:03:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYPx/dC+zhtmqe6twEdhaNQ2Q195r/8ms9f5rSlHcvtFB4Bo+Y9YqLlYn1r5dQJPUEgrmnm3nbHKU3Z0QEdk/Jpiq6Qyy5BF33ItPPinyuQwHwh9y1+9f8LMZ4KVPowUYFs7yUVbyhpOCtqefCbV5uR95vhlYKPW/v9YT/4wVapZ7oym7mV6DVa2ES7sF+4Dz7DTMO6ZhM5gHwy/Dc/9Av6nLW5hQwhAdeRO0lyeAiZp5Uy/0n3y3C+kxukm84rXGOq3BBvlvXgy5bYaHUHFthctoY6d2jCp/9ttON+PfgVj1jc7ZBFvhMQyfN1OwdkJeJpnWyTehMUT0/d+5h0V6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HRHaXaUj8B9xH2cwcAaQf9t+fk4Mli32tuz3tHpRuy0=; b=kd7qGEXbVvVv7vtxu8meu+DfSc2ljOIsuurCpcAuge/VVUJUEP0n6Bo9RYPlWdLce/0qSdzi0S2IyyoalT/3OdPOo0PEkhn/s4FnCZkJmOByu/EDeBT5scp6YQFiuuFX+WRCYDMHTfXDjMDuimoYCZB9IG6Vc7de5FGojIYTaT7i4zIXjqU/kDELoDs7vg4bcBFcUyUBIKEV1RQfJW6ZUR5mYUwcqVzpIHjBsLxVGCJnnkNVk5e43LdAsYfVfxYf7M/5JrFno/DoYSNvBpJHZu9+ZZJLyhKBRtsYZ8jvnmKoq87VKxn6ZY3y5UhXv0mILi8XpAYCeCd8oQ3QDmseTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HRHaXaUj8B9xH2cwcAaQf9t+fk4Mli32tuz3tHpRuy0=; b=bnVqUSBav5lhwyDsvhKT3S57AbhzH2pV4A2qx3FapVUz4XyRpUAJPsXmqH2hy+pW4HyKqYpo+DtmOT/pXdG9aJxDgv2uW23Y2GTvw59vTmTqpqVqwaJuWYLOHQATzib8UP3VUhQ7FXtHVAPDnJ73/d1EGtMFHHBoG4Glk8hCtWI=
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com (20.176.166.145) by HE1PR07MB3356.eurprd07.prod.outlook.com (10.170.247.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.14; Sat, 14 Sep 2019 16:03:21 +0000
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b910:6521:f387:7cf2]) by HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b910:6521:f387:7cf2%5]) with mapi id 15.20.2284.009; Sat, 14 Sep 2019 16:03:20 +0000
From: Ari Keränen <ari.keranen@ericsson.com>
To: Robert Sparks <rjsparks@nostrum.com>, Alissa Cooper <alissa@cooperw.in>, Warren Kumari <warren@kumari.net>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "core@ietf.org" <core@ietf.org>, "draft-ietf-core-senml-etch.all@ietf.org" <draft-ietf-core-senml-etch.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-core-senml-etch-05
Thread-Index: AQHVXndtEXX4ray0nketuaWMlS/QSacmiyWA
Date: Sat, 14 Sep 2019 16:03:20 +0000
Message-ID: <48F02EA5-E00A-4D97-B0ED-7595B232910A@ericsson.com>
References: <156708950337.21012.630829697167091848@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1d.0.190908
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ari.keranen@ericsson.com;
x-originating-ip: [2001:14bb:150:480b:5599:3a5f:6dfc:30d0]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e0c0f606-01b7-47b3-631b-08d7392d1061
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:HE1PR07MB3356;
x-ms-traffictypediagnostic: HE1PR07MB3356:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <HE1PR07MB3356DF8833CFC7FF41D3703885B20@HE1PR07MB3356.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01604FB62B
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(189003)(199004)(71190400001)(71200400001)(6436002)(305945005)(6306002)(4326008)(6512007)(478600001)(25786009)(99286004)(8676002)(6246003)(53936002)(85202003)(6486002)(316002)(58126008)(7736002)(54906003)(110136005)(229853002)(476003)(2906002)(446003)(2616005)(14454004)(966005)(46003)(36756003)(186003)(486006)(66946007)(33656002)(64756008)(102836004)(66556008)(66476007)(76116006)(66446008)(76176011)(6506007)(5660300002)(86362001)(81166006)(81156014)(6116002)(8936002)(85182001)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3356; H:HE1PR07MB4236.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: FfgeUon/nHJkJQ5hYfshBpce24nUJzEW3oyVi42JPR83Xy5ktjZygDLWD9Oh3sP3If1l5LPRJdWy0e+rM5rLNYEGNnkjWdQ+6kWaIqxhdysiGD3Ql+7RD7WVrAjTydalhSNNJvVUXzQH6NUBN/cA5/SNmweOfiFINTQALcWQd/tXeqX2djsw/9L6ph7wdSylWyfUVzMRlKu3FBstLd12H+3ZX5vx/dw3W/FkkeTp7ADQECF49dGrBQH/55rjzcY988YtwldZOR7IyOuPGwFlmfiFX0iXuccQ7K+eVEeIeJvf425uU+mfgpU2jxRDbIPQZsOweWI36e1udtivtc112z6OeBDw9mbkkL+lQpS7RHuHoZQsoVgONTLvrtReg8bzKEeD1x4Pr/8ruVYrOcJl+9dpSmURfddDxJnF3Z3ITf4=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <DDC82659F995FC41BF6E95BA0484EF47@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0c0f606-01b7-47b3-631b-08d7392d1061
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2019 16:03:20.6004 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Fl7qHlekwk5V5YCL2k4ngJKpTUxeNfiPRQV8WvhKfKJQyluh10urykCmi5NISPSIVhpVezi2TNCBB3unS1ez+ElvMs7hKzCPxfLRCqAO1uI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3356
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/iGPjo7ppN0CjUHvzzt5980XSkhQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-senml-etch-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Sep 2019 16:03:27 -0000

Hi Alissa, Robert & Warren,

Thank you for your reviews! You all had concerns on the Fragment ID part of the SenML etch draft (quotes below). I'll try to address those concerns in this PR:
https://github.com/core-wg/senml-etch/pull/10

The suggested new Fragment ID section text would be:

   Fragment identification for Records of Fetch and Patch Packs uses the
   same mechanism as SenML JSON/CBOR fragment identification (see
   Section 9 of [RFC8428]), i.e., "rec" scheme followed by a comma-
   separated list of Record positions or range(s) of Records.  For
   example, to select the 3rd and 5th Record of a Fetch or Patch Pack, a
   fragment identifier "rec=3,5" can be used in the URI of the Fetch or
   Patch Pack resource.

More details below.

> On 29 Aug 2019, at 17.38, Robert Sparks via Datatracker <noreply@ietf.org> wrote:
[...]
> I am a little uncomfortable with the "Fragment Identification" section (4) of
> this document - it feels like a "do what we mean" statement. I don't have text
> to suggest. It may well be that it will be dead-obvious to an implementer what
> to do, but it makes me uneasy.

I was hoping it to be obvious since it is exactly the same mechanism as for regular SenML; just applied to another media type with the same structure. I'm a bit hesitant to add more normative text since that would be just repeating what's already said in the SenML RFC. Instead I'd suggest a short summary of the feature and an example (see above). 

Warren had a good observation that is wasn't clear to what Pack the ID applies to so I clarified that (see below).

> On 3 Sep 2019, at 22.23, Warren Kumari via Datatracker <noreply@ietf.org> wrote:
[...]
> Question:
> 1: The text in Section 4 feels quite hand-wavy / terse, and I don't think gives
> sufficient guidance to actually use this. e.g: What takes precedence? Do I
> refer to a specific record (using fragment identification) and then apply the
> FETCH / PATCH to that? Or do I use fragment identification to refer to records
> what have been PATCHed? As might be clear from the above, I'm not a CoRE
> person, so I'll be happy to accept "Your question makes no sense, this will be
> blindingly obvious to anyone who's actually implementing this...." :-)

Actually this is a mechanism to refer to Records of the Patch/Fetch Pack, not in the resulting (regular SenML) Pack. I suggest clarifying this in the text with:

OLD: Fragment identification is supported by analogously applying [...]
NEW: Fragment identification for Records of Fetch and Patch Packs uses [...]

I hope this solves your concerns.


Thanks,
Ari