[Gen-art] Last Call Review of draft-ietf-tls-negotiated-ff-dhe-08

Tom Taylor <tom.taylor.stds@gmail.com> Fri, 17 April 2015 22:04 UTC

Return-Path: <tom.taylor.stds@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com []) by ietfa.amsl.com (Postfix) with ESMTP id A8C971B3092; Fri, 17 Apr 2015 15:04:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id 9ciZhFZw9ps4; Fri, 17 Apr 2015 15:04:40 -0700 (PDT)
Received: from mail-ie0-x22d.google.com (mail-ie0-x22d.google.com [IPv6:2607:f8b0:4001:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1DF21B3091; Fri, 17 Apr 2015 15:04:39 -0700 (PDT)
Received: by iebrs15 with SMTP id rs15so82619232ieb.3; Fri, 17 Apr 2015 15:04:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=7YAuhcqxIV/TiHitUQK/7tdJgl8r+GHJRB5ScKSaE30=; b=T5CxSD4QQcSLoTs5OsY6jmkuIRs63XKyBXUktUtPycSZaFbDp0FYqZTUMQxdf+RuwS 502RVF9r9ef011d3WMN3MtKU+s5Bak86EvXj6aRY6AykK61GGQw92535kVvEJdkzjKBa rmjLZKJTE22muRBv/xbM9CPtgNvb6nyPkBDGtcPwBJUy6jxfNvjOF2Bhz3KYGz26CLg/ YPBaQ3DmdljEfzQpd2TV2vxJvxwo5+biwWxXYago17GZSqjrWeQDBMYtvAjnoLNpZlSK 7K9YTdx/LCO/JXme6I7Hf2Pma8x03aUX3l0FXprGG9u5krbtH/h2VWYNAIiaEbaCP6IG EVRg==
X-Received: by with SMTP id b14mr5979258icr.29.1429308279378; Fri, 17 Apr 2015 15:04:39 -0700 (PDT)
Received: from [] (dsl-173-206-189-89.tor.primus.ca. []) by mx.google.com with ESMTPSA id lp7sm1981378igb.20.2015. (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2015 15:04:39 -0700 (PDT)
Message-ID: <55318375.80100@gmail.com>
Date: Fri, 17 Apr 2015 18:04:37 -0400
From: Tom Taylor <tom.taylor.stds@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Gen Art <gen-art@ietf.org>, daniel gilmour <dkg@fifthhorseman.net>, Sean Turner <turners@ieca.com>, Stephen Farrell <stephen.farrell@cs.tcd.ie>, The IETF <ietf@ietf.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/ikdGeV1fsvVvW8c0UCaibNvTsf4>
Subject: [Gen-art] Last Call Review of draft-ietf-tls-negotiated-ff-dhe-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2015 22:04:41 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at


Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-tls-negotiated-ff-dhe-08
Reviewer: Tom Taylor
Review Date: 17 April 2015
IETF LC End Date: 17 April 2015
IESG Telechat date: (if known)

Summary: Ready with minor issues and nits. I did not attempt to verify 
the hexadecimal expansions of p and q in Appendix A.

Major issues:

Minor issues:

1. Section 3 third paragraph: to what does "these values" refer? Any 
supported group at all, or specifically FFDHE groups? Nit: the ALSO is 
not part of RFC 2119 terminology, so should not be capitalized. The 
usual question: why SHOULD rather than MUST?

2. Why SHOULDs rather than MUSTs in the first paragraph of Section 4? 
What alternative does the server have in these cases?

Nits/editorial comments:

1. IDNits complains that the Abstract does not list the RFCs updated by 
this one. You need to add a statement like: "This document updates RFC 
2246, RFC 4346, RFC 4492, and RFC 5246."

2. Section 1, second-last paragraph, third line: s/;/ and/

3. Section 3 fourth paragraph: s/who/that/

4. Section 8, second paragraph, third line: s/it/IANA/

5. Section 9.1, first line: s/is hashed/are hashed/

6. Section 9.1, second indented paragraph under "An attacker who 
impersonates the client ...":
First line ends in an incomplete thought "(e.g. by ."

7. Same location, all three indented paragraphs: "e.g." has to be 
followed by a comma.

8. Section 9.2, first para, third line: s/which defines/that define/

9. Annex A.x, several instances: s/calcluated/calculated/