Re: [Gen-art] review of draft-ietf-trill-centralized-replication-10.txt
Donald Eastlake <d3e3e3@gmail.com> Thu, 04 January 2018 23:13 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62DC91270AC; Thu, 4 Jan 2018 15:13:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.749
X-Spam-Level:
X-Spam-Status: No, score=-1.749 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2t0mooMj1jB0; Thu, 4 Jan 2018 15:13:52 -0800 (PST)
Received: from mail-ot0-x22f.google.com (mail-ot0-x22f.google.com [IPv6:2607:f8b0:4003:c0f::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B35B312420B; Thu, 4 Jan 2018 15:13:47 -0800 (PST)
Received: by mail-ot0-x22f.google.com with SMTP id h2so2634297oti.5; Thu, 04 Jan 2018 15:13:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h3u67BT3djpqlaq5oA2nlhW0GW/jrBzPUS4zyb1S9NQ=; b=TZcUuSsEftS5ltSbyzJYktrcT4kiN1YPizqDpl//Z2p+LDKn6EXEzBa+/2xc5E8khp aROk4TZcTDlv4UaMmvX5rM10jhoikWdq4+kdgPmNlwZjftFTcnvJZHD4wmi2mr7Rp98o 3ZOBvn3GKOGtT4awizVBXRt7KDHumAJO3lheZCK0XgWkuVgos0TzIv4uZ0EQsaukjyR+ iE80Zj8clBQD2kcyb9ji6/CeA6PdJ8T+LESVJWPidfx/fjF5ADPYnf0jcGAeJ6Pf69b+ 7irvJNOyNKvKIoOxs6Cm+ZR0egiU8XCEscKeyCiLlR3TMLwhEL1h71c3owLsTPy8E/86 VFJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h3u67BT3djpqlaq5oA2nlhW0GW/jrBzPUS4zyb1S9NQ=; b=P1DMg4xsEDVKe54SU/h9sLqjYmdyBaL6BXBfOFflKAdRFsg8prCRd8jwuv/3qYDqey DLZXD791kp+Na3pC5lT+Ese/gffT+0IQcR77gnQOJHZCl8IoY2EW0CAT/bHVQKMvh5Bq efMe51oXMJlx2owjRPQK69JLLNAvbPLAF0AT8+fVCvzNo7Tka2OpV2ATiiIta6Y+wn8D UzGJyQWvtfA5h9i3WiWFFoR10tIzA2U22JeydDDtmB+o748+KdGLRUJ7gDg8s1Rh7rQL 3sVqyhnNR2posZoflZ1bgoIBDTXk/08GKN6U8ddL926u9hCo/eaQtbch4p2w3KiltO38 6FhA==
X-Gm-Message-State: AKwxytcxQXcAceoXN2iF2td+BDUL+dGKD7v5y5u+Z/s7snr3krXktCX0 XRSbPsEDpMN/0vkEafPUcAnvDk4ip2FxloIJ2z0M/Q==
X-Google-Smtp-Source: ACJfBoshOzNC2P4er3Fip4hgjVlz2XaHFjHH8GbbUJ2MEy3oQ6A8AoMy1FGds98NCTv4oOBeYBHoiPZiVXrFGSYIMxc=
X-Received: by 10.157.19.45 with SMTP id f42mr731732ote.139.1515107627020; Thu, 04 Jan 2018 15:13:47 -0800 (PST)
MIME-Version: 1.0
Received: by 10.168.53.129 with HTTP; Thu, 4 Jan 2018 15:13:31 -0800 (PST)
In-Reply-To: <201712111629.vBBGTxIp043810@givry.fdupont.fr>
References: <201712111629.vBBGTxIp043810@givry.fdupont.fr>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Thu, 04 Jan 2018 18:13:31 -0500
Message-ID: <CAF4+nEHJE_p=HqJKB--4T0ZS1Qd5j3PfyzbnhHdHkUD2doCowg@mail.gmail.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-trill-centralized-replication.all@ietf.org
Content-Type: multipart/alternative; boundary="001a1145d1c0e7b6d00561fb7b8b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/jKAT7mH9N4Bjy6MloXPSCHoN2IQ>
Subject: Re: [Gen-art] review of draft-ietf-trill-centralized-replication-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jan 2018 23:13:53 -0000
Hi Francis, I believe your comments are resolved in the -10 version of this draft. I expect a -11 version to be posted soon with a few other minor improvements. So, you might want to check the current -10 version or the -11 version when it is posted. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 155 Beaver Street, Milford, MA 01757 USA d3e3e3@gmail.com On Mon, Dec 11, 2017 at 11:29 AM, Francis Dupont <Francis.Dupont@fdupont.fr> wrote: > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-trill-centralized-replication-10.txt > Reviewer: Francis Dupont > Review Date: 20171209 > IETF LC End Date: 20171212 > IESG Telechat date: unknown > > Summary: Ready with Issues > > Major issues: None > > Minor issues: C-nickname is used before being defined > > Nits/editorial comments: > - Abstract page 1: please expand the RPF abbrev > > - Abstract page 1 and 1 page 3: Mutlicast -> Multicast > > - ToC page 2 and 3 title page 5: > Centralized Replication Solution Overview -> Centralized replication > solution overview > (mainly for consistency) > > - ToC page 2 and 6 title page 8: a edge group -> an edge group > (It seems both are accepted?) > > - ToC page 2 and 9 title page 12: I have a little concern with the > CMT abbrev which BTW is not in the RFC Editor list > (https://www.rfc-editor.org/materials/abbrev.expansion.txt) > I suggest to add "(RFC 7783)" after CMT > > - ToC page 3 and 10 title page 13: > Network Upgrade Analysis -> Network upgrade analysis > (still consistency) > > - 1 page 3: at the first read it was not obvious that RBv is just the > notation for a virtual RBridge. I suggest to do the same than for RBn, > i.e., to change the first occurrence from RBv to (RBv). > > - 1 page 3: my US English spell checker does not accept learnt > (it wants learned ???) > > - 2 page 4: please move from RFC 2119 to its update RFC 8174 > > - 2 page 4: LAALP -Local -> LAALP - Local > > - 3 page 5 title: cf ToC comment > > - 3 page 5: " BUM packet should be..." an example of a lower case > "should" which can take benefit of RFC 8174 (vs RFC 2119). Note > there are two other "should"s next page and a "may" in 4 (and other > lower case keywords). > > - 3 page 6: C-nickname is used without explanation of what it is > (the explanation is in 9 page 12 so far later). Some words and/or > a forward reference should solve the issue. > > - 8 page 11 (last line): nodes/ multiple -> nodes / multiple > > - 9 page 12 title: cf ToC comment > > - 9 page 12: CMT -> Coordinated Multicast Trees (CMT) > (at the first occurrence, i.e., first line after figure 2) > > - 9 page 12: the definition of C-nickname is here. > BTW you use both C-flag and C-nickname flag, the second is not > very correct from a language point of view but is very clear > technically so I shan't object if you keep it. > > - 10 page 13 title: cf ToC comment > > - 11 page 13: psudo -> pseudo > > - Authors' Addresses page 17 (two occurrences): China -> PR China > (or you can switch all countries to ISO IS 3166 two letter codes) > > Regards > > Francis.Dupont@fdupont.fr >
- [Gen-art] review of draft-ietf-trill-centralized-… Francis Dupont
- Re: [Gen-art] review of draft-ietf-trill-centrali… Susan Hares
- Re: [Gen-art] review of draft-ietf-trill-centrali… Donald Eastlake
- Re: [Gen-art] review of draft-ietf-trill-centrali… Donald Eastlake