Re: [Gen-art] Gen-ART review of draft-ietf-appsawg-file-scheme-14
Matthew Kerwin <matthew.kerwin@qut.edu.au> Wed, 07 December 2016 02:08 UTC
Return-Path: <matthew.kerwin@qut.edu.au>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80430129630 for <gen-art@ietfa.amsl.com>; Tue, 6 Dec 2016 18:08:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id StvOPlVTC9uX for <gen-art@ietfa.amsl.com>; Tue, 6 Dec 2016 18:08:46 -0800 (PST)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0084.outbound.protection.outlook.com [104.47.37.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5AE9412955B for <gen-art@ietf.org>; Tue, 6 Dec 2016 18:08:46 -0800 (PST)
Received: from MWHPR01MB2670.prod.exchangelabs.com (10.172.165.8) by MWHPR01MB2669.prod.exchangelabs.com (10.172.165.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9; Wed, 7 Dec 2016 02:08:44 +0000
Received: from MWHPR01MB2670.prod.exchangelabs.com ([10.172.165.8]) by MWHPR01MB2670.prod.exchangelabs.com ([10.172.165.8]) with mapi id 15.01.0761.017; Wed, 7 Dec 2016 02:08:44 +0000
From: Matthew Kerwin <matthew.kerwin@qut.edu.au>
To: Christer Holmberg <christer.holmberg@ericsson.com>, Alexey Melnikov <aamelnikov@fastmail.fm>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-appsawg-file-scheme-14
Thread-Index: AQHSSiwdHMurdzVghEWp7tWnuH9XBKDvyzOAgAAaWYCAAAm0gIABZPIAgApkn6s=
Date: Wed, 07 Dec 2016 02:08:44 +0000
Message-ID: <MWHPR01MB267051AD43A6869B9FD1CBE5BE850@MWHPR01MB2670.prod.exchangelabs.com>
References: <D463284D.13C45%christer.holmberg@ericsson.com> <1480417219.3456208.802284185.4E1FFAE0@webmail.messagingengine.com> <D46342E0.13C89%christer.holmberg@ericsson.com> <1480424961.3484823.802399049.16AD2DC8@webmail.messagingengine.com>, <D464779E.13DC0%christer.holmberg@ericsson.com>
In-Reply-To: <D464779E.13DC0%christer.holmberg@ericsson.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=matthew.kerwin@qut.edu.au;
x-originating-ip: [25.164.163.132]
x-ms-office365-filtering-correlation-id: 4c2ca1a8-bb3a-411b-66ae-08d41e45f8da
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR01MB2669;
x-microsoft-exchange-diagnostics: 1; MWHPR01MB2669; 7:BRTgqhHiy1Ae/UvrGr3YFXy+l7DJ1Y5oraDBXJyYf6I6jUEqu++DOLNQmF5+DfkbYEUqQ4rluHu8N5tGLnkiZDH25DIxGaSIGL9JqoEAFDie2pdiA9ehH7h/jD4wHvxWcQ0peTAYsaA75+Qy+LsgAgq7Ek4afB/Q73IRzckQeolOX+8SFdsJmkD1kmGnPrnbL+5OKrJVF4JlIjJWuwaNb8q4yu0j0qdFreZg4CkjTbGFxXXQ03JxkmCpFR5f174vy0WneG07exp9DrE6KWiFtJN829W0qVFHiQXh1ZiPjKK1XFQFBlEfBacsO0nOSxqOSJVTdpuR0bgTCxzbPv1c5qoOQZhjvzEroPgYmmCHRpef8r71F1Em3dikR1Li8iPIci512rVGdsFXTOiYeUyyFNd72k5VgKTBuvwaj0fdZAd/x0nv1TMvyvmqmPaQmA3nzTlTL05UcxaHN3H+u8iN6A==
x-microsoft-antispam-prvs: <MWHPR01MB26691880A28EB03D0C0CFEADBE850@MWHPR01MB2669.prod.exchangelabs.com>
x-exchange-antispam-report-test: UriScan:(37575265505322)(54900358751275);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:MWHPR01MB2669; BCL:0; PCL:0; RULEID:; SRVR:MWHPR01MB2669;
x-forefront-prvs: 01494FA7F7
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(24454002)(51914003)(199003)(189002)(39410400001)(97736004)(229853002)(2950100002)(106356001)(5001770100001)(189998001)(101416001)(74482002)(4326007)(42882006)(81156014)(66066001)(2906002)(8936002)(38730400001)(106116001)(92566002)(105586002)(6116002)(122556002)(3846002)(561944003)(88552002)(102836003)(33656002)(81166006)(86362001)(2900100001)(8676002)(77096006)(74316002)(39450400002)(345774005)(68736007)(305945005)(7736002)(6506006)(93886004)(39860400001)(5660300001)(7696004)(230783001)(2501003)(39840400001)(7846002)(54356999)(3280700002)(76176999)(39850400001)(9686002)(50986999)(3660700001)(8666005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR01MB2669; H:MWHPR01MB2670.prod.exchangelabs.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: qut.edu.au does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: qut.edu.au
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2016 02:08:44.0390 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dc0b52a3-68c5-44f7-881d-9383d8850b96
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2669
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/joMSI0-7CBgsbOfOjTdfM4J6F2E>
Cc: "draft-ietf-appsawg-file-scheme.all@tools.ietf.org" <draft-ietf-appsawg-file-scheme.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-appsawg-file-scheme-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 02:08:50 -0000
Hi Christer, Thanks for the review, it dovetails nicely with other feedback I've received. Elsewhere this text has been suggested for the abstract: > This document provides a full specification of > the "file" Uniform Resource Identifier (URI) scheme, replacing the > very brief definition in Section 3.10 of RFC 1738. Does that go some way to resolve the ambiguity there? It doesn't use the words "update" or "obsolete" but it seems to me that it says what it needs to. The acknowledgements section has also been flagged, and I will work on updating that. The remaining chunky bit of feedback I'm yet to address is about what non-backwards compatible changes are being made. I'll have to redo a bit of research to address this, to make sure I don't inadvertently lie, but it's definitely been taken on board. I'm hoping to say something along the lines of: "it aims to be backwards compatible except where incremental changes are inherited from specifications published since RFC 1738." That's pretty much what it says in Appendix A. Cheers -- Matthew Kerwin | Queensland University of Technology | matthew.kerwin@qut.edu.au | CRICOS No 00213J ________________________________ From: Christer Holmberg <christer.holmberg@ericsson.com> Sent: 30 November 2016 20:26:54 To: Alexey Melnikov; gen-art@ietf.org Cc: draft-ietf-appsawg-file-scheme.all@tools.ietf.org Subject: Re: Gen-ART review of draft-ietf-appsawg-file-scheme-14 Hi, >>Thanks for your reply! It clarifies my issues. >> >>However, for other outsiders like me, I think it would be really good to add some text about that in the draft. Explicitly say that the draft updates RFC 1738 by obsoleting the files URL scheme, defines a new URI scheme based on the procedures in RFC 3986. Because, as an outsider, it’s really difficult >>for me to figure that out, and e.g., determine what/if I need to read RFC 1738 etc. Also, the text should not only cover the technical changes (syntax >>etc), but also if there are changes regarding the usage etc. > >I think this is fair. I will let the editor come up with some proposal. Thanks! I also suggest to remove the “derived” text from the Acknowledgements. Of course, the authors of RFC 1738 can still be acknowledged :) Regards, Christer From: Alexey Melnikov <aamelnikov@fastmail.fm<mailto:aamelnikov@fastmail.fm>> Date: Tuesday 29 November 2016 at 14:00 To: Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>>, "gen-art@ietf.org<mailto:gen-art@ietf.org>" <gen-art@ietf.org<mailto:gen-art@ietf.org>> Cc: "draft-ietf-appsawg-file-scheme.all@tools.ietf.org<mailto:draft-ietf-appsawg-file-scheme.all@tools.ietf.org>" <draft-ietf-appsawg-file-scheme.all@tools.ietf.org<mailto:draft-ietf-appsawg-file-scheme.all@tools.ietf.org>> Subject: Re: Gen-ART review of draft-ietf-appsawg-file-scheme-14 Hi Christer, Thank you for your comments. On Tue, Nov 29, 2016, at 10:34 AM, Christer Holmberg wrote: I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> Document: draft-ietf-appsawg-file-scheme-14.txt Reviewer: Christer Holmberg Review Date: 29 November 2016 IETF LC End Date: 6 December 2016 IETF Telechat Date: N/A Summary: I don’t have any major comments regarding the technical content of the draft. However, as seen in my comments below, I fail to see exactly how RFC 1738 is updated. Major Issues: None Minor Issues: The Abstract text says: "This document specifies the "file" Uniform Resource Identifier (URI) scheme, replacing the definition in RFC 1738.” Q1: I suggest that the text should say that the document “updates the file URI scheme defined in RFC 1738”. This is not really useful, because RFC 1738 was already obsoleted (but file URI definition was never update). Q2: Related to Q1, in RFC 1738 the “file” scheme is defined as a URL, but in the draft it is defined as a URI. What is the reason for that? The term URL (Uniform Resource Locator) was replaced by a more generic URI (Uniform Resource Identifier). Historically, some URIs were "locators" and some were "names", but more recently a lot of URIs exhibit both qualities. Thus the term URL should not be used. Q3: Related to Q1, it is unclear exactly what parts of the RFC 1738 scheme is updated. For example, is the syntax updated, is the usage scope updated etc? The second paragraph says something, but it is unclear whether it’s related to the actual update, or whether it just provides some information regarding the usage of the scheme. Everything is updated. The original RFC doesn't need to be read. The Acknowledgements section says that the draft is “derived” from RFC 1739. What does “derived” mean? I think there should be clear and explicit text about exactly what is updated. Q4: Related to Q3, the text says that things are backward compatible in “most situations”. I think a little more text is needed, and e.g., examples of non-backward compatibility. Q5: I see that RFC 1738 is only a Informative Reference. Someone can correct me if I’m wrong, but doesn’t it have to be Normative since the draft is normatively (I assume) updating the RFC? No (as per above). Editorial Issues: None
- [Gen-art] Gen-ART review of draft-ietf-appsawg-fi… Christer Holmberg
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Christer Holmberg
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Christer Holmberg
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Matthew Kerwin
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Christer Holmberg
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Matthew Kerwin
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Jari Arkko
- Re: [Gen-art] Gen-ART review of draft-ietf-appsaw… Christer Holmberg