Re: [Gen-art] Genart last call review of draft-ietf-intarea-frag-fragile-13

Fred Baker <fredbaker.ietf@gmail.com> Fri, 05 July 2019 17:01 UTC

Return-Path: <fredbaker.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78BE11200EB; Fri, 5 Jul 2019 10:01:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.979
X-Spam-Level:
X-Spam-Status: No, score=-1.979 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, T_FREEMAIL_RVW_ATTCH=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EOl3c6ytstJ4; Fri, 5 Jul 2019 10:00:59 -0700 (PDT)
Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 432E212008C; Fri, 5 Jul 2019 10:00:56 -0700 (PDT)
Received: by mail-oi1-x22b.google.com with SMTP id g7so7580412oia.8; Fri, 05 Jul 2019 10:00:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=axBXiRTtzjrB+laLhLrSvRGg2qg2ibxOrSu8cXEjG3g=; b=fA5FIGG1S13oahbOWfPcC+UZvIiVlgibftmLq6ngPVW0ZhWK+egdUCrxro8X0TX9Xa zJ6wAGNMAAZFiBqJCmWHU6gVlKd0uyEhJIkIRdTkh4NuY/UaiMxPtfwCCUnfDhE0cYfE /Vdo/XcYm97m2d6ubwxuKzF514hibNAis6Rd90NRRf8VqWSfaR/WTqe0mRn5yTPnRxqd FTCRpYOO/rGVY4cn2dzGBj/fwkrMKeM9VCsnvLikxSbkb651Cwa/EQDUDeR6MyfczAP5 Md0FFQtyr3XkV/cF2/k20I48UCO7NAkZU0mbSqEXfpCBHIsOrWOCe6u02LvShdMAHT6A iDeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=axBXiRTtzjrB+laLhLrSvRGg2qg2ibxOrSu8cXEjG3g=; b=N052/scvWUJGJf7BKjCIOgjR4sciYdXFsTB4C+VhAH8pNIAqT2VRSPFOlR43tvQ55P +gbVZQoiPmQfFixzn2SQ8d79E9phzLg8dTQQhxgeFyxJ1ao4HvI7U916x2ZCgfj5DCbB AYjUr/uVzeTB2Gmi3eWbX6L+N5BoLk87Zjg3AAC2UhmHAtmsz+lbKsoFYJqOZHtRzq+v ABy34vxdyshvhH/1eMouwOOrdoCjiUD3OuQA+iOYzUJh1RUMbSs5vOUVaiMWL3I5UXWJ m+iqPVrMgjgWNYPBUhOmlgzN9fSFvA7TPjofIqkxztoQHiSJvcblhq5ZXNuXDhfV0Atq zifQ==
X-Gm-Message-State: APjAAAXjGcQPxoHOOwv4bUZh5oov07hfwmWd9wEBvvdZrJlnGq3fIrxT mokMIITxHCxQJRJngUJvuw4=
X-Google-Smtp-Source: APXvYqwyE0+np/9WGjmmWmta8+C57HchPYmz6D/RTVHkpKkbGxGopvGmejEyQjG3Ev3nBpoPXu5ALA==
X-Received: by 2002:aca:4309:: with SMTP id q9mr2686551oia.74.1562346054860; Fri, 05 Jul 2019 10:00:54 -0700 (PDT)
Received: from ?IPv6:2600:8802:5903:df16::1006? ([2600:8802:5903:df16::1006]) by smtp.gmail.com with ESMTPSA id o26sm1723723otl.34.2019.07.05.10.00.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 10:00:53 -0700 (PDT)
From: Fred Baker <fredbaker.ietf@gmail.com>
Message-Id: <BC6D2B1B-BDD3-4130-8C8C-5BA4C759EB11@gmail.com>
Content-Type: multipart/mixed; boundary="Apple-Mail=_59221C9F-7C59-4649-9E91-E9D90B717DCD"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3564\))
Date: Fri, 05 Jul 2019 10:00:51 -0700
In-Reply-To: <156227327196.12217.1279652184062580039@ietfa.amsl.com>
Cc: gen-art@ietf.org, draft-ietf-intarea-frag-fragile.all@ietf.org, int-area@ietf.org, ietf@ietf.org
To: Pete Resnick <resnick@episteme.net>
References: <156227327196.12217.1279652184062580039@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3564)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/kA8abpujk5b0yTSOjK3Euqcy93k>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-intarea-frag-fragile-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jul 2019 17:01:03 -0000

Thanks for your review. I have some points I'd like to discuss in order to understand better how to fix them.

> On Jul 4, 2019, at 1:47 PM, Pete Resnick via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Pete Resnick
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-intarea-frag-fragile-13
> Reviewer: Pete Resnick
> Review Date: 2019-07-04
> IETF LC End Date: 2019-07-04
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: A document so well-written that even this application-layer idiot
> could follow along easily. Thanks for that. I see no significant issues with
> this document going forward as a BCP; just a few editorial bits.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> In Section 2.1 and 2.2, Instead of "set to one" and "set to zero", it would
> read easier with "set to (1)" and "set to (0)", or some similar construction.

That seems to me to be stylistic - I'm not at all sure what makes "(1)" more readable than "one". I'm making the change, but I can't begin to fathom how it improves the document.

> Section 3 is in an odd place. I'd say either move it up to the top, or put it
> down in section 7.

Moved to section 1.

> 4.2 mentions virtual reassembly. Virtual reassembly applies to 4.1, 4.3, and
> 4.4 as well. Perhaps moving the discussion of virtual reassembly up to the top
> of 4 would make more sense.

I think you're inferring the applications to 4.1, 4.3, and 4.4. 4.1, for example, makes rather a point that in the absence of virtual reassembly the router will make different routing decision. (I could say "incorrect", but the issue is that it is in fact making a correct decision in what could be argued to be the wrong context). I'll see what I can do with this, but I'm going to have to ask you to look at the diff and see whether you agree with the change.

> In 4.5, insert "duplicate IDs resulting in" after prevent. It took me a bit to
> figure out what this was referring to. Also, change "are not easily
> reproducible" to "do not occur as frequently"; I think it reads better.

Ack

> And just to yell into the wind: Section 7.3 seemed a little wimpy to me, but I
> can't for the life of me figure out how to make it any stronger or more likely
> to be listened to. End of pointless yelling.

Ron started out with "let's just deprecate Internet Layer Fragmentation entirely." Good luck, great way to create an RFC that will be completely ignored. Ain't Gonna Happen In Practice. We backed off to this in a quest for comments that could actually have an impact. Agree that they don't have teeth. 

Would you kindly review the attached diff and comment on the changes? I'll wait for your comments before uploading.
--------------------------------------------------------------------------------
The fact that there is a highway to hell and a stairway to heaven is an interesting comment on projected traffic volume...