Re: [Gen-art] Gen-ART Last Call review of draft-ietf-teas-interconnected-te-info-exchange-05

"Adrian Farrel" <adrian@olddog.co.uk> Wed, 04 May 2016 11:05 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24C3912D18E; Wed, 4 May 2016 04:05:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.62
X-Spam-Level:
X-Spam-Status: No, score=-2.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t265typnZbYX; Wed, 4 May 2016 04:05:24 -0700 (PDT)
Received: from asmtp1.iomartmail.com (asmtp1.iomartmail.com [62.128.201.248]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 13BB712D175; Wed, 4 May 2016 04:05:23 -0700 (PDT)
Received: from asmtp1.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id u44B5KLs027965; Wed, 4 May 2016 12:05:20 +0100
Received: from 950129200 (jplon-nat11.juniper.net [193.110.55.11]) (authenticated bits=0) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id u44B5IDv027940 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 4 May 2016 12:05:19 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Brian E Carpenter' <brian.e.carpenter@gmail.com>, draft-ietf-teas-interconnected-te-info-exchange.all@ietf.org, 'General Area Review Team' <gen-art@ietf.org>
References: <d689965e-599b-f048-be3e-eeee7f341005@gmail.com>
In-Reply-To: <d689965e-599b-f048-be3e-eeee7f341005@gmail.com>
Date: Wed, 04 May 2016 12:05:15 +0100
Message-ID: <06b601d1a5f4$d74c7350$85e559f0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQGi7/FEKhetGjiVFrGEirdzEYFv7qAF7mWg
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.0.0.1202-22300.006
X-TM-AS-Result: No--19.533-10.0-31-10
X-imss-scan-details: No--19.533-10.0-31-10
X-TMASE-MatchedRID: ZFzIhWOuIzunykMun0J1wvHkpkyUphL9oX1+aAI0WN6MbDv6XkOHDaee gI8Z8ffsA1p3FDc5W2J/AaYicHwlVR7kI5Tt00LCcFEiuPxHjsXAWTziWGaDPCy6DFF5hapmVaC zimhHM1EuVV6UypWSD/VQugEbwseudFThlXcE9zA4jxClIfsQfkyQ5fRSh265MKZRiezcUtOeCt 5tDZu9xYFWrNQk+c9oVt1XAHNfSsFA90k3OkvQzkyM6zQm0+tqW1VjHhznmWi29Q2yF5u4VBMGt PkUyFbdVGV6cC6oxrq+PLMV3BTV1aI7ddHYl7MNFhQfbPNnjNvomPrNi98UBNqCxkzSpW/XxyPL 4T3avQqIy2iALrXbVUvLONpZwZB8u1qgLrB1rYyUa50su1E7Wye0wHaFmKTnsp5O052MzLpmKVV GR/lKLpU0IbPM7bN0kbbXzvAPDtVsGQsY/Fc7uwBYUD3h/NH/Mr1BLPj7P4e1eX0jEQ9c6jC0pJ IQUiJOTYeD6lWLulndDnv5LqXEXgKQ3dv/tOt57DzBuedLDxugBWRVHG2+kW9JSfwtPQQmo8WMk QWv6iWhMIDkR/KfwI2j49Ftap9EkGUtrowrXLg=
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/kMwMDZ8nU8t4dKKI1ImN3l6YdbY>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-teas-interconnected-te-info-exchange-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 11:05:27 -0000

Hi Brian,

Thanks for the time.

> Major issues:
> -------------
> 
> > 5.  Building on Existing Protocols
> 
> I find it hard to read the introduction to this section and understand
> why the draft is proposed for BCP rather than Informational. 

I will punt this question direct to the responsible AD since the authors brought the document forward as Standards Track and were "persuaded" by the WG chairs and responsible AD that it was a BCP as written. 

The only hint I will offer is that the authors would be grumpy about changing the content of the document to fit the publication track. Let's choose the track to fit the document :-)

<snip>

[except to note that the presence of normative references has nothing to do with whether a document is itself normative!]
 
> Minor issues:
> -------------
>
> > 1.  Introduction
> ...
> >  Such networks
> >  are often referred to as Domains [RFC4726] and we adopt that
> >  definition in this document: viz.
> >
> >    For the purposes of this document, a domain is considered to be any
> >    collection of network elements within a common sphere of address
> >    management or path computational responsibility.  Examples of such
> >    domains include IGP areas and Autonomous Systems.
> 
> Section 1.1.4. (Domain) repeats the definition in different words.
> I think it would be better to fold the text from the Introduction
> into 1.1.4.

I disagree.
I believe that an introduction needs to be stand-alone text without requiring reference to a terminology section that has not yet been read.

The text in the Introduction is a direct quote and cannot be modified.
The text in 1.1.4 is as near as possible to being a copy within the rules of abbreviation expansion.
Effectively the two definitions are identical.

> > 2.2.  Client-Server Networks
> 
> It may be considered a term of art in TE, but I found the phrase "server
> network" very confusing at first. In my world, it means "a network containing
> servers" but here it appears to mean "underlay network" or possibly "service
> network". Anyway, if you want to use this phrase, I suggest defining it
> precisely before using it.

It is certainly a term of art in multi-layered networks. I did not do a comprehensive search, but found it in RFCs from 2005. You may also find it used a lot in the ITU-T where they have some experience of transport networks (hoping that in your world a transport network is not a TCP network :-)

I think that you are saying that the description at the start of Section 2.2 (that provides as a starting point the client-server relationship between networks) is not enough. I think we can manage a very brief definition for you to go in Section 1.1. Probably something like...

Server Network

A Server Network is a network that provides connectivity for another network (the Client Network) in a client-server relationship. A Server Network is sometimes referred to as an underlay network.

Client Network

A Client Network is a network that uses the connectivity provided by a Server Network. A Client Network is sometimes referred to as an overlay network.

> Also, the text switches to "server domain" and uses "server layer". Then in
> Figs 4, 5 and 6 the server domain has become "core domain". This terminology
> is all a bit inconsistent.

Yes, this is sloppy chat. Will scrub it. Ditto "client".

> > 4.4.  Requirements for Advertising Links and Nodes
> ...
> >  This requires a routing protocol running between the nodes in the
> >  abstraction layer network.  Note that this routing information
> >  exchange could be piggy-backed on an existing routing protocol
> >  instance, or use a new instance (or even a new protocol).
> 
> It isn't obvious to me that it could be piggy-backed on an existing
> instance in the general case; wouldn't that sometimes lead to duplicate
> or ambiguous routes?
> 
> A sentence in section 4.5 seems to suggest that ambiguity is very
> possible:
> 
> > That is, one address may mean one thing in the
> > client network, yet the same address may have a different meaning in
> > the abstraction layer network or the server network.
> 
> Address mapping plus piggy-backed routing seems like a recipe
> for disaster.

I think this is resolved by the insertion of "...(subject to different switching capabilities applying to the links in the different networks, or to adequate address space separation)..." in the quoted text from 4.4 after "... could be piggy-backed on an existing routing protocol instance".

> Nits
> ----
> 
> > Figure 16 : A Network Comprising Three Peer Networks
> 
> There's a missing | on node B2

ack

> > 10.3.  Managing Interactions of Abstraction Layer and Server Networks
> ...
> 
> >  The abstraction layer network needs a mechanism to tell the server
> >  This mechanism could also include the ability to request additional
> >  connectivity from the server layer, ...
> 
> The first sentence of this paragraph is truncated.

good catch

> > 12.  Security Considerations
> ...
> > Thus, the mechanisms in this document for
> > inter-domain exchange of control plane messages and information
> > naturally raise additional questions of security.
> >
> > In this context, additional security considerations arising from this
> > document relate to the exchange of control plane information between
> > domains.
> 
> Those two sentences seem to say exactly the same thing.

We like to demonstrate how seriously we take security by saying everything twice.
We like to demonstrate how seriously we take security by saying everything twice.

Once again, thanks for a very detailed reading.

Adrian