[Gen-art] Gen-ART Last Call review of draft-ietf-i2rs-yang-l3-topology-08

Paul Kyzivat <pkyzivat@alum.mit.edu> Fri, 13 January 2017 19:50 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72C69129DC4 for <gen-art@ietfa.amsl.com>; Fri, 13 Jan 2017 11:50:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.935
X-Spam-Level:
X-Spam-Status: No, score=-1.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iRngodpiTkNB for <gen-art@ietfa.amsl.com>; Fri, 13 Jan 2017 11:50:10 -0800 (PST)
Received: from resqmta-po-10v.sys.comcast.net (resqmta-po-10v.sys.comcast.net [IPv6:2001:558:fe16:19:96:114:154:169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2BF74129DC2 for <gen-art@ietf.org>; Fri, 13 Jan 2017 11:50:10 -0800 (PST)
Received: from resomta-po-13v.sys.comcast.net ([96.114.154.237]) by resqmta-po-10v.sys.comcast.net with SMTP id S7phcHLrHkJTyS7rUckGh7; Fri, 13 Jan 2017 19:50:08 +0000
Received: from [192.168.1.110] ([73.186.127.100]) by resomta-po-13v.sys.comcast.net with SMTP id S7rTc4hY7xumkS7rUc8Sz0; Fri, 13 Jan 2017 19:50:08 +0000
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-i2rs-yang-l3-topology.all@ietf.org
Message-ID: <5f018277-3875-6eec-9235-fbae998aa0c7@alum.mit.edu>
Date: Fri, 13 Jan 2017 14:50:07 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/km0saKXjBmBRwJkZu9wkEK-1C8U>
Cc: General Area Review Team <gen-art@ietf.org>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-i2rs-yang-l3-topology-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 19:50:11 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area 
Review Team (Gen-ART) reviews all IETF documents being processed by the 
IESG for the IETF Chair. Please treat these comments just like any other 
last call comments. For more information, please see the FAQ at 
<​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-i2rs-yang-l3-topology-08
Reviewer: Paul Kyzivat
Review Date: 2017-01-13
IETF LC End Date: 2017-01-17
IESG Telechat date:

Summary:

This draft is on the right track but has open issues, described in the 
review.

Disclaimer:

I started this review without any knowledge of YANG modeling. So the 
sort of review I can do is superficial.

Issues:

Major: 0
Minor: 2
Nits:  1

(1) Minor:

In sections 4 & 5, one of the termination-point-types is called 
"unnumbered", and contains an "unnumbered-id". But the value contained 
here is in fact a uint32 *index* value. This clearly *is* a number. So, 
ISTM that "unnumbered" is a misleading name for this element.

I gather it designates a termination point that is identified by this 
index rather than by a name or an ip-address. If so, a better name might 
be "index" or "indexed".

(2) Minor:

The examples in section 6.2 seem very helpful. But is it really 
necessary to fill in so much detail? The amount of detail seems to make 
it overly difficult to grasp the essential features. For instance, the 
contact and description information could be shortened.

(3) NIT:

In section 1, s/augments general network/augments the general network/