[Gen-art] Last Call review of draft-ietf-trill-oam-mib-06
Tom Taylor <tom.taylor.stds@gmail.com> Sat, 15 August 2015 01:46 UTC
Return-Path: <tom.taylor.stds@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2DD31B2B56; Fri, 14 Aug 2015 18:46:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fB1hkPdXNZvr; Fri, 14 Aug 2015 18:46:34 -0700 (PDT)
Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A8CF1B2B54; Fri, 14 Aug 2015 18:46:34 -0700 (PDT)
Received: by iodb91 with SMTP id b91so101826536iod.1; Fri, 14 Aug 2015 18:46:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:message-id:date:user-agent:mime-version :content-type:content-transfer-encoding; bh=I5wX0ir9t0Vyhja8COzkpUzvGNWLpnk+5LxexsFWQWY=; b=t03wJyplktHLIHZCAvj9hDmZmvL7rFJrA+0TvERkIxo0TE3YlLh1S2pq0X5iY7wmSw NJRPIik1wjBDpLnO+3NrbbgdXbruxIh9kh7obpBS8sI32fY0grP2zpxDMXkbVjYU6v8/ 1/0J5wJQFHke/+B/nUTKiUpPXWhZi4hrwiA8EOK2j6FcKm87UlInHlmXusGiqGugYAIh o22dOsm/xuh4oyN4HgCjm/CxKoN1k55lJVD3AbPB8/YD3e4dshka7QuKVgmy3tkMAk0a YnJcramzzIezJYRJHfBmLvtZjv/FM5Ymfw83baKMltp4L4hdETjomU7rSniOIx152fPf Jcaw==
X-Received: by 10.107.25.80 with SMTP id 77mr56417299ioz.62.1439603193884; Fri, 14 Aug 2015 18:46:33 -0700 (PDT)
Received: from [192.168.1.135] (dsl-173-206-13-140.tor.primus.ca. [173.206.13.140]) by smtp.gmail.com with ESMTPSA id au6sm8606igc.0.2015.08.14.18.46.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Aug 2015 18:46:33 -0700 (PDT)
From: Tom Taylor <tom.taylor.stds@gmail.com>
To: Gen Art <gen-art@ietf.org>, "Deepak Kumar (dekumar)" <dekumar@cisco.com>, Samer Salam <ssalam@cisco.com>, Donald Eastlake <d3e3e3@gmail.com>, trill-chairs@ietf.org, Alia Atlas <akatlas@gmail.com>, The IESG <iesg@ietf.org>
Message-ID: <55CE99F8.1090100@gmail.com>
Date: Fri, 14 Aug 2015 21:46:32 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/l6JwAM6wjJxXJQjT18gGFEMAS04>
Subject: [Gen-art] Last Call review of draft-ietf-trill-oam-mib-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Aug 2015 01:46:36 -0000
Resending just to note that I got a bounce from Tissa's address. Tom Taylor I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Sorry for the late review, but there was a pile of reading to do in preparation. I admit I did not read the whole 1800 pages of 802.1Q. Tom Taylor Document: draft-ietf-trill-oam-mib-06 Reviewer: Tom Taylor Review Date: 2015-08-14 IETF LC End Date: 2015-08-13 IESG Telechat date: 2015-08-20 Summary: Not quite ready. Minor issues and editorials/nits. Major issues: Minor issues: 1) Section 5.2 states that IEEE8021ServiceSelectorType has two values. In fact, 801-1Q-2014 enumerates more than that. I'd suggest a slight change in wording to reflect this: OLD IEEE8021-TC-MIB defines IEEE8021ServiceSelectorType with two values: - 1 representing a vlanId, and - 2 representing a 24 bit isid. NEW The IEEE8021-TC-MIB definition of IEEE8021ServiceSelectorType includes the two values: - 1 representing a vlanId, and - 2 representing a 24 bit isid. 2) Section 6.2 indicates that TRILL OAM has no support for Link Trace Message/Reply. Perhaps text could be added to say why this is so (i.e., that Path Trace has been substituted, as indicated in Sec. 10 of RFC 7455, and has been supplemented by Multi-destination Tree Verification Message/Reply). 3) "Reference Overview" in the MIB module header indicates that the TRILL MIB module refers to the original CFM document, IEEE 802.1ag-2007, instead of IEEE 802.1-Q-2014. Why the older starting point? 4) Has any thought been given to including an indication of when the counters were last reset (e.g, due to restart)? 5) description of trillOamMepTxPtmStatus refers to the MEP Initiator State Machine. Reference should include pointer to the description of this state machine. Where is it defined? -- not in RFC 7455. Similar comment regarding the description of trillOamMepTxMtvmStatus. 6) Description of trillOamMepTxPtmMessages: there is no indication in RFC 7455 of how this limit is used. More text is needed here. Does number of hops affect the count of transmitted messages against this limit? Similar comment regarding the description of trillOamMepTxMtvmMessages. 7) Surely this document has normative dependencies on 802.1Q and the LLDP-MIB, for which no reference is given, BTW. Nits/editorial comments: 1) Under "Abbreviations" in the MIB module header, definition of SNMP Agent, need to spell out NE. Similarly, spell out EMS and NMS in the next definition. 2) Description of trillOamMepTable: s/rowsare/rows are/ 3) in the descriptions of trillOamMepPtrFlag and trillOamMepPtrErrorCode, incorrect section numbers for RFC 7455 are given in the references. Should be 8.4.3? 4) Description of trillOamMepPtrIngress: s/PTM/PTR/. Similar comment for trillOamMepPtrEgress. 5) Syntax error for trillOamMepPtrIngressPortIdSubtype: syntax should be LldpPortIdSubtype. Descriptions of trillOamMepPtrIngressPortIdSubtype and trillOamMepPtrIngressPortId should be interchanged. Similar comments for trillOamMepPtrEgressPortIdSubtype and trillOamMepPtrEgressPortId. Note that syntax is also stated in the Entry definition and has to be fixed there, too. 6) Same problem as 5) for the corresponding trillOamMtvrTable objects. 7) Security Considerations, third para, first-to-second lines: s/MAC-ACCESS/MAX-ACCESS/
- [Gen-art] Last Call review of draft-ietf-trill-oa… Tom Taylor
- [Gen-art] Last Call review of draft-ietf-trill-oa… Tom Taylor
- Re: [Gen-art] Last Call review of draft-ietf-tril… Deepak Kumar (dekumar)
- Re: [Gen-art] Last Call review of draft-ietf-tril… Tom Taylor
- Re: [Gen-art] Last Call review of draft-ietf-tril… Jari Arkko
- Re: [Gen-art] Last Call review of draft-ietf-tril… Deepak Kumar (dekumar)
- Re: [Gen-art] Last Call review of draft-ietf-tril… Tom Taylor